)]}'
{"id":"openstack%2Fpython-keystoneclient~16230","triplet_id":"openstack%2Fpython-keystoneclient~master~I3849598d6eefd2bfcb04e27d723f08fb1935c231","project":"openstack/python-keystoneclient","branch":"master","topic":"auth-token-verification","hashtags":[],"change_id":"I3849598d6eefd2bfcb04e27d723f08fb1935c231","subject":"Throw validation response into the environment","status":"MERGED","created":"2012-11-15 21:21:04.000000000","updated":"2012-11-16 01:34:41.000000000","submitted":"2012-11-16 01:34:41.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2ee09867b2aad0d505b2270bedb306496d26a9e7","_number":16230,"virtual_id_number":16230,"owner":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2012-11-16 01:34:41.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2012-11-16 00:39:04.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":2,"date":"2012-11-15 23:07:59.000000000","_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2012-11-16 00:39:04.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},{"value":0,"date":"2012-11-15 22:04:09.000000000","_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":1,"date":"2012-11-15 23:07:59.000000000","_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-11-15 21:43:13.000000000","updated_by":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"reviewer":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"state":"REVIEWER"},{"updated":"2012-11-15 23:07:59.000000000","updated_by":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"reviewer":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"state":"REVIEWER"},{"updated":"2012-11-16 00:39:04.000000000","updated_by":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"reviewer":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"state":"REVIEWER"},{"updated":"2012-11-16 01:34:41.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"413e8d07cc871a28d34b1803c8d56679bf81b957","author":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"date":"2012-11-15 21:43:13.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\nKevin,\n\nI like it - much simpler, very clear in purpose. Request you add relevant text to the docstring asserting that we\u0027re now putting the token into the environment for downstream use, otherwise LGTM","accounts_in_message":[],"_revision_number":1},{"id":"f211ab6550fd67fce4acddeae1840cd6c2e2bada","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-11-15 22:04:09.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"3e1af80e141ea5c34481d7432fa5a3567db040d9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-15 22:23:17.000000000","message":"Patch Set 2: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/16230/2/check/gate-python-keystoneclient-merge/474 : SUCCESS\n- http://logs.openstack.org/16230/2/check/gate-python-keystoneclient-docs/325 : SUCCESS\n- http://logs.openstack.org/16230/2/check/gate-python-keystoneclient-pep8/469 : SUCCESS\n- http://logs.openstack.org/16230/2/check/gate-python-keystoneclient-python26/401 : SUCCESS\n- http://logs.openstack.org/16230/2/check/gate-python-keystoneclient-python27/403 : SUCCESS\n- http://logs.openstack.org/16230/2/check/gate-tempest-devstack-vm/18721 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"57aed35a66a0cc2e638c7f5a33de8ff65a5b6f84","author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"date":"2012-11-15 23:07:59.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"45da19b09b895cc4c8c086b142ed5e95bbeffedb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-15 23:31:30.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttps://jenkins.openstack.org/zuul/status","accounts_in_message":[],"_revision_number":2},{"id":"deb41eced17bc70e0e77f6bb220c044e04803fb4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-16 00:24:43.000000000","message":"Patch Set 2: Fails\n\nBuild failed\n\n- http://logs.openstack.org/16230/2/gate/gate-python-keystoneclient-merge/475 : SUCCESS\n- http://logs.openstack.org/16230/2/gate/gate-python-keystoneclient-docs/326 : SUCCESS\n- http://logs.openstack.org/16230/2/gate/gate-python-keystoneclient-pep8/470 : SUCCESS\n- http://logs.openstack.org/16230/2/gate/gate-python-keystoneclient-python26/402 : SUCCESS\n- http://logs.openstack.org/16230/2/gate/gate-python-keystoneclient-python27/404 : SUCCESS\n- http://logs.openstack.org/16230/2/gate/gate-tempest-devstack-vm/18758 : FAILURE\n","accounts_in_message":[],"_revision_number":2},{"id":"4619cf5d699d00df04235c6150f760c945ae04f0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-16 00:39:04.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttps://jenkins.openstack.org/zuul/status","accounts_in_message":[],"_revision_number":2},{"id":"2932588ab6d2e53e03aa33ffc717b279a0bccda9","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2012-11-16 00:39:04.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\nreverify","accounts_in_message":[],"_revision_number":2},{"id":"ecc3eddb96eab772e75c4ec0c80b5706cbfb14da","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-16 01:34:41.000000000","message":"Patch Set 2: Verified\n\nBuild successful\n\n- http://logs.openstack.org/16230/2/gate/gate-python-keystoneclient-merge/477 : SUCCESS\n- http://logs.openstack.org/16230/2/gate/gate-python-keystoneclient-docs/327 : SUCCESS\n- http://logs.openstack.org/16230/2/gate/gate-python-keystoneclient-pep8/471 : SUCCESS\n- http://logs.openstack.org/16230/2/gate/gate-python-keystoneclient-python26/403 : SUCCESS\n- http://logs.openstack.org/16230/2/gate/gate-python-keystoneclient-python27/405 : SUCCESS\n- http://logs.openstack.org/16230/2/gate/gate-tempest-devstack-vm/18779 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"1290cecbe3348c4554fc4559cb18041a8b107c9d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-16 01:34:41.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"10e16be489dc13ff44d1abad71fc7ad259838a10","revisions":{"d10289c07fda1af29d5e5680cc5e63cf7fd99b01":{"kind":"REWORK","_number":1,"created":"2012-11-15 21:21:04.000000000","uploader":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"ref":"refs/changes/30/16230/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/30/16230/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/30/16230/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/30/16230/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/30/16230/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/30/16230/1"}}},"commit":{"parents":[{"commit":"e39351ec65bb00b33d3d57785976daefe9d27c2c","subject":"Merge \"HACKING compliance: consistent usage of \u0027except\u0027\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/e39351ec65bb00b33d3d57785976daefe9d27c2c"}]}],"author":{"name":"Kevin L. Mitchell","email":"kevin.mitchell@rackspace.com","date":"2012-11-15 21:20:35.000000000","tz":-360},"committer":{"name":"Kevin L. Mitchell","email":"kevin.mitchell@rackspace.com","date":"2012-11-15 21:20:35.000000000","tz":-360},"subject":"Throw validation response into the environment","message":"Throw validation response into the environment\n\nAllow other middleware access to the raw response from the token\nvalidation step by adding it to the WSGI environment in the\n\u0027keystone.token_info\u0027 variable.\n\nChange-Id: I3849598d6eefd2bfcb04e27d723f08fb1935c231\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/d10289c07fda1af29d5e5680cc5e63cf7fd99b01"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/d10289c07fda1af29d5e5680cc5e63cf7fd99b01"}]},"branch":"refs/heads/master"},"10e16be489dc13ff44d1abad71fc7ad259838a10":{"kind":"REWORK","_number":2,"created":"2012-11-15 22:04:09.000000000","uploader":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"ref":"refs/changes/30/16230/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/30/16230/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/30/16230/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/30/16230/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/30/16230/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/30/16230/2"}}},"commit":{"parents":[{"commit":"e39351ec65bb00b33d3d57785976daefe9d27c2c","subject":"Merge \"HACKING compliance: consistent usage of \u0027except\u0027\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/e39351ec65bb00b33d3d57785976daefe9d27c2c"}]}],"author":{"name":"Kevin L. Mitchell","email":"kevin.mitchell@rackspace.com","date":"2012-11-15 22:03:58.000000000","tz":-360},"committer":{"name":"Kevin L. Mitchell","email":"kevin.mitchell@rackspace.com","date":"2012-11-15 22:03:58.000000000","tz":-360},"subject":"Throw validation response into the environment","message":"Throw validation response into the environment\n\nAllow other middleware access to the raw response from the token\nvalidation step by adding it to the WSGI environment in the\n\u0027keystone.token_info\u0027 variable.\n\nChange-Id: I3849598d6eefd2bfcb04e27d723f08fb1935c231\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/10e16be489dc13ff44d1abad71fc7ad259838a10"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/10e16be489dc13ff44d1abad71fc7ad259838a10"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}