)]}'
{"id":"openstack%2Fpython-keystoneclient~164066","triplet_id":"openstack%2Fpython-keystoneclient~master~I917503ae54c9abcff417f0a0368abb765a847b6e","project":"openstack/python-keystoneclient","branch":"master","topic":"bug/1431649","hashtags":[],"change_id":"I917503ae54c9abcff417f0a0368abb765a847b6e","subject":"Make non-import packages lazy","status":"MERGED","created":"2015-03-13 03:55:01.000000000","updated":"2015-04-06 07:06:51.000000000","submitted":"2015-04-06 07:06:49.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e92cacd4fa13e0409cb86876d65440fcf0f3b774","_number":164066,"virtual_id_number":164066,"owner":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2015-04-06 07:06:49.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"date":"2015-04-05 22:35:50.000000000","_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},{"value":0,"date":"2015-03-18 00:01:40.000000000","_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},{"value":0,"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2015-04-06 00:30:16.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-03-17 13:28:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":2,"date":"2015-04-06 05:53:00.000000000","_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":1,"date":"2015-04-05 22:35:59.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},{"value":0,"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},{"value":1,"date":"2015-04-05 23:21:18.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":1,"date":"2015-04-06 05:53:00.000000000","_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},{"value":0,"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},{"value":0,"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-03-16 10:50:49.000000000","updated_by":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"reviewer":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"state":"REVIEWER"},{"updated":"2015-03-17 13:28:31.000000000","updated_by":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"reviewer":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"state":"REVIEWER"},{"updated":"2015-03-18 00:01:40.000000000","updated_by":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"reviewer":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"state":"REVIEWER"},{"updated":"2015-04-05 22:35:50.000000000","updated_by":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"reviewer":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"state":"REVIEWER"},{"updated":"2015-04-05 23:21:18.000000000","updated_by":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"reviewer":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"state":"REVIEWER"},{"updated":"2015-04-06 00:30:16.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2015-04-06 05:53:00.000000000","updated_by":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"reviewer":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"state":"REVIEWER"},{"updated":"2015-04-06 07:06:49.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"c014d40108ea5acc1cdbc3ab2805ec9a345164d3","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2015-03-13 03:55:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"47866738901da898fc6cae06bdfb64d639a80ea1","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2015-03-13 03:59:21.000000000","message":"Patch Set 1:\n\nOn my current box, before: 0.16 seconds                                          \nafter: 0.10 seconds                                                                  \n\nand scale those times up for slow devstack boxes\n\nTested with:\n\n python -c \"import timeit; print timeit.timeit(\u0027from keystoneclient import session\u0027,number\u003d1)\"","accounts_in_message":[],"_revision_number":1},{"id":"8e9555fd8642923129ea49549b0fca37809797fc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-13 04:56:15.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/66/164066/1/check/gate-python-keystoneclient-python26/97d66f6/ : SUCCESS in 2m 10s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/66/164066/1/check/gate-python-keystoneclient-pep8/b284a5b/ : SUCCESS in 2m 17s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/66/164066/1/check/gate-python-keystoneclient-docs/6915454//doc/build/html/ : SUCCESS in 3m 18s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/66/164066/1/check/gate-python-keystoneclient-python27/800c791/ : SUCCESS in 2m 35s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/66/164066/1/check/gate-python-keystoneclient-python34/d415e61/ : SUCCESS in 5m 03s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient-juno http://logs.openstack.org/66/164066/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient-juno/f0fc89a/ : SUCCESS in 47m 18s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/66/164066/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/990f404/ : SUCCESS in 52m 35s\n- check-keystoneclient-dsvm-functional http://logs.openstack.org/66/164066/1/check/check-keystoneclient-dsvm-functional/9400b66/ : SUCCESS in 18m 33s","accounts_in_message":[],"_revision_number":1},{"id":"f735e9ec7b3a24a61eac2bdbc820d1c590832df9","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-03-13 12:52:03.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"d7e44146d02dcbd9f87171f803f75a7e9e772c8a","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2015-03-16 10:50:49.000000000","message":"Patch Set 1:\n\nI don\u0027t have a problem with the change. I\u0027m concerned though about the change to the public interface. This means you remove all those from the base keystoneclient object.\n\nBrant?","accounts_in_message":[],"_revision_number":1},{"id":"6197a5780a90f56fd839ab7cf9077ceee683b410","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-03-16 13:49:31.000000000","message":"Patch Set 1:\n\nThe symbols are still listed in __all__, so doesn\u0027t that make them still available?","accounts_in_message":[],"_revision_number":1},{"id":"b06e6c885c2413a2acd750a95f4aa8c7b9f11356","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2015-03-16 21:06:53.000000000","message":"Patch Set 1:\n\nNo - not in my quick test. If you don\u0027t import them they are not available for __all__ to export. \n\nBefore: \n\nIn [1]: import keystoneclient\nk\nIn [2]: keystoneclient.access\nOut[2]: \u003cmodule \u0027keystoneclient.access\u0027 from \u0027/home/jlennox/work/python-keystoneclient/keystoneclient/access.pyc\u0027\u003e\n\n\nAfter: \n\nIn [1]: import keystoneclient\n\nIn [2]: keystoneclient.access\n---------------------------------------------------------------------------\nAttributeError                            Traceback (most recent call last)\n\u003cipython-input-2-bc1dc6898c90\u003e in \u003cmodule\u003e()\n----\u003e 1 keystoneclient.access\n\nAttributeError: \u0027module\u0027 object has no attribute \u0027access\u0027","accounts_in_message":[],"_revision_number":1},{"id":"03f7270c8e925cbb80979c1796bafb905c4e2bdb","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2015-03-16 21:27:54.000000000","message":"Patch Set 1:\n\nThat\u0027s too bad this breaks a public API. I wonder if there is anyway we can use lazy loading here","accounts_in_message":[],"_revision_number":1},{"id":"204a4aa54e3dbb2908310074464344e8cf8640f8","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-03-16 21:48:04.000000000","message":"Patch Set 1: -Code-Review","accounts_in_message":[],"_revision_number":1},{"id":"8b08089b702a66777151038e0ada12cb84b41be1","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-03-17 00:11:15.000000000","message":"Patch Set 1:\n\nthe irony here is that the imported modules doesn\u0027t include the auth plugins stuff that everybody actually does use.","accounts_in_message":[],"_revision_number":1},{"id":"85111fd88e792d070e04d9fe2d8b5d4caa978eeb","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-03-17 00:12:30.000000000","message":"Patch Set 1:\n\nIs it worth it to break backwards compatibility in this case... would be interesting to know how bad it really is... not sure how useful these symbols actually are.","accounts_in_message":[],"_revision_number":1},{"id":"62f6491c180a118c821dc0cb5600d992c564a525","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-03-17 00:16:22.000000000","message":"Patch Set 1:\n\nthese imports are actually kind of handy, since I can\n\n import keystoneclient\n keystoneclient.v3.client.Client(...)\n\nand have a working application.","accounts_in_message":[],"_revision_number":1},{"id":"0b1c0ac55f5296ab3d57b2ef4d65147210164f5c","author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"date":"2015-03-17 00:36:03.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"80d365f52016beaabde070112c625e78513066f1","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-03-17 01:07:18.000000000","message":"Patch Set 2: Code-Review-1\n\n(3 comments)\n\npep8 issues, otherwise I tried this and it worked for me.","accounts_in_message":[],"_revision_number":2},{"id":"87ec5ba1db8094d066c64cc7b3a0884eb0fa5dbb","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-03-17 01:15:44.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"41370bf6e2eadb3cd34f084f5c0dda3c18500b72","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-03-17 01:24:44.000000000","message":"Patch Set 2:\n\nAs I said, I\u0027m fine with this approach, but wondering if it would be worth it to use an existing library like Importing -- https://pypi.python.org/pypi/Importing? , although that doesn\u0027t seem to work with py3.","accounts_in_message":[],"_revision_number":2},{"id":"3f16ea4925ae0cfd554def4795790895b9c02195","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-17 02:05:49.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/66/164066/2/check/gate-python-keystoneclient-python26/4a32210/ : SUCCESS in 2m 16s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/66/164066/2/check/gate-python-keystoneclient-pep8/1462406/ : FAILURE in 2m 35s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/66/164066/2/check/gate-python-keystoneclient-docs/0580868//doc/build/html/ : SUCCESS in 3m 20s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/66/164066/2/check/gate-python-keystoneclient-python27/0581272/ : SUCCESS in 3m 10s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/66/164066/2/check/gate-python-keystoneclient-python34/a29d86d/ : SUCCESS in 5m 22s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient-juno http://logs.openstack.org/66/164066/2/check/gate-tempest-dsvm-neutron-src-python-keystoneclient-juno/7fc0039/ : SUCCESS in 1h 02m 06s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/66/164066/2/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/fa85f57/ : SUCCESS in 51m 43s\n- check-keystoneclient-dsvm-functional http://logs.openstack.org/66/164066/2/check/check-keystoneclient-dsvm-functional/af38e93/ : SUCCESS in 19m 56s","accounts_in_message":[],"_revision_number":2},{"id":"9096c191a43f133ea6a8adf76f8872a3b1b9e024","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-03-17 06:32:46.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"b75a1e3d262eb0d7204589725eff33a5c073bcc7","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-03-17 13:08:00.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"54e61c5e1c173613429cb48933e15306295119de","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-03-17 13:28:06.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"22f56a606fee078e5f5a32b2db288dd4f22f9a57","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-03-17 13:28:31.000000000","message":"Patch Set 3: Code-Review+1\n\nFixed pep8 issues.","accounts_in_message":[],"_revision_number":3},{"id":"a73e646260bc2e5b66e0743aae5f94ad79f426bd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-17 14:28:29.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/66/164066/3/check/gate-python-keystoneclient-python26/c0391d6/ : SUCCESS in 2m 13s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/66/164066/3/check/gate-python-keystoneclient-pep8/e91bf73/ : SUCCESS in 2m 31s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/66/164066/3/check/gate-python-keystoneclient-docs/50c359f//doc/build/html/ : SUCCESS in 3m 16s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/66/164066/3/check/gate-python-keystoneclient-python27/92c8e8d/ : SUCCESS in 2m 18s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/66/164066/3/check/gate-python-keystoneclient-python34/4a2436f/ : SUCCESS in 3m 47s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient-juno http://logs.openstack.org/66/164066/3/check/gate-tempest-dsvm-neutron-src-python-keystoneclient-juno/679472a/ : SUCCESS in 46m 03s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/66/164066/3/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/a73ce3b/ : SUCCESS in 49m 57s\n- check-keystoneclient-dsvm-functional http://logs.openstack.org/66/164066/3/check/check-keystoneclient-dsvm-functional/d590115/ : SUCCESS in 18m 53s","accounts_in_message":[],"_revision_number":3},{"id":"1846a58da2ba9b05f9df84d74280f9cf8e2495c2","author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"date":"2015-04-05 22:35:50.000000000","message":"Patch Set 3:\n\nOkay this really works, and I would like to see this in upstream. \n\nYou can compare output of profimp (https://github.com/boris-42/profimp): \n\n\n  before 169ms: http://boris-42.github.io/keystone/before.html\n  after 76ms: http://boris-42.github.io/keystone/after.html","accounts_in_message":[],"_revision_number":3},{"id":"fc729d85daf2602f6d8c7e4fc0f19284cdf365b1","author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"date":"2015-04-05 22:35:59.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"bc79d5ebc2789730c5e89855ee6ebca87ce6564f","author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"date":"2015-04-05 23:21:18.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"e727e3fd40263857fd1a1ed7738ac3269125ce9d","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-04-06 00:30:16.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"50870c83f4788ccb81829eff41c78362de63195f","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2015-04-06 05:53:00.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"98183cd9ac2eaf44f5df5b7fd9329dd9374b7390","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-06 05:53:05.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"a09eab935790ad06fa22917f621ad978f1eeff38","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-06 07:06:49.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/66/164066/3/gate/gate-python-keystoneclient-python26/5b7d6ab/ : SUCCESS in 2m 17s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/66/164066/3/gate/gate-python-keystoneclient-docs/29b7016//doc/build/html/ : SUCCESS in 2m 54s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/66/164066/3/gate/gate-python-keystoneclient-pep8/9140016/ : SUCCESS in 2m 03s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/66/164066/3/gate/gate-python-keystoneclient-python27/c58b502/ : SUCCESS in 2m 59s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/66/164066/3/gate/gate-python-keystoneclient-python34/61ba8f1/ : SUCCESS in 4m 27s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/66/164066/3/gate/gate-tempest-dsvm-neutron-src-python-keystoneclient/e161a16/ : SUCCESS in 1h 13m 40s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/66/164066/3/gate/gate-keystoneclient-dsvm-functional/a7ba4f6/ : SUCCESS in 19m 50s","accounts_in_message":[],"_revision_number":3},{"id":"07a6cb32dd345fd59e560972463ce8bae9cd03c2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-06 07:06:51.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"c0145e5fe1a8abdcfe8f95bdb0f6cad647db0465","revisions":{"14682f2cd4d32d24b286a60c97f0b502068adfe4":{"kind":"REWORK","_number":1,"created":"2015-03-13 03:55:01.000000000","uploader":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"ref":"refs/changes/66/164066/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/66/164066/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/66/164066/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/66/164066/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/66/164066/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/66/164066/1"}}},"commit":{"parents":[{"commit":"385c19b8b6bfb717fc4b39e211c9ef05b80d2df0","subject":"Merge \"Fix time issue in AccessInfo test\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/385c19b8b6bfb717fc4b39e211c9ef05b80d2df0"}]}],"author":{"name":"Joe Gordon","email":"joe.gordon0@gmail.com","date":"2015-03-13 03:43:36.000000000","tz":-420},"committer":{"name":"Joe Gordon","email":"joe.gordon0@gmail.com","date":"2015-03-13 03:54:53.000000000","tz":-420},"subject":"Revert \"Imports to fix build warnings\"","message":"Revert \"Imports to fix build warnings\"\n\nThis patch was importing a lot of things in __init__ which makes loading\nanything, say session, really slow. The load time for keystoneclient is\nreally critical since every client uses it. And having a CLI take\nseveral seconds to do nothing is really bad user experience.\n\nWithout this revert \u0027from keystoneclient import session\u0027 takes about half a second\n\nThis reverts commit 6659902a731767b3405d68e515c8edcc3af81119.\n\nChange-Id: I917503ae54c9abcff417f0a0368abb765a847b6e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/14682f2cd4d32d24b286a60c97f0b502068adfe4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/14682f2cd4d32d24b286a60c97f0b502068adfe4"}]},"branch":"refs/heads/master"},"9bdb5e9418ecca6eb379d9ebbd45d048132d1569":{"kind":"REWORK","_number":2,"created":"2015-03-17 00:36:03.000000000","uploader":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"ref":"refs/changes/66/164066/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/66/164066/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/66/164066/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/66/164066/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/66/164066/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/66/164066/2"}}},"commit":{"parents":[{"commit":"385c19b8b6bfb717fc4b39e211c9ef05b80d2df0","subject":"Merge \"Fix time issue in AccessInfo test\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/385c19b8b6bfb717fc4b39e211c9ef05b80d2df0"}]}],"author":{"name":"Joe Gordon","email":"joe.gordon0@gmail.com","date":"2015-03-13 03:43:36.000000000","tz":-420},"committer":{"name":"Robert Collins","email":"rbtcollins@hp.com","date":"2015-03-17 00:30:06.000000000","tz":780},"subject":"Make non-import packages lazy","message":"Make non-import packages lazy\n\n6659902a731767b3405d68e515c8edcc3af81119 caused a lot of importing a\nlot of things in __init__ which makes loading anything, say session,\nreally slow. The load time for keystoneclient is really critical since\nevery client uses it. And having a CLI take several seconds to do\nnothing is really bad user experience.\n\nThis drops the hot cache import time of keystoneclient.session down to\n160ms which is about 60ms faster (down from 220ms without this patch)\nfor me.\n\nChange-Id: I917503ae54c9abcff417f0a0368abb765a847b6e\nPartial-Bug: #1431649\nCo-Authored-By: Robert Collins \u003crbtcollins@hp.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/9bdb5e9418ecca6eb379d9ebbd45d048132d1569"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/9bdb5e9418ecca6eb379d9ebbd45d048132d1569"}]},"branch":"refs/heads/master"},"c0145e5fe1a8abdcfe8f95bdb0f6cad647db0465":{"kind":"REWORK","_number":3,"created":"2015-03-17 13:28:06.000000000","uploader":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"ref":"refs/changes/66/164066/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/66/164066/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/66/164066/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/66/164066/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/66/164066/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/66/164066/3"}}},"commit":{"parents":[{"commit":"c30cf7807c1cce4f7bf9833db66a4138faf76268","subject":"Merge \"Federation Service Providers CRUD operations\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/c30cf7807c1cce4f7bf9833db66a4138faf76268"}]}],"author":{"name":"Joe Gordon","email":"joe.gordon0@gmail.com","date":"2015-03-13 03:43:36.000000000","tz":-420},"committer":{"name":"Brant Knudson","email":"bknudson@us.ibm.com","date":"2015-03-17 13:27:47.000000000","tz":-300},"subject":"Make non-import packages lazy","message":"Make non-import packages lazy\n\n6659902a731767b3405d68e515c8edcc3af81119 caused a lot of importing a\nlot of things in __init__ which makes loading anything, say session,\nreally slow. The load time for keystoneclient is really critical since\nevery client uses it. And having a CLI take several seconds to do\nnothing is really bad user experience.\n\nThis drops the hot cache import time of keystoneclient.session down to\n160ms which is about 60ms faster (down from 220ms without this patch)\nfor me.\n\nChange-Id: I917503ae54c9abcff417f0a0368abb765a847b6e\nPartial-Bug: #1431649\nCo-Authored-By: Robert Collins \u003crbtcollins@hp.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/c0145e5fe1a8abdcfe8f95bdb0f6cad647db0465"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/c0145e5fe1a8abdcfe8f95bdb0f6cad647db0465"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}