)]}'
{"keystoneclient/v3/domain_configs.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"813a13312bf9c4009492a7677aba42c0690bb025","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class DomainConfigManager(base.Manager):"},{"line_number":20,"context_line":"    \"\"\"Manager class for manipulating domain config associations.\"\"\""},{"line_number":21,"context_line":"    key \u003d \u0027config\u0027"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def _build_base_url(self, domain, group\u003dNone, option\u003dNone):"},{"line_number":24,"context_line":"        domain_id \u003d base.getid(domain)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_c1b6003d","line":21,"updated":"2015-03-27 07:27:39.000000000","message":"this isn\u0027t used","commit_id":"fddc18822bd580cf8ed03fd121713f979efc085b"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"602e2c161d445f3ad6442dff33b700239a79910b","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class DomainConfigManager(base.Manager):"},{"line_number":20,"context_line":"    \"\"\"Manager class for manipulating domain config associations.\"\"\""},{"line_number":21,"context_line":"    key \u003d \u0027config\u0027"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def _build_base_url(self, domain, group\u003dNone, option\u003dNone):"},{"line_number":24,"context_line":"        domain_id \u003d base.getid(domain)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_c55ce9ef","line":21,"in_reply_to":"fa963961_c1b6003d","updated":"2015-04-10 20:21:24.000000000","message":"Done","commit_id":"fddc18822bd580cf8ed03fd121713f979efc085b"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"813a13312bf9c4009492a7677aba42c0690bb025","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def create_domain_config(self, domain, config):"},{"line_number":35,"context_line":"        \"\"\"Create the config for a domain.\"\"\""},{"line_number":36,"context_line":"        if not domain:"},{"line_number":37,"context_line":"            raise ValueError(_(\u0027domain is required\u0027))"},{"line_number":38,"context_line":"        if not config:"},{"line_number":39,"context_line":"            raise ValueError(_(\u0027config is required\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_0194e888","line":36,"updated":"2015-03-27 07:27:39.000000000","message":"I don\u0027t know what these check net you, they are positional args, so unless you anticipate the function being called like create_domain_config(None, None). then checking here seems extra cautious. maybe let the other python pros weigh in","commit_id":"fddc18822bd580cf8ed03fd121713f979efc085b"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"602e2c161d445f3ad6442dff33b700239a79910b","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def create_domain_config(self, domain, config):"},{"line_number":35,"context_line":"        \"\"\"Create the config for a domain.\"\"\""},{"line_number":36,"context_line":"        if not domain:"},{"line_number":37,"context_line":"            raise ValueError(_(\u0027domain is required\u0027))"},{"line_number":38,"context_line":"        if not config:"},{"line_number":39,"context_line":"            raise ValueError(_(\u0027config is required\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_a5f9ddca","line":36,"in_reply_to":"fa963961_0194e888","updated":"2015-04-10 20:21:24.000000000","message":"I was just ensuring that we deflect badly formed calls from hitting the server if we know they will fail.","commit_id":"fddc18822bd580cf8ed03fd121713f979efc085b"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"813a13312bf9c4009492a7677aba42c0690bb025","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            url\u003dbase_url, body\u003dconfig, return_raw\u003dTrue)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def get_domain_config(self, domain, group\u003dNone, option\u003dNone):"},{"line_number":46,"context_line":"        \"\"\"Get the config, or partial config, for a domain.\"\"\""},{"line_number":47,"context_line":"        if not domain:"},{"line_number":48,"context_line":"            raise ValueError(_(\u0027domain is required\u0027))"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_61f3b40b","line":46,"updated":"2015-03-27 07:27:39.000000000","message":"how about? \n\n  Get a config (or partial config), for a domain\n\ncan be repeated for all the docstrings","commit_id":"fddc18822bd580cf8ed03fd121713f979efc085b"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"602e2c161d445f3ad6442dff33b700239a79910b","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            url\u003dbase_url, body\u003dconfig, return_raw\u003dTrue)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def get_domain_config(self, domain, group\u003dNone, option\u003dNone):"},{"line_number":46,"context_line":"        \"\"\"Get the config, or partial config, for a domain.\"\"\""},{"line_number":47,"context_line":"        if not domain:"},{"line_number":48,"context_line":"            raise ValueError(_(\u0027domain is required\u0027))"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_85f6e1d5","line":46,"in_reply_to":"fa963961_61f3b40b","updated":"2015-04-10 20:21:24.000000000","message":"Done","commit_id":"fddc18822bd580cf8ed03fd121713f979efc085b"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"1b9e11d927e35bb0cb5ea4272f3791777e0b02f1","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    def delete_domain_config(self, domain, group\u003dNone, option\u003dNone):"},{"line_number":77,"context_line":"        \"\"\"Delete the config, or partial config, for a domain.\"\"\""},{"line_number":78,"context_line":"        if not domain:"},{"line_number":79,"context_line":"            raise ValueError(_(\u0027domain is required\u0027))"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        base_url \u003d self._build_base_url("},{"line_number":82,"context_line":"            domain, group\u003dgroup, option\u003doption)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_5869da8a","line":79,"updated":"2015-03-26 17:34:28.000000000","message":"The domain checking is repeated in all methods, would be nice to have a private one to do this checking","commit_id":"fddc18822bd580cf8ed03fd121713f979efc085b"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"f3f34db16e16af43531b3ae5c31ca7ee47f1735b","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    def delete_domain_config(self, domain, group\u003dNone, option\u003dNone):"},{"line_number":77,"context_line":"        \"\"\"Delete the config, or partial config, for a domain.\"\"\""},{"line_number":78,"context_line":"        if not domain:"},{"line_number":79,"context_line":"            raise ValueError(_(\u0027domain is required\u0027))"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        base_url \u003d self._build_base_url("},{"line_number":82,"context_line":"            domain, group\u003dgroup, option\u003doption)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_f859ce8f","line":79,"in_reply_to":"fa963961_5869da8a","updated":"2015-03-26 17:42:12.000000000","message":"Done","commit_id":"fddc18822bd580cf8ed03fd121713f979efc085b"}]}