)]}'
{"keystoneclient/v2_0/shell.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"b2f50b1e0f788739ed4c6aa62692b0b93d2d332f","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"@utils.arg(\u0027--orig-pass\u0027, metavar\u003d\u0027\u003corig-password\u003e\u0027, dest\u003d\u0027origpasswd\u0027,"},{"line_number":113,"context_line":"           required\u003dFalse, help\u003d\u0027Original password\u0027)"},{"line_number":114,"context_line":"@utils.arg(\u0027--pass\u0027, metavar\u003d\u0027\u003cpassword\u003e\u0027, dest\u003d\u0027passwd\u0027, required\u003dFalse,"},{"line_number":115,"context_line":"           help\u003d\u0027Desired new password\u0027)"},{"line_number":116,"context_line":"def do_password_update(kc, args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2Fw5U%3D","line":113,"updated":"2012-11-26 20:32:30.000000000","message":"--orig-pass is a bit redundant with --os-password / OS_PASSWORD, albeit they may not be set (if using token / endpoint, etc).\n\nI\u0027d prefer the following changes:\n\n--orig-pass -\u003e --current-password (optional, defaulting first to --os-password / OS_PASSWORD, and then to a prompt)\n\n--pass -\u003e --new-password (required)\n\nA warning should also be printed back to the user at the end if OS_PASSWORD is already set and it doesn\u0027t match the --new-password.","commit_id":"96340edfea108482b813926284f9f215ed15eddb"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"b2f50b1e0f788739ed4c6aa62692b0b93d2d332f","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    # appear in bash history etc.."},{"line_number":122,"context_line":"    origpasswd \u003d args.origpasswd"},{"line_number":123,"context_line":"    if origpasswd is None:"},{"line_number":124,"context_line":"        origpasswd \u003d getpass.getpass(\u0027Enter your original password : \u0027)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    passwd \u003d args.passwd"},{"line_number":127,"context_line":"    if passwd is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2Fw4Y%3D","line":124,"updated":"2012-11-26 20:32:30.000000000","message":"These prompts don\u0027t really match the existing password prompts... I\u0027d suggest the following:\n\n\u0027Current Password: \u0027","commit_id":"96340edfea108482b813926284f9f215ed15eddb"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"b2f50b1e0f788739ed4c6aa62692b0b93d2d332f","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    passwd \u003d args.passwd"},{"line_number":127,"context_line":"    if passwd is None:"},{"line_number":128,"context_line":"        while True:"},{"line_number":129,"context_line":"            passwd1 \u003d getpass.getpass(\u0027Enter your new password    : \u0027)"},{"line_number":130,"context_line":"            passwd2 \u003d getpass.getpass(\u0027Re-enter your new password : \u0027)"},{"line_number":131,"context_line":"            if passwd1 \u003d\u003d passwd2:"},{"line_number":132,"context_line":"                passwd \u003d passwd1"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2Fw4k%3D","line":129,"updated":"2012-11-26 20:32:30.000000000","message":"\u0027New Password: \u0027","commit_id":"96340edfea108482b813926284f9f215ed15eddb"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"b2f50b1e0f788739ed4c6aa62692b0b93d2d332f","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    if passwd is None:"},{"line_number":128,"context_line":"        while True:"},{"line_number":129,"context_line":"            passwd1 \u003d getpass.getpass(\u0027Enter your new password    : \u0027)"},{"line_number":130,"context_line":"            passwd2 \u003d getpass.getpass(\u0027Re-enter your new password : \u0027)"},{"line_number":131,"context_line":"            if passwd1 \u003d\u003d passwd2:"},{"line_number":132,"context_line":"                passwd \u003d passwd1"},{"line_number":133,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2Fw4g%3D","line":130,"updated":"2012-11-26 20:32:30.000000000","message":"\u0027Repeat New Password: \u0027 or \u0027New Password (Repeat): \u0027","commit_id":"96340edfea108482b813926284f9f215ed15eddb"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"2ab27202569253a8e8ab1d62427ead0cc45cedd3","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"@utils.arg(\u0027--current-password\u0027, metavar\u003d\u0027\u003ccurrent-password\u003e\u0027,"},{"line_number":113,"context_line":"           dest\u003d\u0027currentpasswd\u0027, required\u003dFalse, help\u003d\u0027Current password, \u0027"},{"line_number":114,"context_line":"                \u0027Defaults to the password as set by --os-username or \u0027"},{"line_number":115,"context_line":"                \u0027OS_USERNAME\u0027)"},{"line_number":116,"context_line":"@utils.arg(\u0027--new-password \u0027, metavar\u003d\u0027\u003cnew-password\u003e\u0027, dest\u003d\u0027newpasswd\u0027,"},{"line_number":117,"context_line":"           required\u003dFalse, help\u003d\u0027Desired new password\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMH%2F%2Fwb8%3D","line":114,"updated":"2012-11-27 02:24:20.000000000","message":"--os-username should be --os-password","commit_id":"588dad4411b17032be11076c66ed4994b02426cf"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"2ab27202569253a8e8ab1d62427ead0cc45cedd3","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        currentpasswd \u003d getpass.getpass(\u0027Current Password: \u0027)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    newpasswd \u003d args.newpasswd"},{"line_number":131,"context_line":"    if newpasswd is None:"},{"line_number":132,"context_line":"        while True:"},{"line_number":133,"context_line":"            passwd1 \u003d getpass.getpass(\u0027New Password: \u0027)"},{"line_number":134,"context_line":"            passwd2 \u003d getpass.getpass(\u0027Repeat New Password: \u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMH%2F%2FwT0%3D","line":131,"updated":"2012-11-27 02:24:20.000000000","message":"while new_password is None:","commit_id":"588dad4411b17032be11076c66ed4994b02426cf"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"2ab27202569253a8e8ab1d62427ead0cc45cedd3","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    kc.users.update_own_password(currentpasswd, newpasswd)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    if args.os_password is not None and args.os_password !\u003d newpasswd:"},{"line_number":142,"context_line":"        print \"You should update the password you are using to authenticate \"\\"},{"line_number":143,"context_line":"              \"to match your new password\""},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMH%2F%2FwTs%3D","line":141,"updated":"2012-11-27 02:24:20.000000000","message":"no reason to check if it\u0027s not None, the second check will suffice","commit_id":"588dad4411b17032be11076c66ed4994b02426cf"}]}