)]}'
{"id":"openstack%2Fpython-keystoneclient~16985","triplet_id":"openstack%2Fpython-keystoneclient~master~I8c39a797e79429dd21c5caf093b076a4b1757de0","project":"openstack/python-keystoneclient","branch":"master","topic":"version","hashtags":[],"change_id":"I8c39a797e79429dd21c5caf093b076a4b1757de0","subject":"Add --version CLI opt and __version__ module attr","status":"MERGED","created":"2012-11-27 16:54:31.000000000","updated":"2012-11-28 19:49:19.000000000","submitted":"2012-11-28 19:49:19.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"5d0df818b26911acac939b749a432ebdec70d26a","_number":16985,"virtual_id_number":16985,"owner":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2012-11-28 19:49:19.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},{"value":0,"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2012-11-28 19:30:29.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":2,"date":"2012-11-28 19:11:43.000000000","_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},{"value":0,"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"date":"2012-11-28 18:56:25.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2012-11-28 19:30:34.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"date":"2012-11-28 19:11:43.000000000","_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},{"value":0,"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"date":"2012-11-28 18:53:01.000000000","_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-11-27 17:09:30.000000000","updated_by":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"reviewer":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"state":"REVIEWER"},{"updated":"2012-11-28 19:11:43.000000000","updated_by":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"reviewer":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"state":"REVIEWER"},{"updated":"2012-11-28 19:30:34.000000000","updated_by":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"reviewer":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"state":"REVIEWER"},{"updated":"2012-11-28 19:49:19.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"46e6938eff5c97e5d3ef0b917c4d9490b9ebb751","author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"date":"2012-11-27 17:09:30.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"17527384b2d638cadafbc4232118def3bb6907c9","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2012-11-27 17:12:43.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"4a4402c21a0f444a77d2816f53d414bc41174389","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-27 17:15:09.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed\n\n- http://logs.openstack.org/16985/1/check/gate-python-keystoneclient-merge/495 : SUCCESS\n- http://logs.openstack.org/16985/1/check/gate-python-keystoneclient-docs/345 : SUCCESS\n- http://logs.openstack.org/16985/1/check/gate-python-keystoneclient-pep8/489 : FAILURE\n- http://logs.openstack.org/16985/1/check/gate-python-keystoneclient-python26/421 : SUCCESS\n- http://logs.openstack.org/16985/1/check/gate-python-keystoneclient-python27/423 : SUCCESS\n- http://logs.openstack.org/16985/1/check/gate-tempest-devstack-vm/20149 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"d8404ba07c084f2a0f6eb59c3b1d82af257e3312","author":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"date":"2012-11-27 20:00:45.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\nBrian - good with concept, how does versioninfo file get created? Is that something that the current openstack setup.py thing does for us today, or is that something we\u0027ll need to add in the releases to make this effective?","accounts_in_message":[],"_revision_number":1},{"id":"f814d6798b6660bed9730580df4f9d5bc1615268","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2012-11-27 20:06:00.000000000","message":"Patch Set 1:\n\nheckj, I wondered the same thing ... openstack.common.setup reads \u0026 writes keystoneclient/versioninfo, which is also also included in .gitignore","accounts_in_message":[],"_revision_number":1},{"id":"fe2c0c7f73061719812cf1d4701811882f49af18","author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"date":"2012-11-28 18:53:01.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"5b7ac6df3ae2ac281effb060d64b6fa43cb1da05","author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"date":"2012-11-28 18:56:25.000000000","message":"Patch Set 2:\n\nFixed that pep8 violation.\n\nNow to shed some light on what\u0027s going on with this patch:\n\nAs Dolph pointed out, the common setup code is what generates that versioninfo file. That setup code is called when we build a source tarball (e.g. python setup.py sdist). The versioninfo file is listed in .gitignore as we don\u0027t ever need to commit what we generate locally to the master repo. As a side-note, this code is already in use in python-novaclient and python-glanceclient.","accounts_in_message":[],"_revision_number":2},{"id":"23fa545af9099845088cfd7a93576e2f6637a14b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-28 19:10:45.000000000","message":"Patch Set 2: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/16985/2/check/gate-python-keystoneclient-merge/498 : SUCCESS\n- http://logs.openstack.org/16985/2/check/gate-python-keystoneclient-docs/348 : SUCCESS\n- http://logs.openstack.org/16985/2/check/gate-python-keystoneclient-pep8/492 : SUCCESS\n- http://logs.openstack.org/16985/2/check/gate-python-keystoneclient-python26/424 : SUCCESS\n- http://logs.openstack.org/16985/2/check/gate-python-keystoneclient-python27/426 : SUCCESS\n- http://logs.openstack.org/16985/2/check/gate-tempest-devstack-vm/20326 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"2db315a9234fe97ab47fbb614f939eef6fc89d8c","author":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"date":"2012-11-28 19:11:43.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\nCool - thanks Brian","accounts_in_message":[],"_revision_number":2},{"id":"70eba6cd69bb71bb6ef6127f6d49024ad97bde67","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2012-11-28 19:30:29.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"6119d1b6a7ee00c3433935e4d725b827e558dc0b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-28 19:30:34.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttps://jenkins.openstack.org/zuul/status","accounts_in_message":[],"_revision_number":2},{"id":"1bdc7ecdbf40e80adbf3b68f4a69a4e0edd2b150","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2012-11-28 19:30:34.000000000","message":"Patch Set 2: Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"3c216683161403629aad8417dcbdbaeea1c8d6dd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-28 19:49:19.000000000","message":"Patch Set 2: Verified\n\nBuild successful\n\n- http://logs.openstack.org/16985/2/gate/gate-python-keystoneclient-merge/499 : SUCCESS\n- http://logs.openstack.org/16985/2/gate/gate-python-keystoneclient-docs/349 : SUCCESS\n- http://logs.openstack.org/16985/2/gate/gate-python-keystoneclient-pep8/493 : SUCCESS\n- http://logs.openstack.org/16985/2/gate/gate-python-keystoneclient-python26/425 : SUCCESS\n- http://logs.openstack.org/16985/2/gate/gate-python-keystoneclient-python27/427 : SUCCESS\n- http://logs.openstack.org/16985/2/gate/gate-tempest-devstack-vm/20332 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"f99d9e174e14e56aebd5edfab2d737cb08954fed","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-28 19:49:19.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"2eb5e2c2abe83d285967dda1b2d86c612a9ccef5","revisions":{"2f52543ca2160c71707ca9d3e6b11141a7e25f34":{"kind":"REWORK","_number":1,"created":"2012-11-27 16:54:31.000000000","uploader":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"ref":"refs/changes/85/16985/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/85/16985/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/85/16985/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/85/16985/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/85/16985/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/85/16985/1"}}},"commit":{"parents":[{"commit":"66339b004ac0c0882afaf88b551db1e6896c1a09","subject":"Merge \"updating PEP8 to 1.3.3\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/66339b004ac0c0882afaf88b551db1e6896c1a09"}]}],"author":{"name":"Brian Waldon","email":"bcwaldon@gmail.com","date":"2012-11-27 16:46:26.000000000","tz":-300},"committer":{"name":"Brian Waldon","email":"bcwaldon@gmail.com","date":"2012-11-27 16:54:30.000000000","tz":-300},"subject":"Add --version CLI opt and __version__ module attr","message":"Add --version CLI opt and __version__ module attr\n\nChange-Id: I8c39a797e79429dd21c5caf093b076a4b1757de0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/2f52543ca2160c71707ca9d3e6b11141a7e25f34"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/2f52543ca2160c71707ca9d3e6b11141a7e25f34"}]},"branch":"refs/heads/master"},"2eb5e2c2abe83d285967dda1b2d86c612a9ccef5":{"kind":"REWORK","_number":2,"created":"2012-11-28 18:53:01.000000000","uploader":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"ref":"refs/changes/85/16985/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/85/16985/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/85/16985/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/85/16985/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/85/16985/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/85/16985/2"}}},"commit":{"parents":[{"commit":"66339b004ac0c0882afaf88b551db1e6896c1a09","subject":"Merge \"updating PEP8 to 1.3.3\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/66339b004ac0c0882afaf88b551db1e6896c1a09"}]}],"author":{"name":"Brian Waldon","email":"bcwaldon@gmail.com","date":"2012-11-27 16:46:26.000000000","tz":-300},"committer":{"name":"Brian Waldon","email":"bcwaldon@gmail.com","date":"2012-11-28 18:52:43.000000000","tz":-480},"subject":"Add --version CLI opt and __version__ module attr","message":"Add --version CLI opt and __version__ module attr\n\nChange-Id: I8c39a797e79429dd21c5caf093b076a4b1757de0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/2eb5e2c2abe83d285967dda1b2d86c612a9ccef5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/2eb5e2c2abe83d285967dda1b2d86c612a9ccef5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}