)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"b1d75aa88755ad591a39050f92cf29d3a6c321f4","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"MIN_TOKEN_LIFE_SECONDS is the number of seconds that the token provided"},{"line_number":10,"context_line":"must be valid for to be used when making authentication requests. 1"},{"line_number":11,"context_line":"seconds has always been a dumb number and was not based on any existing"},{"line_number":12,"context_line":"value."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Because a user token may be reused by a service to make requests on"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9aa53dc9_8b5b2c87","line":11,"updated":"2015-04-08 16:00:09.000000000","message":"seconds -\u003e second","commit_id":"a5bd2a8e4ac803784a35a7958ab6202c5990305c"}],"keystoneclient/auth/identity/base.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"ee0aa16073caf07cf1ae7cefc28969367477170b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":35,"context_line":"class BaseIdentityPlugin(base.BaseAuthPlugin):"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    # we count a token as valid if it is valid for at least this many seconds"},{"line_number":38,"context_line":"    MIN_TOKEN_LIFE_SECONDS \u003d 120"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def __init__(self,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa041b7_471300b9","line":37,"updated":"2015-04-03 01:23:09.000000000","message":"this comment have some opportunity for clarity. When I looked up the code, I had a slightly different interpretation from the doc.\n\nI think we need to add something like:  \" ... before the expiry  time\"","commit_id":"a5bd2a8e4ac803784a35a7958ab6202c5990305c"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"44cf0aff428abc2e1dc9efbc2ec691adcbe5d367","unresolved":false,"context_lines":[{"line_number":34,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":35,"context_line":"class BaseIdentityPlugin(base.BaseAuthPlugin):"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    # we count a token as valid if it is valid for at least this many seconds"},{"line_number":38,"context_line":"    MIN_TOKEN_LIFE_SECONDS \u003d 120"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def __init__(self,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_52a0509f","line":37,"in_reply_to":"baa041b7_471300b9","updated":"2015-04-08 04:42:01.000000000","message":"++","commit_id":"a5bd2a8e4ac803784a35a7958ab6202c5990305c"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"ee0aa16073caf07cf1ae7cefc28969367477170b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"class BaseIdentityPlugin(base.BaseAuthPlugin):"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    # we count a token as valid if it is valid for at least this many seconds"},{"line_number":38,"context_line":"    MIN_TOKEN_LIFE_SECONDS \u003d 120"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def __init__(self,"},{"line_number":41,"context_line":"                 auth_url\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa041b7_e75d747a","line":38,"updated":"2015-04-03 01:23:09.000000000","message":"Default timeout in Apache is 300 seconds, that could be the worst case.\n\nThis still sounds good to me. Better than 1 second.","commit_id":"a5bd2a8e4ac803784a35a7958ab6202c5990305c"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"3913aa9efc21e27347427c0921e99fdb7cff32bd","unresolved":false,"context_lines":[{"line_number":34,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":35,"context_line":"class BaseIdentityPlugin(base.BaseAuthPlugin):"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    # we count a token as valid if it is valid for at least this many seconds"},{"line_number":38,"context_line":"    MIN_TOKEN_LIFE_SECONDS \u003d 120"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def __init__(self,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_d8ac5637","line":37,"updated":"2015-04-08 23:39:10.000000000","message":"nit: can we applend: \" ... before the expiry time\" to make the docs clearer","commit_id":"86fcbfd6e624458fc165fd66855b2b32dd9ca0a5"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"04a6ee1ddaf0339ad3e68b736a5c17c17512d77d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":35,"context_line":"class BaseIdentityPlugin(base.BaseAuthPlugin):"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    # we count a token as valid if it is valid for at least this many seconds"},{"line_number":38,"context_line":"    MIN_TOKEN_LIFE_SECONDS \u003d 120"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def __init__(self,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_cfc36d88","line":37,"in_reply_to":"9aa53dc9_d8ac5637","updated":"2015-04-09 00:48:48.000000000","message":"ah, i did the new version with commit message changes directly from gerrit. I guess i could actually checkout the review and fix it .","commit_id":"86fcbfd6e624458fc165fd66855b2b32dd9ca0a5"}]}
