)]}'
{"keystoneclient/__init__.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"a619890de8fa59459097d1ed8d40626c5c695d19","unresolved":false,"context_lines":[{"line_number":32,"context_line":"import pkg_resources"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"__version__ \u003d pkg_resources.get_distribution(\u0027python-keystoneclient\u0027).version"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"__all__ \u003d ["},{"line_number":38,"context_line":"    # Modules"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_da4c5372","line":35,"updated":"2015-04-08 19:27:23.000000000","message":"Actually what I meant by my comment on the mailing list was to remove __version__ entirely and let callers that want to know what version is being used call pkg_resources directly.","commit_id":"e28cd282c149b9231e1ad016e16bc86d038c6fcc"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"bc07a76eacac495f899eaa2482ca9889e5260389","unresolved":false,"context_lines":[{"line_number":32,"context_line":"import pkg_resources"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"__version__ \u003d pkg_resources.get_distribution(\u0027python-keystoneclient\u0027).version"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"__all__ \u003d ["},{"line_number":38,"context_line":"    # Modules"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_aed714ec","line":35,"in_reply_to":"9aa53dc9_da4c5372","updated":"2015-04-08 20:08:32.000000000","message":"that makes more sense.","commit_id":"e28cd282c149b9231e1ad016e16bc86d038c6fcc"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"610236615aba3dfed08e1a9c4f598e34d270bec8","unresolved":false,"context_lines":[{"line_number":32,"context_line":"import pbr.version"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"__version__ \u003d pbr.version.VersionInfo(\u0027python-keystoneclient\u0027).version_string()"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"__all__ \u003d ["},{"line_number":38,"context_line":"    # Modules"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aaa499b_e116c0a6","side":"PARENT","line":35,"updated":"2015-04-10 16:32:55.000000000","message":"Maybe I can use a descriptor for this: https://docs.python.org/2/howto/descriptor.html#descriptor-example\n\nthen we should be able to get the version at run-time.","commit_id":"045c9dab6dfd599de42a7a7ac4a677e1a793b67f"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"cd510ae3bcbe37511f95a6d61b0b3193dbf0d3a4","unresolved":false,"context_lines":[{"line_number":32,"context_line":"import pbr.version"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"__version__ \u003d pbr.version.VersionInfo(\u0027python-keystoneclient\u0027).version_string()"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"__all__ \u003d ["},{"line_number":38,"context_line":"    # Modules"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_8fe0c597","side":"PARENT","line":35,"updated":"2015-04-09 01:27:07.000000000","message":"even though it starts with an __ __version__ is a well defined field for most python modules. We can\u0027t just remove it. \n\nWe can move the pkg_resources call here though.","commit_id":"045c9dab6dfd599de42a7a7ac4a677e1a793b67f"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"dc0b848a06f469d31130d57a145ee3fec331866a","unresolved":false,"context_lines":[{"line_number":32,"context_line":"import pbr.version"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"__version__ \u003d pbr.version.VersionInfo(\u0027python-keystoneclient\u0027).version_string()"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"__all__ \u003d ["},{"line_number":38,"context_line":"    # Modules"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_897b1df5","side":"PARENT","line":35,"in_reply_to":"9aa53dc9_8fe0c597","updated":"2015-04-09 07:27:05.000000000","message":"Yeah. I also find the __version__ attribute very useful.","commit_id":"045c9dab6dfd599de42a7a7ac4a677e1a793b67f"}]}