)]}'
{"id":"openstack%2Fpython-keystoneclient~17413","triplet_id":"openstack%2Fpython-keystoneclient~master~Ifb0a18017d2407b3ccb2188b1a704c26997ba594","project":"openstack/python-keystoneclient","branch":"master","topic":"bug/1086125","hashtags":[],"change_id":"Ifb0a18017d2407b3ccb2188b1a704c26997ba594","subject":"Don\u0027t try to split a list of memcache servers","status":"MERGED","created":"2012-12-03 20:24:59.000000000","updated":"2012-12-06 18:39:51.000000000","submitted":"2012-12-06 18:39:51.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"895994a3162c3d0734c6252262a847ccb32be341","_number":17413,"virtual_id_number":17413,"owner":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":2,"date":"2012-12-06 18:39:51.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":0,"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"recommended":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"all":[{"value":1,"date":"2012-12-03 20:28:26.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2012-12-06 18:20:01.000000000","_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":1,"date":"2012-12-04 21:23:54.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"all":[{"value":0,"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2012-12-06 18:20:01.000000000","_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":0,"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-12-03 20:28:26.000000000","updated_by":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"reviewer":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"state":"REVIEWER"},{"updated":"2012-12-04 21:23:54.000000000","updated_by":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"reviewer":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"state":"REVIEWER"},{"updated":"2012-12-06 18:20:01.000000000","updated_by":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"reviewer":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"state":"REVIEWER"},{"updated":"2012-12-06 18:39:51.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"776f5989416e7aa9de1a9a7429dbd1642bf22ed6","author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"date":"2012-12-03 20:28:26.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"d51ff44f86d8db9f9018de600e7c872964645aed","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-03 20:43:29.000000000","message":"Patch Set 1: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/17413/1/check/gate-python-keystoneclient-merge/504 : SUCCESS\n- http://logs.openstack.org/17413/1/check/gate-python-keystoneclient-docs/354 : SUCCESS\n- http://logs.openstack.org/17413/1/check/gate-python-keystoneclient-pep8/498 : SUCCESS\n- http://logs.openstack.org/17413/1/check/gate-python-keystoneclient-python26/430 : SUCCESS\n- http://logs.openstack.org/17413/1/check/gate-python-keystoneclient-python27/432 : SUCCESS\n- http://logs.openstack.org/17413/1/check/gate-tempest-devstack-vm/20916 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"19e786f2937a08e3ed2c2d6857b03e97c250ac6e","author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"date":"2012-12-04 21:23:54.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nFine with me - unfortunately testing this would need to be done at the integration test level.","accounts_in_message":[],"_revision_number":1},{"id":"0cf23a8ea76ae62fa53765be693a73dfac389caa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-06 18:20:01.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttps://jenkins.openstack.org/zuul/status","accounts_in_message":[],"_revision_number":1},{"id":"1d603659a38df3226c108e85520fa42800afbe9c","author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"date":"2012-12-06 18:20:01.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\nLooks right to me, too.","accounts_in_message":[],"_revision_number":1},{"id":"28112675e5d2dea3f7599b5eaa3e30180f05ec0f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-06 18:39:51.000000000","message":"Patch Set 1: Verified\n\nBuild successful\n\n- http://logs.openstack.org/17413/1/gate/gate-python-keystoneclient-merge/508 : SUCCESS\n- http://logs.openstack.org/17413/1/gate/gate-python-keystoneclient-docs/358 : SUCCESS\n- http://logs.openstack.org/17413/1/gate/gate-python-keystoneclient-pep8/502 : SUCCESS\n- http://logs.openstack.org/17413/1/gate/gate-python-keystoneclient-python26/434 : SUCCESS\n- http://logs.openstack.org/17413/1/gate/gate-python-keystoneclient-python27/436 : SUCCESS\n- http://logs.openstack.org/17413/1/gate/gate-tempest-devstack-vm/21313 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"b48bbf6891a4f22bfea69414c1c97a2d6b7422ff","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-06 18:39:51.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6b72fb626af57a85d1b3411d0c7e8b3d8fdc33b2","revisions":{"6b72fb626af57a85d1b3411d0c7e8b3d8fdc33b2":{"kind":"REWORK","_number":1,"created":"2012-12-03 20:24:59.000000000","uploader":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"ref":"refs/changes/13/17413/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/13/17413/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/13/17413/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/13/17413/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/13/17413/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/13/17413/1"}}},"commit":{"parents":[{"commit":"94cbb616634f89fd35c2f9d62041d63e8d79bde3","subject":"Merge \"Add command to allow users to change their own password\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/94cbb616634f89fd35c2f9d62041d63e8d79bde3"}]}],"author":{"name":"Kevin L. Mitchell","email":"kevin.mitchell@rackspace.com","date":"2012-12-03 20:24:38.000000000","tz":-360},"committer":{"name":"Kevin L. Mitchell","email":"kevin.mitchell@rackspace.com","date":"2012-12-03 20:24:38.000000000","tz":-360},"subject":"Don\u0027t try to split a list of memcache servers","message":"Don\u0027t try to split a list of memcache servers\n\nThe memcache_servers configuration option is declared as a ListOpt,\nbut when used in AuthProtocol.__init__(), we treat it as a string\nto be split on \u0027,\u0027, which is wrong.  Remove the .split().\n\nNo test is added because the memcache package may not be installed,\nand I cannot see an easy method to only test this clause if it is\navailable.\n\nFixes bug 1086125.\n\nChange-Id: Ifb0a18017d2407b3ccb2188b1a704c26997ba594\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/6b72fb626af57a85d1b3411d0c7e8b3d8fdc33b2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/6b72fb626af57a85d1b3411d0c7e8b3d8fdc33b2"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}