)]}'
{"keystoneclient/service_catalog.py":[{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"0833cee46ddec6d312663ecd0324c04c6aeae00b","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            # NOTE(jamielennox): there is no such thing as a service_id in v2"},{"line_number":133,"context_line":"            # similarly to service_name we\u0027ll have to skip this check if it\u0027s"},{"line_number":134,"context_line":"            # not available."},{"line_number":135,"context_line":"            if service_id and service_id !\u003d service.get(\u0027id\u0027):"},{"line_number":136,"context_line":"                try:"},{"line_number":137,"context_line":"                    si \u003d service[\u0027id\u0027]"},{"line_number":138,"context_line":"                except KeyError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ad8896b_ce09a3df","line":135,"updated":"2015-05-11 16:22:44.000000000","message":"I don\u0027t understand the need for line 136-142. Why can\u0027t we just do\n\n  if service_id and service_id !\u003d service.get(\u0027id\u0027):\n      continue","commit_id":"c5148576284dc61937a3979a86a9c7d78406a588"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"2bb342c379efcb631787196dad60391aa1c180a3","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            # NOTE(jamielennox): there is no such thing as a service_id in v2"},{"line_number":133,"context_line":"            # similarly to service_name we\u0027ll have to skip this check if it\u0027s"},{"line_number":134,"context_line":"            # not available."},{"line_number":135,"context_line":"            if service_id and service_id !\u003d service.get(\u0027id\u0027):"},{"line_number":136,"context_line":"                try:"},{"line_number":137,"context_line":"                    si \u003d service[\u0027id\u0027]"},{"line_number":138,"context_line":"                except KeyError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da1255d7_89eb99b0","line":135,"in_reply_to":"7ad8896b_ce09a3df","updated":"2015-05-11 23:52:03.000000000","message":"In the v2 catalog there is no such thing as a service id so we have to skip this check and jump down to the endpoints check. \n\n(which i tried to communicate in the NOTE)\n\nI guess it\u0027s a choice we have to make, if you ask for a service_id from a v2 catalog should we just always fail?","commit_id":"c5148576284dc61937a3979a86a9c7d78406a588"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"9a18419de6fca028dc20071d496b7a5e40f40b83","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            # NOTE(jamielennox): there is no such thing as a service_id in v2"},{"line_number":133,"context_line":"            # similarly to service_name we\u0027ll have to skip this check if it\u0027s"},{"line_number":134,"context_line":"            # not available."},{"line_number":135,"context_line":"            if service_id and service_id !\u003d service.get(\u0027id\u0027):"},{"line_number":136,"context_line":"                try:"},{"line_number":137,"context_line":"                    si \u003d service[\u0027id\u0027]"},{"line_number":138,"context_line":"                except KeyError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_e969c38c","line":135,"in_reply_to":"9a0c5dc1_ea0447c7","updated":"2015-05-13 00:05:53.000000000","message":"oh - i think i see what you\u0027re saying - why did i do that and the KeyError check below. I don\u0027t remember. \n\nThe KeyError check makes this resemble the service_name check above, but the get check is the exactly the same and clearer. I guess i must have accidently done both.","commit_id":"c5148576284dc61937a3979a86a9c7d78406a588"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"904b52407bfaa14e5f3e02416d77cdf209dae6a5","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            # NOTE(jamielennox): there is no such thing as a service_id in v2"},{"line_number":133,"context_line":"            # similarly to service_name we\u0027ll have to skip this check if it\u0027s"},{"line_number":134,"context_line":"            # not available."},{"line_number":135,"context_line":"            if service_id and service_id !\u003d service.get(\u0027id\u0027):"},{"line_number":136,"context_line":"                try:"},{"line_number":137,"context_line":"                    si \u003d service[\u0027id\u0027]"},{"line_number":138,"context_line":"                except KeyError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_ea0447c7","line":135,"in_reply_to":"da1255d7_89eb99b0","updated":"2015-05-12 01:34:57.000000000","message":"how about this?\n\n  if service_id and \u0027id\u0027 in service and service_id !\u003d service[\u0027id\u0027]:\n      continue","commit_id":"c5148576284dc61937a3979a86a9c7d78406a588"}]}