)]}'
{"keystoneclient/client.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"1274d63168e78b0392129def00666160f20557df","unresolved":false,"context_lines":[{"line_number":9,"context_line":"\"\"\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"import copy"},{"line_number":12,"context_line":"import json"},{"line_number":13,"context_line":"import logging"},{"line_number":14,"context_line":"import sys"},{"line_number":15,"context_line":"import urlparse"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2F9jg%3D","line":12,"updated":"2012-12-18 20:56:50.000000000","message":"this is redundant with the try/excepted import below","commit_id":"671e656c41ea1a73b68ed5adc18ad04ff0df340c"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"77e78765085093d57ca86991756329b03f8e4985","unresolved":false,"context_lines":[{"line_number":9,"context_line":"\"\"\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"import copy"},{"line_number":12,"context_line":"import json"},{"line_number":13,"context_line":"import logging"},{"line_number":14,"context_line":"import sys"},{"line_number":15,"context_line":"import urlparse"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2F9ck%3D","line":12,"in_reply_to":"AAAAM3%2F%2F9jg%3D","updated":"2012-12-18 21:28:58.000000000","message":"doh!","commit_id":"671e656c41ea1a73b68ed5adc18ad04ff0df340c"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"1274d63168e78b0392129def00666160f20557df","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            if cacert:"},{"line_number":101,"context_line":"                self.verify_cert \u003d cacert"},{"line_number":102,"context_line":"            else:"},{"line_number":103,"context_line":"                self.verify_cert \u003d True"},{"line_number":104,"context_line":"        self.cert \u003d cert"},{"line_number":105,"context_line":"        if cert and key:"},{"line_number":106,"context_line":"            self.cert \u003d (cert, key,)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2F9jU%3D","line":103,"updated":"2012-12-18 20:56:50.000000000","message":"I\u0027m not clear on what the value of \u0027cacert\u0027 is/means versus verify_cert? If cacert is not a boolean, then the use of self.verify_cert is *really* confusing to me.\n\nWould also prefer at least removing the nested if block (e.g. \"if insecure / elif cacert / else\").","commit_id":"671e656c41ea1a73b68ed5adc18ad04ff0df340c"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"77e78765085093d57ca86991756329b03f8e4985","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            if cacert:"},{"line_number":101,"context_line":"                self.verify_cert \u003d cacert"},{"line_number":102,"context_line":"            else:"},{"line_number":103,"context_line":"                self.verify_cert \u003d True"},{"line_number":104,"context_line":"        self.cert \u003d cert"},{"line_number":105,"context_line":"        if cert and key:"},{"line_number":106,"context_line":"            self.cert \u003d (cert, key,)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2F9bw%3D","line":103,"in_reply_to":"AAAAM3%2F%2F9jU%3D","updated":"2012-12-18 21:28:58.000000000","message":"This structure reflects how requests handles its certificate verify variable.  Maybe it shouldn\u0027t and still be two variables?\n\nrequests(...,verify\u003dcacert,...) uses verify like so:\nFalse - do no verification\nTrue - do verification using the system\u0027s CA database\npath-to-ca-file - use the specified file to perform verification\n\nWe\u0027ll need that logic either in __init__() or in request().  I fell on the side of letting things specific to requests into other parts of HTTPClient.\n\nThat said I\u0027m not wed to the nesting except that it expressly shows that each combination of variables is handled and that insecure takes priority.","commit_id":"671e656c41ea1a73b68ed5adc18ad04ff0df340c"}]}