)]}'
{"id":"openstack%2Fpython-keystoneclient~176727","triplet_id":"openstack%2Fpython-keystoneclient~master~I9f208844eb854d503b9b103cd4ede589ce13877e","project":"openstack/python-keystoneclient","branch":"master","topic":"bp/refactor-federated-plugins","hashtags":[],"change_id":"I9f208844eb854d503b9b103cd4ede589ce13877e","subject":"Move federated auth plugins to separate repo.","status":"ABANDONED","created":"2015-04-23 12:50:13.000000000","updated":"2015-04-27 11:58:52.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ae67c1447ff8a0f553b3733f0bb35c528b760c3d","_number":176727,"virtual_id_number":176727,"owner":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2015-04-25 05:58:28.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},{"value":1,"date":"2015-04-24 08:18:44.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2015-04-26 23:50:58.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"all":[{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":-1,"date":"2015-04-24 14:56:04.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-04-24 08:18:44.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-04-25 05:58:28.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2015-04-26 23:50:58.000000000","updated_by":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"reviewer":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"state":"REVIEWER"}],"messages":[{"id":"e374f775ad3ffe059eb3bb6ad777699ac810761e","author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"date":"2015-04-23 12:50:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"dc266ab8b050a9d0aedeeda98aca05ab36c69769","author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"date":"2015-04-23 13:10:37.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"bec698461914a01505381da8251b1ff86403abd6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-23 14:09:02.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/27/176727/2/check/gate-python-keystoneclient-python26/9b9ef07/ : SUCCESS in 2m 03s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/27/176727/2/check/gate-python-keystoneclient-pep8/0977774/ : SUCCESS in 1m 50s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/27/176727/2/check/gate-python-keystoneclient-docs/700d2a4//doc/build/html/ : SUCCESS in 3m 06s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/27/176727/2/check/gate-python-keystoneclient-python27/5af9a7e/ : SUCCESS in 2m 02s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/27/176727/2/check/gate-python-keystoneclient-python34/845c136/ : SUCCESS in 3m 42s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/27/176727/2/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/9b79c4e/ : SUCCESS in 49m 46s\n- check-keystoneclient-dsvm-functional http://logs.openstack.org/27/176727/2/check/check-keystoneclient-dsvm-functional/69b99a7/ : SUCCESS in 17m 18s","accounts_in_message":[],"_revision_number":2},{"id":"eaab2c55f45f1f4d1fbe549af4f27fcd305a4ad4","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-04-24 02:32:14.000000000","message":"Patch Set 2: Code-Review-1\n\nthis is more than just refactoring, are you suggesting that we remove the code from ksc in favor of ksc-federation?\n\ni\u0027m OK with that, but we don\u0027t have a release of ksc-federation or ksc-saml yet. So we can\u0027t just drop the code","accounts_in_message":[],"_revision_number":2},{"id":"e4fa760f50f142a23fa73e898d91eec6badbeda9","author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"date":"2015-04-24 07:17:20.000000000","message":"Patch Set 2:\n\nOk, let me change the comming message.\n\nJamie can tell more about releases policy, but I am guessing we should somehow tie this with cut of new keystoneclient version.\n\nAlso, ksc-federation was renamed to ksc-saml2 now.","accounts_in_message":[],"_revision_number":2},{"id":"e57ae7a8d7a1f8224925d4b04db49a6ae750fb72","author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"date":"2015-04-24 07:18:02.000000000","message":"Patch Set 3: Commit message was updated","accounts_in_message":[],"_revision_number":3},{"id":"b9253fdbd69ada9cdb3ec2293ba179695b22e1d7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-24 08:18:44.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/27/176727/3/check/gate-python-keystoneclient-python26/602db41/ : SUCCESS in 2m 10s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/27/176727/3/check/gate-python-keystoneclient-pep8/333273f/ : SUCCESS in 2m 14s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/27/176727/3/check/gate-python-keystoneclient-docs/748abf5//doc/build/html/ : SUCCESS in 2m 05s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/27/176727/3/check/gate-python-keystoneclient-python27/102f5da/ : SUCCESS in 2m 14s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/27/176727/3/check/gate-python-keystoneclient-python34/654862a/ : SUCCESS in 3m 59s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/27/176727/3/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/4e25986/ : SUCCESS in 1h 00m 34s\n- check-keystoneclient-dsvm-functional http://logs.openstack.org/27/176727/3/check/check-keystoneclient-dsvm-functional/d2eb5ac/ : SUCCESS in 16m 44s","accounts_in_message":[],"_revision_number":3},{"id":"492f85dd8cc7d2b583c660fc55d19a4d49f969c4","author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"date":"2015-04-24 14:56:04.000000000","message":"Patch Set 3: Workflow-1","accounts_in_message":[],"_revision_number":3},{"id":"be5bd0579fdb1073353fe7857f7ce9c3666dc4db","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-04-25 05:58:28.000000000","message":"Patch Set 3:\n\nok cool - i agree with the overall change in architecture.\n\nksc should have the underpinnings for basic federation, while ksc-saml2 should maintain all the saml2 related stuff and the xml library requirements too.\n\nif we need a ksc-oidc, then it can follow the same pattern, or it can be placed in ksc and subclass federation.py.","accounts_in_message":[],"_revision_number":3},{"id":"50a47d1dc2a5f0158b41c8fc482ce4fd8682a383","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2015-04-26 23:50:58.000000000","message":"Patch Set 3: Code-Review-1\n\n(1 comment)\n\nI think most of this already exists in federated.py\n\nWe can\u0027t remove all that existing code unfortunately. We can just mark it all as deprecated and ignore it.","accounts_in_message":[],"_revision_number":3},{"id":"d8cb8e615a44b7740eec6fd7fba36a7e5e3713cf","author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"date":"2015-04-27 09:36:38.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"3ba45933fac077f154da5002cbbb81558dfeb07b","author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"date":"2015-04-27 11:58:52.000000000","message":"Abandoned\n\nAbandoning, as those plugins should stay and be deprecated.\nDeprecation patch will be in another patch, once the agreement of proper deprecation (either via debtcollector or  in-home solution) process is agreed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"4006756d8e97fd04b9e271d32d6fd85d5c53676e","revisions":{"ab8d0453951fd9527b78a42d809623c5d9942346":{"kind":"REWORK","_number":1,"created":"2015-04-23 12:50:13.000000000","uploader":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"ref":"refs/changes/27/176727/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/27/176727/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/27/176727/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/27/176727/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/27/176727/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/27/176727/1"}}},"commit":{"parents":[{"commit":"08fd4b1cd763fa7d529ce5d39e89bee8f619f70d","subject":"Merge \"Inherited role domain calls on keystoneclient v3\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/08fd4b1cd763fa7d529ce5d39e89bee8f619f70d"}]}],"author":{"name":"Marek Denis","email":"marek.denis@cern.ch","date":"2015-04-23 10:04:37.000000000","tz":120},"committer":{"name":"Marek Denis","email":"marek.denis@cern.ch","date":"2015-04-23 12:46:14.000000000","tz":120},"subject":"Refactor federation plugins.","message":"Refactor federation plugins.\n\nThis patch aims to prepare keystoneclient for use of repositories\nimplementing various federation auth plugins. That said, keystoneclient\nshould only implement a common interface for them.\n\nThis patch:\n\n*) Implements basic interface for subsequent federation auth plugins\n*) Removes implementation of existing SAML2 auth plugins\n\nChange-Id: I9f208844eb854d503b9b103cd4ede589ce13877e\nPartially-Implements: bp refactor-federated-plugins\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/ab8d0453951fd9527b78a42d809623c5d9942346"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/ab8d0453951fd9527b78a42d809623c5d9942346"}]},"branch":"refs/heads/master"},"98bc183a8e45ec0ba1910a013c417e8731639b79":{"kind":"REWORK","_number":2,"created":"2015-04-23 13:10:37.000000000","uploader":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"ref":"refs/changes/27/176727/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/27/176727/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/27/176727/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/27/176727/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/27/176727/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/27/176727/2"}}},"commit":{"parents":[{"commit":"08fd4b1cd763fa7d529ce5d39e89bee8f619f70d","subject":"Merge \"Inherited role domain calls on keystoneclient v3\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/08fd4b1cd763fa7d529ce5d39e89bee8f619f70d"}]}],"author":{"name":"Marek Denis","email":"marek.denis@cern.ch","date":"2015-04-23 10:04:37.000000000","tz":120},"committer":{"name":"Marek Denis","email":"marek.denis@cern.ch","date":"2015-04-23 13:06:57.000000000","tz":120},"subject":"Refactor federation plugins.","message":"Refactor federation plugins.\n\nThis patch aims to prepare keystoneclient for use of repositories\nimplementing various federation auth plugins. That said, keystoneclient\nshould only implement a common interface for them.\n\nThis patch:\n\n*) Implements basic interface for subsequent federation auth plugins\n*) Removes implementation of existing SAML2 auth plugins\n\nChange-Id: I9f208844eb854d503b9b103cd4ede589ce13877e\nPartially-Implements: bp refactor-federated-plugins\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/98bc183a8e45ec0ba1910a013c417e8731639b79"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/98bc183a8e45ec0ba1910a013c417e8731639b79"}]},"branch":"refs/heads/master"},"4006756d8e97fd04b9e271d32d6fd85d5c53676e":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2015-04-24 07:18:02.000000000","uploader":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"ref":"refs/changes/27/176727/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/27/176727/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/27/176727/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/27/176727/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/27/176727/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/27/176727/3"}}},"commit":{"parents":[{"commit":"08fd4b1cd763fa7d529ce5d39e89bee8f619f70d","subject":"Merge \"Inherited role domain calls on keystoneclient v3\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/08fd4b1cd763fa7d529ce5d39e89bee8f619f70d"}]}],"author":{"name":"Marek Denis","email":"marek.denis@cern.ch","date":"2015-04-23 10:04:37.000000000","tz":120},"committer":{"name":"Marek Denis","email":"marek.denis@cern.ch","date":"2015-04-24 07:18:02.000000000","tz":0},"subject":"Move federated auth plugins to separate repo.","message":"Move federated auth plugins to separate repo.\n\nThis patch aims to prepare keystoneclient for use of repositories\nimplementing various federation auth plugins. That said, keystoneclient\nshould only implement a common interface for them.\n\nWork items:\n\n*) Implements basic interface for subsequent federation auth plugins\n*) Removes implementation of existing SAML2 auth plugins\n\nChange-Id: I9f208844eb854d503b9b103cd4ede589ce13877e\nPartially-Implements: bp refactor-federated-plugins\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/4006756d8e97fd04b9e271d32d6fd85d5c53676e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/4006756d8e97fd04b9e271d32d6fd85d5c53676e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}