)]}'
{"id":"openstack%2Fpython-keystoneclient~179984","triplet_id":"openstack%2Fpython-keystoneclient~master~I07fb46f156fdf8267fd3d4dc7c587cd604838d73","project":"openstack/python-keystoneclient","branch":"master","topic":"bug/1451625","hashtags":[],"change_id":"I07fb46f156fdf8267fd3d4dc7c587cd604838d73","subject":"Ensure that failing responses are logged","status":"MERGED","created":"2015-05-05 01:02:49.000000000","updated":"2015-05-20 20:06:22.000000000","submitted":"2015-05-20 20:06:20.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"891b5ba3eb3d3e55389c462527d20d418c482e78","_number":179984,"virtual_id_number":179984,"owner":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},{"value":2,"date":"2015-05-20 20:06:20.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},{"value":0,"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},{"value":0,"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":0,"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},{"value":0,"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"all":[{"value":2,"date":"2015-05-20 19:12:39.000000000","_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-05-20 19:11:39.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},{"value":1,"date":"2015-05-20 19:13:28.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},{"value":2,"date":"2015-05-20 19:09:52.000000000","_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":1,"date":"2015-05-20 19:12:26.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},{"value":1,"date":"2015-05-20 19:10:33.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"all":[{"value":1,"date":"2015-05-20 19:12:39.000000000","_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},{"value":0,"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},{"value":0,"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":0,"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},{"value":0,"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-05-20 19:09:52.000000000","updated_by":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"reviewer":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"state":"REVIEWER"},{"updated":"2015-05-20 19:10:33.000000000","updated_by":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"reviewer":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"state":"REVIEWER"},{"updated":"2015-05-20 19:11:39.000000000","updated_by":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"reviewer":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"state":"REVIEWER"},{"updated":"2015-05-20 19:12:26.000000000","updated_by":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"reviewer":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"state":"REVIEWER"},{"updated":"2015-05-20 19:12:39.000000000","updated_by":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"reviewer":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"state":"REVIEWER"},{"updated":"2015-05-20 19:13:28.000000000","updated_by":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"reviewer":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"state":"REVIEWER"},{"updated":"2015-05-20 20:06:20.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"ccbad7a5f7db18006526847ef8265bbd72833c92","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2015-05-05 01:02:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7ff23f4d869432f94b61eef990771d4cacb8a2af","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-05 02:06:21.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/84/179984/1/check/gate-python-keystoneclient-python26/cd3d805/ : SUCCESS in 2m 44s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/84/179984/1/check/gate-python-keystoneclient-pep8/9be80ce/ : SUCCESS in 2m 29s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/84/179984/1/check/gate-python-keystoneclient-docs/8d013ea//doc/build/html/ : SUCCESS in 3m 27s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/84/179984/1/check/gate-python-keystoneclient-python27/ba23d55/ : SUCCESS in 2m 37s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/84/179984/1/check/gate-python-keystoneclient-python34/4bff740/ : SUCCESS in 5m 06s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/84/179984/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/354ff37/ : SUCCESS in 49m 32s\n- check-keystoneclient-dsvm-functional http://logs.openstack.org/84/179984/1/check/check-keystoneclient-dsvm-functional/39e4b44/ : SUCCESS in 21m 09s","accounts_in_message":[],"_revision_number":1},{"id":"e3cf7039fccf6e3753cd6a9af00695558e6b9901","author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"date":"2015-05-20 19:09:52.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"bd5cc27dd8d8662d13e67e2b81d3c997a6f73b8c","author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"date":"2015-05-20 19:10:33.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"03a568333f0ed1efa54500ed1d6e2a9bd203c5c9","author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"date":"2015-05-20 19:11:39.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"5224b8b086cce29f4b5ed5ee282f29ec445d2495","author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"date":"2015-05-20 19:12:26.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"e9f02b25b7284cb6250806d3fb77b5723605b325","author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"date":"2015-05-20 19:12:39.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"770f7da59f8be8da6f125d43689b43a4429ee374","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-20 19:12:45.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"9dfd5a535402d9d1b5b3f7e4b71dd984bcc1719f","author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"date":"2015-05-20 19:13:28.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7499a9377e98736c0a0b8a442297ac46d0730a4b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-20 20:06:20.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/84/179984/1/gate/gate-python-keystoneclient-python26/87eff96/ : SUCCESS in 2m 12s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/84/179984/1/gate/gate-python-keystoneclient-docs/667858c//doc/build/html/ : SUCCESS in 2m 59s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/84/179984/1/gate/gate-python-keystoneclient-pep8/2d75853/ : SUCCESS in 2m 23s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/84/179984/1/gate/gate-python-keystoneclient-python27/b7af18d/ : SUCCESS in 3m 53s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/84/179984/1/gate/gate-python-keystoneclient-python34/48e055b/ : SUCCESS in 2m 18s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/84/179984/1/gate/gate-tempest-dsvm-neutron-src-python-keystoneclient/fbe2989/ : SUCCESS in 53m 26s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/84/179984/1/gate/gate-keystoneclient-dsvm-functional/5154fa7/ : SUCCESS in 19m 29s","accounts_in_message":[],"_revision_number":1},{"id":"2cf6c14d152c6afcad64be28c77dfa48ebf03202","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-20 20:06:22.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"c7ec27a448d20201471a8f953e3b58b9ded589aa","revisions":{"c7ec27a448d20201471a8f953e3b58b9ded589aa":{"kind":"REWORK","_number":1,"created":"2015-05-05 01:02:49.000000000","uploader":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"ref":"refs/changes/84/179984/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/84/179984/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/84/179984/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/84/179984/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/84/179984/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/84/179984/1"}}},"commit":{"parents":[{"commit":"39b7f963f595ba3517c7e5540981bce356ec0e1b","subject":"Merge \"Add endpoint and service ids to fixtures\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/39b7f963f595ba3517c7e5540981bce356ec0e1b"}]}],"author":{"name":"Jamie Lennox","email":"jamielennox@redhat.com","date":"2015-05-05 00:59:40.000000000","tz":600},"committer":{"name":"Jamie Lennox","email":"jamielennox@redhat.com","date":"2015-05-05 01:02:35.000000000","tz":600},"subject":"Ensure that failing responses are logged","message":"Ensure that failing responses are logged\n\nThe boolean value of a failed response is False and so the way we\npopulate the log output does not work when the request failed.\n\nWhen logging check that a response is not None rather than simply\nchecking it\u0027s boolean value.\n\nChange-Id: I07fb46f156fdf8267fd3d4dc7c587cd604838d73\nCloses-Bug: #1451625\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/c7ec27a448d20201471a8f953e3b58b9ded589aa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/c7ec27a448d20201471a8f953e3b58b9ded589aa"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
