)]}'
{"id":"openstack%2Fpython-keystoneclient~189144","triplet_id":"openstack%2Fpython-keystoneclient~master~Id024296de80f753aeabd6f418d459096fdb89838","project":"openstack/python-keystoneclient","branch":"master","topic":"deprecations","hashtags":[],"change_id":"Id024296de80f753aeabd6f418d459096fdb89838","subject":"Common base class for unit tests","status":"ABANDONED","created":"2015-06-07 16:04:47.000000000","updated":"2015-06-09 01:12:25.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9bef8ccbe7784a54a734b2e887909499f022ae8e","_number":189144,"virtual_id_number":189144,"owner":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2015-06-07 23:58:41.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2015-06-07 22:59:57.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":-1,"date":"2015-06-08 14:21:19.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-06-07 23:58:41.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-06-08 14:21:19.000000000","updated_by":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"reviewer":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"state":"REVIEWER"}],"messages":[{"id":"c6a2b440585d3b6d57cd4aa33d874501b580dcd4","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-06-07 16:04:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"994b644f84601a0b43e8282785cf7b67115f5565","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-07 16:48:47.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/44/189144/1/check/gate-python-keystoneclient-python26/d6825b5/ : SUCCESS in 2m 18s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/44/189144/1/check/gate-python-keystoneclient-pep8/8744010/ : SUCCESS in 1m 52s\n- gate-python-keystoneclient-docs http://logs.openstack.org/44/189144/1/check/gate-python-keystoneclient-docs/b9a2bc3/ : FAILURE in 5m 11s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/44/189144/1/check/gate-python-keystoneclient-python27/c17b2e6/ : FAILURE in 5m 16s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/44/189144/1/check/gate-python-keystoneclient-python34/f9bb68c/ : FAILURE in 5m 16s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/44/189144/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/f97e4b7/ : SUCCESS in 43m 49s\n- check-keystoneclient-dsvm-functional http://logs.openstack.org/44/189144/1/check/check-keystoneclient-dsvm-functional/091acfe/ : SUCCESS in 15m 37s","accounts_in_message":[],"_revision_number":1},{"id":"362af28b94155cf9988ec6f43de81481f9b9aa4e","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-06-07 22:59:57.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"8e3535fd18eec8fc6d2d61347beca0bd883fa918","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-07 23:58:41.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/44/189144/1/check/gate-python-keystoneclient-python26/4f239f0/ : SUCCESS in 3m 15s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/44/189144/1/check/gate-python-keystoneclient-pep8/cd639c2/ : SUCCESS in 2m 55s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/44/189144/1/check/gate-python-keystoneclient-docs/18c5139//doc/build/html/ : SUCCESS in 2m 55s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/44/189144/1/check/gate-python-keystoneclient-python27/120e352/ : SUCCESS in 2m 53s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/44/189144/1/check/gate-python-keystoneclient-python34/c0afcc8/ : SUCCESS in 3m 20s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/44/189144/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/d44a28e/ : SUCCESS in 55m 01s\n- check-keystoneclient-dsvm-functional http://logs.openstack.org/44/189144/1/check/check-keystoneclient-dsvm-functional/3bc9fa9/ : SUCCESS in 20m 26s","accounts_in_message":[],"_revision_number":1},{"id":"675f1049500486fb0c643ed7cfb6f9dbecbaedde","author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"date":"2015-06-08 14:21:19.000000000","message":"Patch Set 1: Code-Review-1\n\nDo not this this is the right direction.  It introduces yet another class that is supposed to be the \"top of the tree\"  when just replaces the TestCase class beneath it as something to ignore if the behavior is not what you want.  \n\nI think this is a case where we should favor composition over inheritance;  if this is really  necessary for tagging a specific class as \"OK to use deprecated\" or other cross cuttin concernts, make it some thing that can be pulled into the test class at the top level without carrying on all of the other baggage.  \n\nIf you really cannot justify putting this behaviour in to keystoneclient....utils.TestCase, then it should be something we add to a class in either __init__ or setup methods.","accounts_in_message":[],"_revision_number":1},{"id":"8427b818b82ed6ab05641bb086c028c1a9c65497","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-06-09 01:12:25.000000000","message":"Abandoned\n\nWill use composition instead.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"95629cf75eff704f49e468ca6628385434fc5ce8","revisions":{"95629cf75eff704f49e468ca6628385434fc5ce8":{"kind":"REWORK","_number":1,"created":"2015-06-07 16:04:47.000000000","uploader":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"ref":"refs/changes/44/189144/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/44/189144/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/189144/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/189144/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/189144/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/189144/1"}}},"commit":{"parents":[{"commit":"7f407488cefd9668b31df6b4050209438675a95f","subject":"Merge \"Cleanup fixture imports\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/7f407488cefd9668b31df6b4050209438675a95f"}]}],"author":{"name":"Brant Knudson","email":"bknudson@us.ibm.com","date":"2015-06-07 16:01:39.000000000","tz":-300},"committer":{"name":"Brant Knudson","email":"bknudson@us.ibm.com","date":"2015-06-07 16:01:39.000000000","tz":-300},"subject":"Common base class for unit tests","message":"Common base class for unit tests\n\nA common base class is defined to provide a place to put fixtures\nthat affect all tests. For example, we could add a fixture that\nensures that no deprecated function was used.\n\nChange-Id: Id024296de80f753aeabd6f418d459096fdb89838\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/95629cf75eff704f49e468ca6628385434fc5ce8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/95629cf75eff704f49e468ca6628385434fc5ce8"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}