)]}'
{"keystoneclient/tests/unit/utils.py":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"f58fabcfb6cba55106205d93b1be2eb3c4cd926e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        self.addCleanup(self.mox.VerifyAll)"},{"line_number":48,"context_line":"        self.addCleanup(self.mox.UnsetStubs)"},{"line_number":49,"context_line":"        self.logger \u003d self.useFixture(fixtures.FakeLogger(level\u003dlogging.DEBUG))"},{"line_number":50,"context_line":"        self.time_patcher \u003d self.useFixture("},{"line_number":51,"context_line":"            mockpatch.PatchObject(time, \u0027time\u0027, lambda: 1234)).mock"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        self.requests_mock \u003d self.useFixture(fixture.Fixture())"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_4ea9a78f","line":50,"updated":"2015-06-09 09:43:37.000000000","message":"...I assume now that we do this via useFixture, the cleanup will happen automatically?","commit_id":"7cc35b45e9fad0d994d4f43cbd8d073ab24eb040"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"6734e6290d4119e983065b99d17ea4f27548e8d3","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        self.addCleanup(self.mox.VerifyAll)"},{"line_number":48,"context_line":"        self.addCleanup(self.mox.UnsetStubs)"},{"line_number":49,"context_line":"        self.logger \u003d self.useFixture(fixtures.FakeLogger(level\u003dlogging.DEBUG))"},{"line_number":50,"context_line":"        self.time_patcher \u003d self.useFixture("},{"line_number":51,"context_line":"            mockpatch.PatchObject(time, \u0027time\u0027, lambda: 1234)).mock"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        self.requests_mock \u003d self.useFixture(fixture.Fixture())"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_b2561c5a","line":50,"in_reply_to":"3afb71cf_4ea9a78f","updated":"2015-06-09 20:07:00.000000000","message":"yes, it calls both setUp and cleanUp for you","commit_id":"7cc35b45e9fad0d994d4f43cbd8d073ab24eb040"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"6734e6290d4119e983065b99d17ea4f27548e8d3","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        self._finders \u003d []"},{"line_number":168,"context_line":"        self._cleared_modules \u003d {}"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def _cleanup(self):"},{"line_number":171,"context_line":"        for finder in self._finders:"},{"line_number":172,"context_line":"            sys.meta_path.remove(finder)"},{"line_number":173,"context_line":"        sys.modules.update(self._cleared_modules)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_9201e03a","line":170,"updated":"2015-06-09 20:07:00.000000000","message":"this one doesn\u0027t look like any sort of improvement; tearDown is conventional, whereas I\u0027d be inclined to replace an arbitrary _cleanup method with a proper tearDown","commit_id":"7cc35b45e9fad0d994d4f43cbd8d073ab24eb040"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"a454a9c334354cc4d6411158818b2a79be7a76d5","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        self._finders \u003d []"},{"line_number":168,"context_line":"        self._cleared_modules \u003d {}"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def _cleanup(self):"},{"line_number":171,"context_line":"        for finder in self._finders:"},{"line_number":172,"context_line":"            sys.meta_path.remove(finder)"},{"line_number":173,"context_line":"        sys.modules.update(self._cleared_modules)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_c4b30f99","line":170,"in_reply_to":"3afb71cf_9201e03a","updated":"2015-06-10 00:19:39.000000000","message":"Done","commit_id":"7cc35b45e9fad0d994d4f43cbd8d073ab24eb040"}],"keystoneclient/tests/unit/v2_0/test_shell.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"6734e6290d4119e983065b99d17ea4f27548e8d3","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        super(ShellTests, self).setUp()"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        old_environment \u003d os.environ.copy()"},{"line_number":43,"context_line":"        self.addCleanup(setattr, os, \u0027environ\u0027, old_environment)"},{"line_number":44,"context_line":"        os.environ \u003d {"},{"line_number":45,"context_line":"            \u0027OS_USERNAME\u0027: DEFAULT_USERNAME,"},{"line_number":46,"context_line":"            \u0027OS_PASSWORD\u0027: DEFAULT_PASSWORD,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_123850ee","line":43,"updated":"2015-06-09 20:07:00.000000000","message":"no need for the indirection anymore -- just pass os.environ.copy() into addCleanup","commit_id":"7cc35b45e9fad0d994d4f43cbd8d073ab24eb040"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"a454a9c334354cc4d6411158818b2a79be7a76d5","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        super(ShellTests, self).setUp()"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        old_environment \u003d os.environ.copy()"},{"line_number":43,"context_line":"        self.addCleanup(setattr, os, \u0027environ\u0027, old_environment)"},{"line_number":44,"context_line":"        os.environ \u003d {"},{"line_number":45,"context_line":"            \u0027OS_USERNAME\u0027: DEFAULT_USERNAME,"},{"line_number":46,"context_line":"            \u0027OS_PASSWORD\u0027: DEFAULT_PASSWORD,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_04336715","line":43,"in_reply_to":"3afb71cf_123850ee","updated":"2015-06-10 00:19:39.000000000","message":"Done","commit_id":"7cc35b45e9fad0d994d4f43cbd8d073ab24eb040"}]}