)]}'
{"id":"openstack%2Fpython-keystoneclient~192752","triplet_id":"openstack%2Fpython-keystoneclient~master~Idd3b7d730b70ecf4fa6be911078d02e8bdfc9f37","project":"openstack/python-keystoneclient","branch":"master","topic":"bug/1449066","hashtags":[],"change_id":"Idd3b7d730b70ecf4fa6be911078d02e8bdfc9f37","subject":"Remove keystoneclient.middleware","status":"ABANDONED","created":"2015-06-17 16:15:13.000000000","updated":"2015-06-25 09:09:47.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0781677f6a91641fda04663dff0fd2fb0d801c00","_number":192752,"virtual_id_number":192752,"owner":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":-1,"date":"2015-06-24 22:39:58.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2015-06-17 16:16:57.000000000","_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"recommended":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},{"value":-2,"date":"2015-06-23 20:27:30.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":1,"date":"2015-06-19 09:32:24.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-06-19 09:32:24.000000000","updated_by":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"reviewer":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"state":"REVIEWER"},{"updated":"2015-06-23 20:27:30.000000000","updated_by":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"reviewer":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"state":"REVIEWER"},{"updated":"2015-06-24 22:39:58.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"e17c5f132f0faa41440c8e16f58888303df6c864","author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"date":"2015-06-17 16:15:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4d2497882aae8de778a1c2cb4de1a1a30142edc0","author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"date":"2015-06-17 16:16:57.000000000","message":"Patch Set 1:\n\nI already wrote this patch once and it was already merged: change I88ddfdb674db1ec9c0fd4f9a62ae8347785ea10c.\n\nMy change was reverted by the change I4b3749793e67b37c8a39f00a32e5d4e818fd04a1. I was asked to propose again the same change. I still don\u0027t understand why my change was reverted.","accounts_in_message":[],"_revision_number":1},{"id":"64a77dc3a8924077cc59a43f01c9367f8a1dafd6","author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"date":"2015-06-17 16:50:36.000000000","message":"Patch Set 1:\n\nIn a comment on the review of the revert, Brant Knudson wrote:\n\n\"We\u0027ll need to release another version of keystoneclient 1.x before we release a 2.0, and we want to pile up other removals and cleanups for the 2.0 release.\"\n\nI see that python-keystoneclient 1.6.0 was released at 2015-06-03. Is it the \"another 1.x version\"? Or do you plan another 1.x before 2.0?","accounts_in_message":[],"_revision_number":1},{"id":"30d78a677970e3817e13400965079551aacf9f93","author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"date":"2015-06-17 16:52:50.000000000","message":"Patch Set 1:\n\nMy commit e7853b8909358a78b8ae86c075ee234467a0d82f \"Remove unused fixtures\" (change I55a5e106b5d4d618918ee21b33afd0154e22f6b7) was already reverted: commit 7e4d4096122d50d4b50cecbf4095436670cafb9d (change I7b21bb139ccf7379d6f1b26f1ecddaa43767a334). It\u0027s a follow-up of the removal of the middleware code. I will repropose it once middleware is removed again.","accounts_in_message":[],"_revision_number":1},{"id":"443b7550315f3789a6706f39d64985888be742f9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-17 17:28:23.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/52/192752/1/check/gate-python-keystoneclient-python26/1359c93/ : SUCCESS in 2m 14s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/52/192752/1/check/gate-python-keystoneclient-pep8/44dbc56/ : SUCCESS in 2m 28s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/52/192752/1/check/gate-python-keystoneclient-docs/a7a116a//doc/build/html/ : SUCCESS in 2m 59s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/52/192752/1/check/gate-python-keystoneclient-python27/693079f/ : SUCCESS in 2m 57s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/52/192752/1/check/gate-python-keystoneclient-python34/35e0ef0/ : SUCCESS in 2m 36s\n- gate-python-keystoneclient-requirements http://logs.openstack.org/52/192752/1/check/gate-python-keystoneclient-requirements/ff87e36/ : SUCCESS in 22s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/52/192752/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/36a1bc8/ : SUCCESS in 1h 03m 06s\n- check-keystoneclient-dsvm-functional http://logs.openstack.org/52/192752/1/check/check-keystoneclient-dsvm-functional/289d5ac/ : SUCCESS in 19m 53s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/52/192752/1/check/gate-python-keystoneclient-tox-bandit/a815ebd/ : SUCCESS in 2m 39s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"229445da58ee16977cddecc5cba6b3a680b7bde5","author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"date":"2015-06-19 08:52:42.000000000","message":"Patch Set 1:\n\n\u003e My commit e7853b8909358a78b8ae86c075ee234467a0d82f \"Remove unused fixtures\" (change I55a5e106b5d4d618918ee21b33afd0154e22f6b7) was already reverted: commit 7e4d4096122d50d4b50cecbf4095436670cafb9d (change I7b21bb139ccf7379d6f1b26f1ecddaa43767a334). It\u0027s a follow-up of the removal of the middleware code. I will repropose it once middleware is removed again.\n\nOh wait, I just saw that this change was proposed and merged into openstack/keystoneauth:\n\nhttps://review.openstack.org/#/c/191635/\n\nHum, what is keystoneauth? Is it related to python-keystoneclient?","accounts_in_message":[],"_revision_number":1},{"id":"26b934098716854b74cae56619daeaa48515fec7","author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"date":"2015-06-19 09:32:24.000000000","message":"Patch Set 1: Code-Review+1\n\nI think the 1.6.0 version was the \"other version\". So this is probbaly OK.","accounts_in_message":[],"_revision_number":1},{"id":"2f2933214f76581f2c4b7ad946687759d4134ab0","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-06-19 11:58:50.000000000","message":"Patch Set 1:\n\nkeystoneauth contains some code extracted from keystoneclient and since it\u0027s a new library has no need for middleware.\n\nWe should probably create a feature branch for changes for v2 so that we can merge this safely.","accounts_in_message":[],"_revision_number":1},{"id":"fa42619f1edcc690e34b36428083fe0a9255d70a","author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"date":"2015-06-23 15:22:39.000000000","message":"Patch Set 1:\n\n\u003e We should probably create a feature branch for changes for v2 so that we can merge this safely.\n\nDoes it mean that the current master branch of python-keystoneclient is not the future 2.0 version? Do you mean a 1.7 release before 2.0?\n\nDo you know applications which still use the middleware module of keystoneclient? I may help them to move to keystonemiddleware.","accounts_in_message":[],"_revision_number":1},{"id":"16a635d686dff1d4f1483d3b42b7b8b749973e4a","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-06-23 20:27:30.000000000","message":"Patch Set 1: Code-Review-2\n\nPropose this change to the keystoneauth_integration branch. That\u0027s going to be 2.0.","accounts_in_message":[],"_revision_number":1},{"id":"a6c1f8c26876de8ea61cb4d5239ab9affb50def8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-24 22:39:58.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"b9f92a4f48f92228c11ae7a5d99217619fd79bb2","author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"date":"2015-06-25 09:09:47.000000000","message":"Abandoned\n\n\u003e Propose this change to the keystoneauth_integration branch. That\u0027s going to be 2.0.\n\nGreat! Morgan Fainberg did that for me :-) It\u0027s the change Idd3b7d730b70ecf4fa6be911078d02e8bdfc9f37.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"96207228af4da1fbeb9b68f369b059155c787aba","revisions":{"96207228af4da1fbeb9b68f369b059155c787aba":{"kind":"REWORK","_number":1,"created":"2015-06-17 16:15:13.000000000","uploader":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"ref":"refs/changes/52/192752/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/52/192752/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/52/192752/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/52/192752/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/52/192752/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/52/192752/1"}}},"commit":{"parents":[{"commit":"350b7951d07bc088836e1270eeb8284dcdf0b817","subject":"Stop using tearDown","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/350b7951d07bc088836e1270eeb8284dcdf0b817"}]}],"author":{"name":"Victor Stinner","email":"vstinner@redhat.com","date":"2015-04-27 08:37:01.000000000","tz":120},"committer":{"name":"Victor Stinner","email":"vstinner@redhat.com","date":"2015-06-17 16:15:10.000000000","tz":120},"subject":"Remove keystoneclient.middleware","message":"Remove keystoneclient.middleware\n\nThe code has been moved to the new keystonemiddleware project and\nkeystone.middleware was deprecated since Juno. It\u0027s time to drop it in\nLiberty.\n\nRemove the directory keystoneclient/middleware/.\n\nRemove test_auth_token_middleware.py, test_memcache_crypt.py and\ntest_s3_token_middleware.py in keystoneclient/tests/unit/.\n\nRemove the create_middleware_cert shell function from\nexamples/pki/gen_pki.sh. And remove the call from\nexamples/pki/run_all.sh.\n\nRemove netaddr, pycrypto and WebOb test dependencies, only needed to\ntest the removed middleware.\n\nDocImpact: The keystoneclient.middleware module has been removed\n\nChange-Id: Idd3b7d730b70ecf4fa6be911078d02e8bdfc9f37\nCloses-Bug: #1449066\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/96207228af4da1fbeb9b68f369b059155c787aba"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/96207228af4da1fbeb9b68f369b059155c787aba"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}