)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"change_message_id":"b82ba47c23e21b3f994a71af191da4733b25e012","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nachiappan VR N \u003cnachiappan.veerappan-nachiappan@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-01-09 16:20:26 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Bug_1028683:if delay_auth_decision is set,auth_token middleware"},{"line_number":8,"context_line":"does not log messages for valid token-less requests."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: Ia2069686b86cc833327b11343ebaed59663fd379"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAM3%2F%2FnJs%3D","line":7,"updated":"2013-01-13 21:50:15.000000000","message":"this should be something more like \"bug 1028683\" - don\u0027t use the underscore, or the systems in here can\u0027t link the review here to that bug when it gets merged","commit_id":"4084b8b3549c1568c526783d67a6176a788cfbaf"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"b1a5666edd1b804875e7773528fc17796b7d4e4b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nachiappan VR N \u003cnachiappan.veerappan-nachiappan@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-01-09 16:20:26 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Bug_1028683:if delay_auth_decision is set,auth_token middleware"},{"line_number":8,"context_line":"does not log messages for valid token-less requests."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: Ia2069686b86cc833327b11343ebaed59663fd379"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAM3%2F%2FmdI%3D","line":7,"in_reply_to":"AAAAM3%2F%2FnJs%3D","updated":"2013-01-14 15:42:47.000000000","message":"also, use a line break after a one line summary of 50 chars or less, e.g.:\n\n  Short summary of what you changed (bug ######)\n\n  Paragraph summary of why you changed it the way you did. This may be as long\n  as you like, but see the wiki[1] for details.\n\n  [1]: http://wiki.openstack.org/GitCommitMessages\n\n  Change-Id: I0123456789abcdef0123456789abcdef","commit_id":"4084b8b3549c1568c526783d67a6176a788cfbaf"}],"keystoneclient/middleware/auth_token.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"5cab9781a1cf47fed5729e15cc408a3c2263f89b","unresolved":false,"context_lines":[{"line_number":381,"context_line":"        else:"},{"line_number":382,"context_line":"            if not self.delay_auth_decision:"},{"line_number":383,"context_line":"                self.LOG.warn(\"Unable to find authentication token\""},{"line_number":384,"context_line":"                              \" in headers: %s\", env)"},{"line_number":385,"context_line":"            raise InvalidUserToken(\u0027Unable to find token in headers\u0027)"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    def _reject_request(self, env, start_response):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2For8%3D","line":384,"updated":"2013-01-11 19:34:57.000000000","message":"side note: Is it really necessary to log all the other headers here?","commit_id":"4084b8b3549c1568c526783d67a6176a788cfbaf"},{"author":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"change_message_id":"b82ba47c23e21b3f994a71af191da4733b25e012","unresolved":false,"context_lines":[{"line_number":381,"context_line":"        else:"},{"line_number":382,"context_line":"            if not self.delay_auth_decision:"},{"line_number":383,"context_line":"                self.LOG.warn(\"Unable to find authentication token\""},{"line_number":384,"context_line":"                              \" in headers: %s\", env)"},{"line_number":385,"context_line":"            raise InvalidUserToken(\u0027Unable to find token in headers\u0027)"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    def _reject_request(self, env, start_response):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FnJo%3D","line":384,"in_reply_to":"AAAAM3%2F%2Foes%3D","updated":"2013-01-13 21:50:15.000000000","message":"please, please. please move the header listing to self.LOG.debug() - not warn.","commit_id":"4084b8b3549c1568c526783d67a6176a788cfbaf"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"6b8ba93e25c19018fcd84ea20837c88468f2116b","unresolved":false,"context_lines":[{"line_number":381,"context_line":"        else:"},{"line_number":382,"context_line":"            if not self.delay_auth_decision:"},{"line_number":383,"context_line":"                self.LOG.warn(\"Unable to find authentication token\""},{"line_number":384,"context_line":"                              \" in headers: %s\", env)"},{"line_number":385,"context_line":"            raise InvalidUserToken(\u0027Unable to find token in headers\u0027)"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    def _reject_request(self, env, start_response):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Foes%3D","line":384,"in_reply_to":"AAAAM3%2F%2Fop0%3D","updated":"2013-01-11 21:10:54.000000000","message":"In that case, this should be:\n\n  self.LOG.warn(\"Unable to find authentication token in headers\")\n  self.LOG.debug(\"Headers: %s\" \u0026 env)","commit_id":"4084b8b3549c1568c526783d67a6176a788cfbaf"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"ee5a9326000d2f861a39e4f9a7e5fa28a7baac16","unresolved":false,"context_lines":[{"line_number":381,"context_line":"        else:"},{"line_number":382,"context_line":"            if not self.delay_auth_decision:"},{"line_number":383,"context_line":"                self.LOG.warn(\"Unable to find authentication token\""},{"line_number":384,"context_line":"                              \" in headers: %s\", env)"},{"line_number":385,"context_line":"            raise InvalidUserToken(\u0027Unable to find token in headers\u0027)"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    def _reject_request(self, env, start_response):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fop0%3D","line":384,"in_reply_to":"AAAAM3%2F%2For8%3D","updated":"2013-01-11 19:49:56.000000000","message":"I think it\u0027s beneficial to log the entire header, for debugging purposes. Say user is using curl and make a typo on \u0027X-Auth-Token\u0027 header, at least they know why they get a 401.","commit_id":"4084b8b3549c1568c526783d67a6176a788cfbaf"}],"tests/test_auth_token_middleware.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"5cab9781a1cf47fed5729e15cc408a3c2263f89b","unresolved":false,"context_lines":[{"line_number":622,"context_line":"        self.middleware.delay_auth_decision \u003d False"},{"line_number":623,"context_line":"        self.assertRaises(auth_token.InvalidUserToken,"},{"line_number":624,"context_line":"                          self.middleware._get_user_token_from_header, {})"},{"line_number":625,"context_line":"        self.assertFalse(self.middleware.LOG.msg is None)"},{"line_number":626,"context_line":""},{"line_number":627,"context_line":"    def test_request_blank_token(self):"},{"line_number":628,"context_line":"        req \u003d webob.Request.blank(\u0027/\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FosA%3D","line":625,"updated":"2013-01-11 19:34:57.000000000","message":"Would prefer:\n\n  self.assertIsNotNone(self.middleware.LOG.msg)","commit_id":"4084b8b3549c1568c526783d67a6176a788cfbaf"}]}