)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"f4aa515d04e5cd716a6a226db2a4ba144cf6c036","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"It would also help with the keystoneauth transition in auth_token as we"},{"line_number":15,"context_line":"could bypass the keystoneclient.AccessInfo objects."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ifbe7a7004937d910739c325cc04ae7264a4498e0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a41bdd9_08c9d9ab","line":16,"updated":"2015-07-15 20:17:51.000000000","message":"This needs a bug or a blueprint for tracking.","commit_id":"145bbb52cbcf1a1496583e7ce2b9bf1cbc325435"}],"keystoneclient/v3/tokens.py":[{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"d9291c5e8f9e10f190e56521909189f4a76f7e80","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        url \u003d \u0027/auth/tokens\u0027"},{"line_number":67,"context_line":"        if not include_catalog:"},{"line_number":68,"context_line":"            url +\u003d \u0027?nocatalog\u0027"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        resp, body \u003d self._client.get(url, headers\u003dheaders)"},{"line_number":71,"context_line":"        return body"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_50b418f1","line":68,"updated":"2015-06-29 18:05:49.000000000","message":"(nit) There is a standard library function: https://docs.python.org/2/library/urlparse.html#urlparse.urlunparse\n\nNow the code is simple though it already has URL with conditional parameter.\n\nIf you at least add a note here with the link it will be appreciated by those who will have to write something more complex here :)","commit_id":"145bbb52cbcf1a1496583e7ce2b9bf1cbc325435"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"69d5305b4c3c333f01b22c80198feadac427544a","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        url \u003d \u0027/auth/tokens\u0027"},{"line_number":67,"context_line":"        if not include_catalog:"},{"line_number":68,"context_line":"            url +\u003d \u0027?nocatalog\u0027"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        resp, body \u003d self._client.get(url, headers\u003dheaders)"},{"line_number":71,"context_line":"        return body"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_f8a6beac","line":68,"in_reply_to":"9a41bdd9_c2d5e4b9","updated":"2015-07-15 22:03:08.000000000","message":"Agreed. For this patch i want to rearrange and not change how things work. \n\nThe other problem with this from when it was first implemented is that using any of the urlparse functions will turn this into ?nocatalog\u003d1, which is fine, however ?nocatalog\u003d0 will still trigger no catalog because the API was looking for the presence of the nocatalog query and not the value of it. This is ridiculous, however that\u0027s how it works.","commit_id":"145bbb52cbcf1a1496583e7ce2b9bf1cbc325435"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"0b4059da70ab75f40be6428817c3ca2e0bb61346","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        url \u003d \u0027/auth/tokens\u0027"},{"line_number":67,"context_line":"        if not include_catalog:"},{"line_number":68,"context_line":"            url +\u003d \u0027?nocatalog\u0027"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        resp, body \u003d self._client.get(url, headers\u003dheaders)"},{"line_number":71,"context_line":"        return body"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_c2d5e4b9","line":68,"in_reply_to":"ba3cc151_50b418f1","updated":"2015-07-10 23:49:05.000000000","message":"we have this stuff all around, could also clean it up as separate patch","commit_id":"145bbb52cbcf1a1496583e7ce2b9bf1cbc325435"}]}