)]}'
{"id":"openstack%2Fpython-keystoneclient~20144","triplet_id":"openstack%2Fpython-keystoneclient~master~If0b4fed6fe676cad50512267c1b601a3a8a631e5","project":"openstack/python-keystoneclient","branch":"master","topic":"bug/cert_file_missing-buggy","hashtags":[],"change_id":"If0b4fed6fe676cad50512267c1b601a3a8a631e5","subject":"Fix thinko in self.middleware.cert_file_missing","status":"MERGED","created":"2013-01-21 16:17:52.000000000","updated":"2013-01-28 14:22:29.000000000","submitted":"2013-01-28 14:22:29.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0e8ac434369bf50db57f0f3c88cc4e4f6ecb6b3b","_number":20144,"virtual_id_number":20144,"owner":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"value":2,"date":"2013-01-28 14:22:29.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"recommended":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"all":[{"value":0,"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-01-23 13:58:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},{"value":2,"date":"2013-01-28 13:21:21.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":1,"date":"2013-01-23 20:43:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":2,"date":"2013-01-24 21:48:51.000000000","_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"all":[{"value":0,"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},{"value":1,"date":"2013-01-28 13:21:21.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"date":"2013-01-24 21:48:51.000000000","_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-01-23 13:58:52.000000000","updated_by":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"reviewer":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"state":"REVIEWER"},{"updated":"2013-01-23 20:43:55.000000000","updated_by":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"reviewer":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"state":"REVIEWER"},{"updated":"2013-01-24 21:48:51.000000000","updated_by":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"reviewer":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"state":"REVIEWER"},{"updated":"2013-01-28 13:21:21.000000000","updated_by":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"reviewer":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"state":"REVIEWER"},{"updated":"2013-01-28 14:22:29.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"8c2c7afddcb19975abc23f1899c9eca31ac5666c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-21 16:39:03.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see http://wiki.openstack.org/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/20144/1/check/gate-python-keystoneclient-docs/503 : FAILURE\n- http://logs.openstack.org/20144/1/check/gate-python-keystoneclient-pep8/647 : FAILURE\n- http://logs.openstack.org/20144/1/check/gate-python-keystoneclient-python26/578 : FAILURE\n- http://logs.openstack.org/20144/1/check/gate-python-keystoneclient-python27/581 : FAILURE\n- http://logs.openstack.org/20144/1/check/gate-tempest-devstack-vm/27569 : SUCCESS\n- http://logs.openstack.org/20144/1/check/gate-tempest-devstack-vm-quantum/1896 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"523d8fb5caea9212990e737a4332cdfd2ecb4f12","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2013-01-21 22:34:30.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(2 inline comments)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"b41122d3bd2d6c8f77b9cd6b7967c12a09fb0853","author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"date":"2013-01-22 08:41:50.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"03cc9232c7b873eb649f18f5a5fae77c1b5fe3dc","author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"date":"2013-01-22 09:08:19.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"0155b33449ea973ab6af8477d830a239e7b62351","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-22 09:42:07.000000000","message":"Patch Set 3: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see http://wiki.openstack.org/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/20144/3/check/gate-python-keystoneclient-docs/506 : SUCCESS\n- http://logs.openstack.org/20144/3/check/gate-python-keystoneclient-pep8/650 : FAILURE\n- http://logs.openstack.org/20144/3/check/gate-python-keystoneclient-python26/581 : SUCCESS\n- http://logs.openstack.org/20144/3/check/gate-python-keystoneclient-python27/584 : SUCCESS\n- http://logs.openstack.org/20144/3/check/gate-tempest-devstack-vm/27716 : SUCCESS\n- http://logs.openstack.org/20144/3/check/gate-tempest-devstack-vm-quantum/2074 : SUCCESS\n","accounts_in_message":[],"_revision_number":3},{"id":"fd0ec32df2b94151fa091b9a053a0885c8fbdaeb","author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"date":"2013-01-22 12:19:08.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"0fd4e019461b32b373e9643b3b5595b0dbc2ec9b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-22 12:52:00.000000000","message":"Patch Set 4: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/20144/4/check/gate-python-keystoneclient-docs/507 : SUCCESS\n- http://logs.openstack.org/20144/4/check/gate-python-keystoneclient-pep8/651 : SUCCESS\n- http://logs.openstack.org/20144/4/check/gate-python-keystoneclient-python26/582 : SUCCESS\n- http://logs.openstack.org/20144/4/check/gate-python-keystoneclient-python27/585 : SUCCESS\n- http://logs.openstack.org/20144/4/check/gate-tempest-devstack-vm/27732 : SUCCESS\n- http://logs.openstack.org/20144/4/check/gate-tempest-devstack-vm-quantum/2094 : SUCCESS\n","accounts_in_message":[],"_revision_number":4},{"id":"6450c85575f484cfa8ebe772dc1e56992bff708a","author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"date":"2013-01-22 13:17:14.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"3c70e7b4cc52fd9d149e42f8f325c3de83e657f8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-22 13:50:14.000000000","message":"Patch Set 5: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/20144/5/check/gate-python-keystoneclient-docs/508 : SUCCESS\n- http://logs.openstack.org/20144/5/check/gate-python-keystoneclient-pep8/652 : SUCCESS\n- http://logs.openstack.org/20144/5/check/gate-python-keystoneclient-python26/583 : SUCCESS\n- http://logs.openstack.org/20144/5/check/gate-python-keystoneclient-python27/586 : SUCCESS\n- http://logs.openstack.org/20144/5/check/gate-tempest-devstack-vm/27738 : SUCCESS\n- http://logs.openstack.org/20144/5/check/gate-tempest-devstack-vm-quantum/2103 : SUCCESS\n","accounts_in_message":[],"_revision_number":5},{"id":"a348fe86ffd80f79b7de24976626371a43568fdd","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2013-01-22 16:51:15.000000000","message":"Patch Set 5: Looks good to me, but someone else must approve\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":5},{"id":"ce26007e51622fb39762cd224f11bd639934918d","author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"date":"2013-01-23 08:57:48.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"1e29e083138e7c48626079f118b18eb3b8098c74","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-23 09:29:52.000000000","message":"Patch Set 6: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/20144/6/check/gate-python-keystoneclient-docs/515 : SUCCESS\n- http://logs.openstack.org/20144/6/check/gate-python-keystoneclient-pep8/659 : SUCCESS\n- http://logs.openstack.org/20144/6/check/gate-python-keystoneclient-python26/590 : SUCCESS\n- http://logs.openstack.org/20144/6/check/gate-python-keystoneclient-python27/593 : SUCCESS\n- http://logs.openstack.org/20144/6/check/gate-tempest-devstack-vm/27922 : SUCCESS\n- http://logs.openstack.org/20144/6/check/gate-tempest-devstack-vm-quantum/2328 : SUCCESS\n","accounts_in_message":[],"_revision_number":6},{"id":"350654ed81343dcaa6c16612fa40a58cf7fc57ab","author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"date":"2013-01-23 13:58:52.000000000","message":"Patch Set 6: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":6},{"id":"8be0b56e11964020af730d5be63695062ecc5f94","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2013-01-23 20:43:55.000000000","message":"Patch Set 6: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":6},{"id":"eaf6c47ad6c57eb37b3bf13ebc97a1c602256391","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2013-01-23 22:10:40.000000000","message":"Patch Set 6: Looks good to me, but someone else must approve\n\nnow that i understand what\u0027s going on here -- why aren\u0027t we checking to see if the file exists *before* calling cms verify and failing?\n\nthe fix is definitely an improvement, but i don\u0027t understand the original logic","accounts_in_message":[],"_revision_number":6},{"id":"9154eb84dae008e53576a3d67b97eff371a00a72","author":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"date":"2013-01-24 21:48:51.000000000","message":"Patch Set 6: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":6},{"id":"77172a912aea85fd1a64a328770e3a756116ba7d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-28 13:21:21.000000000","message":"Patch Set 6: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":6},{"id":"2c87d2ffa7b1a2a3d95f77eafb71c1fd5b33bf3c","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2013-01-28 13:21:21.000000000","message":"Patch Set 6: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":6},{"id":"fff9cfdc770c43f851c3f9a2d9c89d59a86d9e8e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-28 14:22:29.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":6},{"id":"1e34d5d718eda776ab7988c2285a9be80aac4edd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-28 14:22:29.000000000","message":"Patch Set 6: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/20144/6/gate/gate-python-keystoneclient-docs/549 : SUCCESS\n- http://logs.openstack.org/20144/6/gate/gate-python-keystoneclient-pep8/693 : SUCCESS\n- http://logs.openstack.org/20144/6/gate/gate-python-keystoneclient-python26/624 : SUCCESS\n- http://logs.openstack.org/20144/6/gate/gate-python-keystoneclient-python27/627 : SUCCESS\n- http://logs.openstack.org/20144/6/gate/gate-tempest-devstack-vm/28466 : SUCCESS\n- http://logs.openstack.org/20144/6/gate/gate-tempest-devstack-vm-quantum/3019 : SUCCESS\n","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"e676ab9f06d8a1b318863a38f4e59ef84e1bfbb2","revisions":{"e7286e6b4d5dcc07d08ce1ea0844e784e7589d15":{"kind":"REWORK","_number":1,"created":"2013-01-21 16:17:52.000000000","uploader":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"ref":"refs/changes/44/20144/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/44/20144/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/20144/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/20144/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/20144/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/20144/1"}}},"commit":{"parents":[{"commit":"3dfb8437fc9135465f2b66b2c420bf20899fcf10","subject":"Blueprint memcache-protection: enable memcache value encryption/integrity check","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/3dfb8437fc9135465f2b66b2c420bf20899fcf10"}]}],"author":{"name":"Dirk Mueller","email":"dirk@dmllr.de","date":"2013-01-21 16:15:28.000000000","tz":60},"committer":{"name":"Dirk Mueller","email":"dirk@dmllr.de","date":"2013-01-21 16:17:38.000000000","tz":60},"subject":"Fix thinko in self.middleware.cert_file_missing","message":"Fix thinko in self.middleware.cert_file_missing\n\nThe function always found the needle in the haystack\nbecause it did not check for find() returning something\nunequal to -1.\n\nAlso added a rather trivial test.\n\nChange-Id: If0b4fed6fe676cad50512267c1b601a3a8a631e5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/e7286e6b4d5dcc07d08ce1ea0844e784e7589d15"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/e7286e6b4d5dcc07d08ce1ea0844e784e7589d15"}]},"branch":"refs/heads/master"},"9dc16fdf366a0d8191cbe18f41a07be6e046fc33":{"kind":"REWORK","_number":2,"created":"2013-01-22 08:41:50.000000000","uploader":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"ref":"refs/changes/44/20144/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/44/20144/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/20144/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/20144/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/20144/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/20144/2"}}},"commit":{"parents":[{"commit":"3dfb8437fc9135465f2b66b2c420bf20899fcf10","subject":"Blueprint memcache-protection: enable memcache value encryption/integrity check","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/3dfb8437fc9135465f2b66b2c420bf20899fcf10"}]}],"author":{"name":"Dirk Mueller","email":"dirk@dmllr.de","date":"2013-01-21 16:15:28.000000000","tz":60},"committer":{"name":"Dirk Mueller","email":"dirk@dmllr.de","date":"2013-01-22 08:41:39.000000000","tz":60},"subject":"Fix thinko in self.middleware.cert_file_missing","message":"Fix thinko in self.middleware.cert_file_missing\n\nThe python function string.find() returns -1 on a miss,\nwhich is also evaluated as True. Therefore checking for\na return value \u003e\u003d 0 instead.\n\nAlso added a rather trivial test to test for this\ncode bug.\n\nChange-Id: If0b4fed6fe676cad50512267c1b601a3a8a631e5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/9dc16fdf366a0d8191cbe18f41a07be6e046fc33"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/9dc16fdf366a0d8191cbe18f41a07be6e046fc33"}]},"branch":"refs/heads/master"},"032b2ae1597006ff7639a358ee0e86f429056541":{"kind":"REWORK","_number":3,"created":"2013-01-22 09:08:19.000000000","uploader":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"ref":"refs/changes/44/20144/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/44/20144/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/20144/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/20144/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/20144/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/20144/3"}}},"commit":{"parents":[{"commit":"3dfb8437fc9135465f2b66b2c420bf20899fcf10","subject":"Blueprint memcache-protection: enable memcache value encryption/integrity check","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/3dfb8437fc9135465f2b66b2c420bf20899fcf10"}]}],"author":{"name":"Dirk Mueller","email":"dirk@dmllr.de","date":"2013-01-21 16:15:28.000000000","tz":60},"committer":{"name":"Dirk Mueller","email":"dirk@dmllr.de","date":"2013-01-22 09:04:08.000000000","tz":60},"subject":"Fix thinko in self.middleware.cert_file_missing","message":"Fix thinko in self.middleware.cert_file_missing\n\nThe python function string.find() returns -1 on a miss,\nwhich is also evaluated as True. Therefore checking for\na return value \u003e\u003d 0 instead.\n\nAlso added a rather trivial test to test for this\ncode bug. In order to make the code easier to test,\nI\u0027ve changed the parameters to operate on the command\noutput, not the exception object and updated all callers.\n\nChange-Id: If0b4fed6fe676cad50512267c1b601a3a8a631e5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/032b2ae1597006ff7639a358ee0e86f429056541"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/032b2ae1597006ff7639a358ee0e86f429056541"}]},"branch":"refs/heads/master"},"1f77f6ba951831cf462889689d5ef706aecbc930":{"kind":"REWORK","_number":4,"created":"2013-01-22 12:19:08.000000000","uploader":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"ref":"refs/changes/44/20144/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/44/20144/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/20144/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/20144/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/20144/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/20144/4"}}},"commit":{"parents":[{"commit":"3dfb8437fc9135465f2b66b2c420bf20899fcf10","subject":"Blueprint memcache-protection: enable memcache value encryption/integrity check","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/3dfb8437fc9135465f2b66b2c420bf20899fcf10"}]}],"author":{"name":"Dirk Mueller","email":"dirk@dmllr.de","date":"2013-01-21 16:15:28.000000000","tz":60},"committer":{"name":"Dirk Mueller","email":"dirk@dmllr.de","date":"2013-01-22 12:18:08.000000000","tz":60},"subject":"Fix thinko in self.middleware.cert_file_missing","message":"Fix thinko in self.middleware.cert_file_missing\n\nThe python function string.find() returns -1 on a miss,\nwhich is also evaluated as True. Therefore checking for\na return value \u003e\u003d 0 instead.\n\nAlso added a rather trivial test to test for this\ncode bug. In order to make the code easier to test,\nI\u0027ve changed the parameters to operate on the command\noutput, not the exception object and updated all callers.\n\nChange-Id: If0b4fed6fe676cad50512267c1b601a3a8a631e5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/1f77f6ba951831cf462889689d5ef706aecbc930"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/1f77f6ba951831cf462889689d5ef706aecbc930"}]},"branch":"refs/heads/master"},"875e2dfcc85ff82ad833bd1e74fe552005189673":{"kind":"REWORK","_number":5,"created":"2013-01-22 13:17:14.000000000","uploader":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"ref":"refs/changes/44/20144/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/44/20144/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/20144/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/20144/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/20144/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/20144/5"}}},"commit":{"parents":[{"commit":"3dfb8437fc9135465f2b66b2c420bf20899fcf10","subject":"Blueprint memcache-protection: enable memcache value encryption/integrity check","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/3dfb8437fc9135465f2b66b2c420bf20899fcf10"}]}],"author":{"name":"Dirk Mueller","email":"dirk@dmllr.de","date":"2013-01-21 16:15:28.000000000","tz":60},"committer":{"name":"Dirk Mueller","email":"dirk@dmllr.de","date":"2013-01-22 13:16:40.000000000","tz":60},"subject":"Fix thinko in self.middleware.cert_file_missing","message":"Fix thinko in self.middleware.cert_file_missing\n\nThe python function string.find() returns -1 on a miss,\nwhich is also evaluated as True. Therefore use the\n\"X in Y\" approach instead.\n\nAlso added a rather trivial test to test for this\ncode bug. In order to make the code easier to test,\nI\u0027ve changed the parameters to operate on the command\noutput, not the exception object and updated all callers.\n\nChange-Id: If0b4fed6fe676cad50512267c1b601a3a8a631e5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/875e2dfcc85ff82ad833bd1e74fe552005189673"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/875e2dfcc85ff82ad833bd1e74fe552005189673"}]},"branch":"refs/heads/master"},"e676ab9f06d8a1b318863a38f4e59ef84e1bfbb2":{"kind":"REWORK","_number":6,"created":"2013-01-23 08:57:48.000000000","uploader":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"ref":"refs/changes/44/20144/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/44/20144/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/20144/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/20144/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/20144/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/44/20144/6"}}},"commit":{"parents":[{"commit":"3dfb8437fc9135465f2b66b2c420bf20899fcf10","subject":"Blueprint memcache-protection: enable memcache value encryption/integrity check","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/3dfb8437fc9135465f2b66b2c420bf20899fcf10"}]}],"author":{"name":"Dirk Mueller","email":"dirk@dmllr.de","date":"2013-01-21 16:15:28.000000000","tz":60},"committer":{"name":"Dirk Mueller","email":"dirk@dmllr.de","date":"2013-01-23 08:55:33.000000000","tz":60},"subject":"Fix thinko in self.middleware.cert_file_missing","message":"Fix thinko in self.middleware.cert_file_missing\n\nThe python function string.find() returns -1 on a miss,\nwhich is also evaluated as True. Therefore use the\n\"X in Y\" approach instead.\n\nAlso added a rather trivial test to test for this\ncode bug. In order to make the code easier to test,\nI\u0027ve changed the parameters to operate on the command\noutput, not the exception object and updated all callers.\n\nChange-Id: If0b4fed6fe676cad50512267c1b601a3a8a631e5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/e676ab9f06d8a1b318863a38f4e59ef84e1bfbb2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/e676ab9f06d8a1b318863a38f4e59ef84e1bfbb2"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}