)]}'
{"id":"openstack%2Fpython-keystoneclient~20231","triplet_id":"openstack%2Fpython-keystoneclient~master~I769be118ee137580cabd5cabcf7843e7afe1e456","project":"openstack/python-keystoneclient","branch":"master","topic":"jd/simplify-token-retrieval","hashtags":[],"change_id":"I769be118ee137580cabd5cabcf7843e7afe1e456","subject":"Use TokenManager to get token","status":"MERGED","created":"2013-01-22 14:26:57.000000000","updated":"2013-04-30 17:34:14.000000000","submitted":"2013-04-26 16:20:16.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0fa7cac051d83a05f6e4f26ecd2bc404b19d0e31","_number":20231,"virtual_id_number":20231,"owner":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":2,"date":"2013-04-26 16:20:16.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":595,"name":"Nick Barcet","email":"nicolas@barcet.com","username":"nijaba"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":0,"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},{"value":0,"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":0,"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"all":[{"value":0,"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":595,"name":"Nick Barcet","email":"nicolas@barcet.com","username":"nijaba"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":2,"date":"2013-04-26 03:52:07.000000000","_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},{"value":0,"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":2,"date":"2013-04-26 15:36:02.000000000","_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"all":[{"value":0,"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":595,"name":"Nick Barcet","email":"nicolas@barcet.com","username":"nijaba"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":0,"date":"2013-04-26 03:52:07.000000000","_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},{"value":0,"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":1,"date":"2013-04-26 15:36:02.000000000","_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},{"_account_id":595,"name":"Nick Barcet","email":"nicolas@barcet.com","username":"nijaba"},{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-01-22 16:35:17.000000000","updated_by":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"reviewer":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"state":"REVIEWER"},{"updated":"2013-01-22 17:08:44.000000000","updated_by":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"reviewer":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"state":"REVIEWER"},{"updated":"2013-02-13 21:32:19.000000000","updated_by":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"reviewer":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"state":"REVIEWER"},{"updated":"2013-02-13 21:32:21.000000000","updated_by":{"_account_id":595,"name":"Nick Barcet","email":"nicolas@barcet.com","username":"nijaba"},"reviewer":{"_account_id":595,"name":"Nick Barcet","email":"nicolas@barcet.com","username":"nijaba"},"state":"REVIEWER"},{"updated":"2013-04-26 03:52:07.000000000","updated_by":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"reviewer":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"state":"REVIEWER"},{"updated":"2013-04-26 15:36:02.000000000","updated_by":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"reviewer":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"state":"REVIEWER"},{"updated":"2013-04-26 16:20:16.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"b7b733739c2ea6518b899fe1b4a9596c99ffc2de","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-22 15:00:01.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/20231/1/check/gate-python-keystoneclient-docs/509 : SUCCESS\n- http://logs.openstack.org/20231/1/check/gate-python-keystoneclient-pep8/653 : SUCCESS\n- http://logs.openstack.org/20231/1/check/gate-python-keystoneclient-python26/584 : SUCCESS\n- http://logs.openstack.org/20231/1/check/gate-python-keystoneclient-python27/587 : SUCCESS\n- http://logs.openstack.org/20231/1/check/gate-tempest-devstack-vm/27743 : SUCCESS\n- http://logs.openstack.org/20231/1/check/gate-tempest-devstack-vm-quantum/2110 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"e50396d96485458fe7ce1d16f06db184ae2f14d6","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2013-01-22 16:46:45.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"47605c47c05331f60cb9185944c08fb5ce163fb1","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2013-01-22 17:08:44.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\nverified that this works with keystone tests \u0026 for real use cases on the CLI","accounts_in_message":[],"_revision_number":1},{"id":"7d4c587cbdc581aa751606a77ad6f8424934d5ce","author":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"date":"2013-01-24 21:39:11.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nHey Julien,\n\nI moved this out of TokenManager for a specific purpose related to caching and using the cached token. I haven\u0027t read this in depth to verify that those mechanisms are still working and have relevant tests - that may not be relevant any more. \n\nThe core issue was around dealing with a lack of auth_url when using a cached token token reference or one from the commandline, and the crazy shit that the two URLs had together.","accounts_in_message":[],"_revision_number":1},{"id":"433d3f2ef40f86269955ce79d78fadfbe1424faa","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2013-01-30 13:55:04.000000000","message":"Patch Set 1:\n\nHey Joe,\n\nGot it. I just checked, and I don\u0027t see a case where that change would fail. The auth_url is retrieve from the cached token anyway, and the auth_url used is always the one from the Client, so I don\u0027t see a case where it could be wrong.\n\nIf such a case exist, it\u0027d be nice to have a unit test about it.","accounts_in_message":[],"_revision_number":1},{"id":"00bd46fed4a8ef3f914e1c3dbbdd83c0e48da6e9","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-02-07 06:03:03.000000000","message":"Patch Set 1:\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":1},{"id":"06eae22855772759a27367e2ed8e5326ec708539","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-02-07 06:03:03.000000000","message":"Patch Set 1: Abandoned\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":1},{"id":"7197a3e7e70e74d3811d024c59e7f0bc49ef08ae","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2013-02-07 09:07:03.000000000","message":"Patch Set 1: Restored","accounts_in_message":[],"_revision_number":1},{"id":"c958663c2b88613c5c6f46f18be1bb99ed85fa6c","author":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"date":"2013-02-08 18:21:43.000000000","message":"Patch Set 1:\n\nsorry for the delay in responding Julian\n\nI think the issue is in trying to support keystone activity through the client when using the --os-token and --os-endpoint together. In those cases, there isn\u0027t a self.auth_url, and all of the calls through the TokenManage *require* there to be one to pull the relevant data through the REST interfaces.\n\nsomewhere (that I\u0027m not spotting) did some creative swapping of mgmt_url and auth_url for underlying code in _cs_request() or the like, and it shat all over itself previously. \n\nThere it is - in TokenManager authenticate() un keystoneclient/v2_0/tokens.py\n\nMaybe I\u0027m misremembering how this all plugged together, but that\u0027s why I was wanting to steer clear - you can\u0027t pass in the os-token from the commandline into that kit","accounts_in_message":[],"_revision_number":1},{"id":"a12a0921da993dfce9bd47e3b7d2249527001cdd","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2013-02-11 10:18:11.000000000","message":"Patch Set 1:\n\nI\u0027m not sure I follow you entirely. I think the best way to do is to write a unit test that pass with master and fails with this patch -- I\u0027ll understand what this patch break and will be able to fix it. :)","accounts_in_message":[],"_revision_number":1},{"id":"f2a6cd2caee9c1daf773e4dc11f23a1e91713ce8","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2013-02-11 15:58:57.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"d598d4d9ee59dcf138255ed811ca77f4ce8a56f4","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-02-19 06:03:03.000000000","message":"Patch Set 1: Abandoned\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":1},{"id":"d2b84a1d68df0ca6eb44a6b0cf537fcac60a081b","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-02-19 06:03:03.000000000","message":"Patch Set 1:\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":1},{"id":"d5fbbd73cbdde2e2a652c9bdf911aab8800b7dc8","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2013-02-19 09:51:05.000000000","message":"Patch Set 1: Restored","accounts_in_message":[],"_revision_number":1},{"id":"4de36d8df0d4b371102cf4fa40c3f801144a3d0e","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2013-02-26 19:04:23.000000000","message":"Patch Set 1:\n\nJoe, could you take a look at this again?","accounts_in_message":[],"_revision_number":1},{"id":"950e75a5122d2a8dc729b123a8f6e898863a4089","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2013-03-04 17:12:55.000000000","message":"Patch Set 1:\n\n*keepalive*","accounts_in_message":[],"_revision_number":1},{"id":"4a4f3d50b42cf2c1d9d3dfbd2d68d4d7e519ef6b","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-03-12 06:03:04.000000000","message":"Patch Set 1:\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":1},{"id":"92a57fc5c34e90ef048774da08b88b5ad636682a","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-03-12 06:03:04.000000000","message":"Patch Set 1: Abandoned\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":1},{"id":"02fea0568aa8bad4a006ca42b47305d65ee82e2b","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2013-03-19 09:57:39.000000000","message":"Patch Set 1: Restored","accounts_in_message":[],"_revision_number":1},{"id":"407a40185d3c318cf72fca64a06dcb4d6f1e24b5","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2013-03-19 10:33:52.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"36276e41194d82317917fb65ce2e03c1637056e8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-19 10:40:42.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/20231/2/check/gate-python-keystoneclient-pep8/924 : SUCCESS\n- http://logs.openstack.org/20231/2/check/gate-python-keystoneclient-docs/774 : SUCCESS\n- http://logs.openstack.org/20231/2/check/gate-python-keystoneclient-python26/847 : SUCCESS\n- http://logs.openstack.org/20231/2/check/gate-python-keystoneclient-python27/852 : SUCCESS\n- http://logs.openstack.org/20231/2/check/gate-tempest-devstack-vm-full/9496 : FAILURE\n- http://logs.openstack.org/20231/2/check/gate-tempest-devstack-vm-postgres-full/9211 : FAILURE\n- http://logs.openstack.org/20231/2/check/gate-tempest-devstack-vm-quantum/14886 : FAILURE\n","accounts_in_message":[],"_revision_number":2},{"id":"6b25cf31083c03ffd5a41dd2c4fcf54b3c206a5f","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2013-03-19 10:51:30.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"ffdb1403f7b6e4652f036070ff19c28671b7757a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-19 11:28:02.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/20231/3/check/gate-python-keystoneclient-pep8/926 : SUCCESS\n- http://logs.openstack.org/20231/3/check/gate-python-keystoneclient-docs/776 : SUCCESS\n- http://logs.openstack.org/20231/3/check/gate-python-keystoneclient-python26/849 : SUCCESS\n- http://logs.openstack.org/20231/3/check/gate-python-keystoneclient-python27/854 : SUCCESS\n- http://logs.openstack.org/20231/3/check/gate-tempest-devstack-vm-full/9498 : SUCCESS\n- http://logs.openstack.org/20231/3/check/gate-tempest-devstack-vm-postgres-full/9213 : SUCCESS\n- http://logs.openstack.org/20231/3/check/gate-tempest-devstack-vm-quantum/14888 : SUCCESS\n","accounts_in_message":[],"_revision_number":3},{"id":"6037ee4ba0919e19d439c6358edfda0539292a02","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-04-03 06:03:02.000000000","message":"Patch Set 3:\n\ncode review expired after 2 weeks of no activity, it can be restored using the `Restore Change` button  under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":3},{"id":"c3f7532c0b4ad65724953e3ed401fc5915b41b89","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-04-03 06:03:02.000000000","message":"Patch Set 3: Abandoned\n\ncode review expired after 2 weeks of no activity, it can be restored using the `Restore Change` button  under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":3},{"id":"e50cbb5bdf6c227a906ba1dfb551f83bc9e665c8","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2013-04-03 08:33:34.000000000","message":"Patch Set 3: Restored","accounts_in_message":[],"_revision_number":3},{"id":"fa8c57b466074ddfc5a76f9537c3abfa693e8ac8","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-04-18 06:03:04.000000000","message":"Patch Set 3:\n\ncode review expired after 2 weeks of no activity, it can be restored using the `Restore Change` button  under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":3},{"id":"6bad51cf18249dbc5d0a4fe9ba040856fb04c0d7","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-04-18 06:03:04.000000000","message":"Patch Set 3: Abandoned\n\ncode review expired after 2 weeks of no activity, it can be restored using the `Restore Change` button  under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":3},{"id":"cca61b4551a188f5c31deb988b2eaf2f0acc1b55","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2013-04-19 04:26:12.000000000","message":"Patch Set 3: Restored","accounts_in_message":[],"_revision_number":3},{"id":"482b5f736b8e1294c45ef8001bf799a70a969088","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2013-04-19 04:26:17.000000000","message":"Patch Set 3: Rebased","accounts_in_message":[],"_revision_number":3},{"id":"b9c3203be957554dce1d7be9d3008fc751159486","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-19 05:10:46.000000000","message":"Patch Set 4: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/20231/4/check/gate-python-keystoneclient-pep8/982 : SUCCESS\n- http://docs-draft.openstack.org/20231/4/check/gate-python-keystoneclient-docs/832/doc/build/html/ : SUCCESS\n- http://logs.openstack.org/20231/4/check/gate-python-keystoneclient-python26/905 : SUCCESS\n- http://logs.openstack.org/20231/4/check/gate-python-keystoneclient-python26-rhel6/38 : SUCCESS (non-voting)\n- http://logs.openstack.org/20231/4/check/gate-python-keystoneclient-python27/910 : SUCCESS\n- http://logs.openstack.org/20231/4/check/gate-tempest-devstack-vm-full/12990 : SUCCESS\n- http://logs.openstack.org/20231/4/check/gate-tempest-devstack-vm-postgres-full/12705 : SUCCESS\n- http://logs.openstack.org/20231/4/check/gate-tempest-devstack-vm-quantum/18871 : SUCCESS\n- http://logs.openstack.org/20231/4/check/gate-grenade-devstack-vm/895 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":4},{"id":"be0ebf2c06b147741056e149b9897a3a5a94bfc6","author":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"date":"2013-04-26 03:52:07.000000000","message":"Patch Set 4: Looks good to me (core reviewer)\n\nmy primary concern originally was that this wouldn\u0027t work with a passed in AuthRef from a client above, re-read through the code, and while I haven\u0027t tried it, it looks like it\u0027ll work without issue in that format.\n\nSorry for the delay Julien, and thank you for the good work!","accounts_in_message":[],"_revision_number":4},{"id":"97e29f2b219f5016e066f14b47b9dd1462f4e575","author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"date":"2013-04-26 15:36:02.000000000","message":"Patch Set 4: Looks good to me (core reviewer); Approved\n\nLooks like this is the correct logic:  we do not need to use the management API to create tokens, and for some people, that might not even be available.  Code is simpler as well.","accounts_in_message":[],"_revision_number":4},{"id":"6330f320f8fb889bc05c823a835c02d94f9d710c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-26 15:36:05.000000000","message":"Patch Set 4: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":4},{"id":"0e64854d155be16ee95fe188a083a46b183a7694","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-26 16:20:16.000000000","message":"Patch Set 4: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/20231/4/gate/gate-python-keystoneclient-docs/840/doc/build/html/ : SUCCESS\n- http://logs.openstack.org/20231/4/gate/gate-python-keystoneclient-pep8/990 : SUCCESS\n- http://logs.openstack.org/20231/4/gate/gate-python-keystoneclient-python26/913 : SUCCESS\n- http://logs.openstack.org/20231/4/gate/gate-python-keystoneclient-python27/918 : SUCCESS\n- http://logs.openstack.org/20231/4/gate/gate-tempest-devstack-vm-full/13709 : SUCCESS\n- http://logs.openstack.org/20231/4/gate/gate-tempest-devstack-vm-postgres-full/13424 : FAILURE (non-voting)\n- http://logs.openstack.org/20231/4/gate/gate-tempest-devstack-vm-quantum/19684 : SUCCESS\n- http://logs.openstack.org/20231/4/gate/gate-grenade-devstack-vm/1555 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":4},{"id":"eba4255cf492d47b52dc4ba054803300249c9bc9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-26 16:20:16.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":4},{"id":"850a050f596597334b0d13c7232a63ca52015e04","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2013-04-30 17:34:14.000000000","message":"Patch Set 4: Reverted\n\nThis patchset was reverted in change: I28dc9b38a735a7c7d1c59ff82e39ec8e67965e1d","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"22228f526d6ea08b7006be1287afe959b93c23db","revisions":{"14ea2f9216af5c3618b57a9cd8d022a22d6efd82":{"kind":"REWORK","_number":1,"created":"2013-01-22 14:26:57.000000000","uploader":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"ref":"refs/changes/31/20231/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/31/20231/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/20231/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/20231/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/20231/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/20231/1"}}},"commit":{"parents":[{"commit":"3dfb8437fc9135465f2b66b2c420bf20899fcf10","subject":"Blueprint memcache-protection: enable memcache value encryption/integrity check","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/3dfb8437fc9135465f2b66b2c420bf20899fcf10"}]}],"author":{"name":"Julien Danjou","email":"julien@danjou.info","date":"2013-01-22 14:25:33.000000000","tz":60},"committer":{"name":"Julien Danjou","email":"julien@danjou.info","date":"2013-01-22 14:25:33.000000000","tz":60},"subject":"Use TokenManager to get token","message":"Use TokenManager to get token\n\nInstead of implementing token retrieval twice, let\u0027s use the code provided\nby the TokenManger to get a token in raw format from Keystone.\n\nChange-Id: I769be118ee137580cabd5cabcf7843e7afe1e456\nSigned-off-by: Julien Danjou \u003cjulien@danjou.info\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/14ea2f9216af5c3618b57a9cd8d022a22d6efd82"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/14ea2f9216af5c3618b57a9cd8d022a22d6efd82"}]},"branch":"refs/heads/master"},"21fb48b21c745ad0bb413fdc3dcb213452a114f7":{"kind":"REWORK","_number":2,"created":"2013-03-19 10:33:52.000000000","uploader":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"ref":"refs/changes/31/20231/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/31/20231/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/20231/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/20231/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/20231/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/20231/2"}}},"commit":{"parents":[{"commit":"b445c19dc6758ff0cfb61780c5d11e95a11f289c","subject":"Merge \"Cache tokens using memorycache from oslo.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/b445c19dc6758ff0cfb61780c5d11e95a11f289c"}]}],"author":{"name":"Julien Danjou","email":"julien@danjou.info","date":"2013-01-22 14:25:33.000000000","tz":60},"committer":{"name":"Julien Danjou","email":"julien@danjou.info","date":"2013-03-19 10:33:24.000000000","tz":60},"subject":"Use TokenManager to get token","message":"Use TokenManager to get token\n\nInstead of implementing token retrieval twice, let\u0027s use the code provided\nby the TokenManger to get a token in raw format from Keystone.\n\nChange-Id: I769be118ee137580cabd5cabcf7843e7afe1e456\nSigned-off-by: Julien Danjou \u003cjulien@danjou.info\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/21fb48b21c745ad0bb413fdc3dcb213452a114f7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/21fb48b21c745ad0bb413fdc3dcb213452a114f7"}]},"branch":"refs/heads/master"},"7b4c1deb2e53d1f37271ff006c1c4b70203aae74":{"kind":"REWORK","_number":3,"created":"2013-03-19 10:51:30.000000000","uploader":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"ref":"refs/changes/31/20231/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/31/20231/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/20231/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/20231/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/20231/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/20231/3"}}},"commit":{"parents":[{"commit":"b445c19dc6758ff0cfb61780c5d11e95a11f289c","subject":"Merge \"Cache tokens using memorycache from oslo.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/b445c19dc6758ff0cfb61780c5d11e95a11f289c"}]}],"author":{"name":"Julien Danjou","email":"julien@danjou.info","date":"2013-01-22 14:25:33.000000000","tz":60},"committer":{"name":"Julien Danjou","email":"julien@danjou.info","date":"2013-03-19 10:51:16.000000000","tz":60},"subject":"Use TokenManager to get token","message":"Use TokenManager to get token\n\nInstead of implementing token retrieval twice, let\u0027s use the code provided\nby the TokenManger to get a token in raw format from Keystone.\n\nChange-Id: I769be118ee137580cabd5cabcf7843e7afe1e456\nSigned-off-by: Julien Danjou \u003cjulien@danjou.info\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/7b4c1deb2e53d1f37271ff006c1c4b70203aae74"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/7b4c1deb2e53d1f37271ff006c1c4b70203aae74"}]},"branch":"refs/heads/master"},"22228f526d6ea08b7006be1287afe959b93c23db":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2013-03-19 10:51:30.000000000","uploader":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"ref":"refs/changes/31/20231/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/31/20231/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/20231/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/20231/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/20231/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/20231/4"}}},"commit":{"parents":[{"commit":"fc54b30e58e95fccba27f975fa3da3016630b414","subject":"Merge \"Pass json object when invoking exception handler.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/fc54b30e58e95fccba27f975fa3da3016630b414"}]}],"author":{"name":"Julien Danjou","email":"julien@danjou.info","date":"2013-01-22 14:25:33.000000000","tz":60},"committer":{"name":"Gerrit Code Review","email":"review@openstack.org","date":"2013-04-19 04:26:17.000000000","tz":0},"subject":"Use TokenManager to get token","message":"Use TokenManager to get token\n\nInstead of implementing token retrieval twice, let\u0027s use the code provided\nby the TokenManger to get a token in raw format from Keystone.\n\nChange-Id: I769be118ee137580cabd5cabcf7843e7afe1e456\nSigned-off-by: Julien Danjou \u003cjulien@danjou.info\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/22228f526d6ea08b7006be1287afe959b93c23db"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/22228f526d6ea08b7006be1287afe959b93c23db"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}