)]}'
{"keystoneclient/service_catalog.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"55c7c80d5beaf491503537611d0c250c6a193efe","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                    endpoint.get(\u0027region\u0027) !\u003d self.region_name:"},{"line_number":76,"context_line":"                    continue"},{"line_number":77,"context_line":"                if not filter_value or endpoint.get(attr) \u003d\u003d filter_value:"},{"line_number":78,"context_line":"                    return endpoint[endpoint_type]"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        raise exceptions.EndpointNotFound(\u0027Endpoint not found.\u0027)"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FZ6c%3D","line":78,"updated":"2013-01-23 20:01:48.000000000","message":"this can normally be done, for example, with attr\u003d\u0027region\u0027 and filter_value\u003d\u0027north\u0027... so i\u0027m curious what use case you\u0027re solving for here / how you\u0027re calling url_for","commit_id":"dbf1a37aacfdda5d640809dcc3d65a4cbc9c0ebf"}],"tests/test_service_catalog.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"bc2cf55ab994f593fdd6134d62ab2751f9073cae","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                          \"https://compute.north.host/v1.1/3456\")"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        self.assertRaises(exceptions.EndpointNotFound, sc.url_for, \"region\","},{"line_number":113,"context_line":"                          \"South\", service_type\u003d\u0027compute\u0027)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def test_service_catalog_endpoints(self):"},{"line_number":116,"context_line":"        sc \u003d service_catalog.ServiceCatalog(SERVICE_CATALOG[\u0027access\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FVCA%3D","line":113,"updated":"2013-01-28 20:23:09.000000000","message":"so, are we deprecating this method of selecting a region?","commit_id":"d5af38165a511a0813288d519cbfe31009b4cf25"},{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"a95492c0869a8d2b14f52ee31abb9a9c7790d8eb","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                          \"https://compute.north.host/v1.1/3456\")"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        self.assertRaises(exceptions.EndpointNotFound, sc.url_for, \"region\","},{"line_number":113,"context_line":"                          \"South\", service_type\u003d\u0027compute\u0027)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def test_service_catalog_endpoints(self):"},{"line_number":116,"context_line":"        sc \u003d service_catalog.ServiceCatalog(SERVICE_CATALOG[\u0027access\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FUww%3D","line":113,"in_reply_to":"AAAAM3%2F%2FVCA%3D","updated":"2013-01-28 23:11:19.000000000","message":"It just seems reduntant to me to specify the region when asking for the url when you\u0027ve already specified the region when instantiating the Client object. The generic attribute filter logic for the url_for method I think is still useful. I just thought it\u0027d be a handy and in my mind expected addition.","commit_id":"d5af38165a511a0813288d519cbfe31009b4cf25"}]}
