)]}'
{"id":"openstack%2Fpython-keystoneclient~20437","triplet_id":"openstack%2Fpython-keystoneclient~master~Ieea3d11f5246ee785e41df3bc54ac61200808354","project":"openstack/python-keystoneclient","branch":"master","topic":"bug/1104313","hashtags":[],"change_id":"Ieea3d11f5246ee785e41df3bc54ac61200808354","subject":"If you specify the --debug argument, it doesn\u0027t show the body of a POST request. The body (string rep) is at \u0027data\u0027 in the kwargs dict. \u0027body\u0027 was deleted prior to this call.","status":"MERGED","created":"2013-01-24 21:49:26.000000000","updated":"2013-02-16 10:58:37.000000000","submitted":"2013-02-16 10:58:37.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a5d9c4e3fcbc1f8f709bfc6d517c9c9d1a3f530d","_number":20437,"virtual_id_number":20437,"owner":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":2,"date":"2013-02-16 10:58:37.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"recommended":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"all":[{"value":0,"date":"2013-01-27 05:24:37.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":1,"date":"2013-02-06 22:23:20.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-01-29 13:26:00.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":1,"date":"2013-01-31 23:01:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":2,"date":"2013-02-16 00:21:18.000000000","_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},{"value":0,"date":"2013-01-30 22:35:09.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"all":[{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-01-29 13:26:00.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":1,"date":"2013-02-16 00:21:18.000000000","_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-01-27 05:24:37.000000000","updated_by":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"reviewer":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"state":"REVIEWER"},{"updated":"2013-01-29 13:26:00.000000000","updated_by":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"reviewer":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"state":"REVIEWER"},{"updated":"2013-01-31 23:01:50.000000000","updated_by":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"reviewer":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"state":"REVIEWER"},{"updated":"2013-02-06 22:23:20.000000000","updated_by":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"reviewer":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"state":"REVIEWER"},{"updated":"2013-02-16 00:21:18.000000000","updated_by":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"reviewer":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"state":"REVIEWER"},{"updated":"2013-02-16 10:58:37.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"b3fe73610f80a09d7a70b8e36aed77c3e13a463b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-24 22:18:02.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/20437/1/check/gate-python-keystoneclient-docs/538 : SUCCESS\n- http://logs.openstack.org/20437/1/check/gate-python-keystoneclient-pep8/682 : SUCCESS\n- http://logs.openstack.org/20437/1/check/gate-python-keystoneclient-python26/613 : SUCCESS\n- http://logs.openstack.org/20437/1/check/gate-python-keystoneclient-python27/616 : SUCCESS\n- http://logs.openstack.org/20437/1/check/gate-tempest-devstack-vm/28213 : SUCCESS\n- http://logs.openstack.org/20437/1/check/gate-tempest-devstack-vm-quantum/2713 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"7b9824db24fd8dc6112578fa7b5f0a392b279114","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2013-01-24 23:44:21.000000000","message":"Patch Set 1:\n\nIs anybody concerned that a token-get will print out your password in cleartext?","accounts_in_message":[],"_revision_number":1},{"id":"49d9b456a00e8d80b690ac58a2ee665fde5b42e2","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2013-01-27 05:24:37.000000000","message":"Patch Set 1:\n\nI\u0027m concerned, perhaps we should copy the body and redact the password? Is that feasiable at this point, or is it to late (aka already formed into a string).","accounts_in_message":[],"_revision_number":1},{"id":"86ff61c817b836476fd6985f1964fb39b2437e9e","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2013-01-29 13:26:00.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n+2 for restoring intended behavior; could definitely refactor this to pull passwords from before encoding to JSON... but if that\u0027s really a concern with --debug, should token-get itself be a considered a security vulnerability?","accounts_in_message":[],"_revision_number":1},{"id":"08ff4befcd23e7373b09cea6253396ce90544b6f","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2013-01-30 22:35:09.000000000","message":"Patch Set 1:\n\nI would like to leave this patch as a fix to the code.\n\nThere is actually a comment in v2_0/client.py: \"If debug is enabled, it may show passwords in plain text as a part of its output.\" :-) Redacting the password is a different issue (bug/feature?) than what I am addressing. I do have a code fix for that though, and am thinking that I ought to open a new bug to address that. Or I could I put that patch here, but will someone object? Who should I be trying to please? :D","accounts_in_message":[],"_revision_number":1},{"id":"6ecc5f734c20e74c0ff3e05f2a9eb88d87c12655","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2013-01-31 14:29:55.000000000","message":"Patch Set 1:\n\nI\u0027d rather consider it a separate patch, as there are several places where changes would need to be made (at least in user crud, update user\u0027s own password, and authentication)","accounts_in_message":[],"_revision_number":1},{"id":"15c2885d623e91a457cb6fd1fd29cdf6ff895769","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2013-01-31 23:01:50.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"6cad60772331b85a2367ffe0f83afd86adc73dcd","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2013-02-06 22:23:20.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nwe actually did those fixes as well in swiftclient which use the same debug feature.","accounts_in_message":[],"_revision_number":1},{"id":"586ffd8c228c136a21d919ac7030efe758c7eb56","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2013-02-07 15:56:25.000000000","message":"Patch Set 1:\n\nSorry about that Chmouel. I was going to fix swiftclient after this got approved. Thx for fixing it there!","accounts_in_message":[],"_revision_number":1},{"id":"174a156dc5fa41023163fd7eb6dc236933482940","author":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"date":"2013-02-16 00:21:18.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":1},{"id":"3951037a2a8e4aa323f849385ff2a1387ec08236","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-16 00:39:11.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"19ca50f99d80c2604da13bea0d7afc898d0a2d12","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-16 10:58:37.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1},{"id":"1df9c69e06ef6f599ba19aa85ee7527cff24eec2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-16 10:58:37.000000000","message":"Patch Set 1: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/20437/1/gate/gate-python-keystoneclient-docs/656 : SUCCESS\n- http://logs.openstack.org/20437/1/gate/gate-python-keystoneclient-pep8/800 : SUCCESS\n- http://logs.openstack.org/20437/1/gate/gate-python-keystoneclient-python26/728 : SUCCESS\n- http://logs.openstack.org/20437/1/gate/gate-python-keystoneclient-python27/734 : SUCCESS\n- http://logs.openstack.org/20437/1/gate/gate-tempest-devstack-vm-full/3296 : SUCCESS\n- http://logs.openstack.org/20437/1/gate/gate-tempest-devstack-vm-postgres-full/3019 : SUCCESS\n- http://logs.openstack.org/20437/1/gate/gate-tempest-devstack-vm-quantum/7607 : SUCCESS\n","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"e0c3e30653916cd01fa4542842d86a69e0bbb077","revisions":{"e0c3e30653916cd01fa4542842d86a69e0bbb077":{"kind":"REWORK","_number":1,"created":"2013-01-24 21:49:26.000000000","uploader":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"ref":"refs/changes/37/20437/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/37/20437/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/37/20437/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/37/20437/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/37/20437/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/37/20437/1"}}},"commit":{"parents":[{"commit":"3dfb8437fc9135465f2b66b2c420bf20899fcf10","subject":"Blueprint memcache-protection: enable memcache value encryption/integrity check","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/3dfb8437fc9135465f2b66b2c420bf20899fcf10"}]}],"author":{"name":"Ruby Loo","email":"rloo@yahoo-inc.com","date":"2013-01-24 21:42:14.000000000","tz":0},"committer":{"name":"Ruby Loo","email":"rloo@yahoo-inc.com","date":"2013-01-24 21:42:14.000000000","tz":0},"subject":"If you specify the --debug argument, it doesn\u0027t show the body of a POST request. The body (string rep) is at \u0027data\u0027 in the kwargs dict. \u0027body\u0027 was deleted prior to this call.","message":"If you specify the --debug argument, it doesn\u0027t show the body of a POST request. The\nbody (string rep) is at \u0027data\u0027 in the kwargs dict. \u0027body\u0027 was deleted prior to this call.\n\nChange-Id: Ieea3d11f5246ee785e41df3bc54ac61200808354\nFixes: bug #1104313\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/e0c3e30653916cd01fa4542842d86a69e0bbb077"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/e0c3e30653916cd01fa4542842d86a69e0bbb077"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}