)]}'
{"id":"openstack%2Fpython-keystoneclient~205676","triplet_id":"openstack%2Fpython-keystoneclient~master~Ic9fce89b8544d8c01f16e8f9c2f9dd2659d03c18","project":"openstack/python-keystoneclient","branch":"master","topic":"bp/deprecations","hashtags":[],"change_id":"Ic9fce89b8544d8c01f16e8f9c2f9dd2659d03c18","subject":"Proper deprecation for BaseIdentityPlugin username, password, token_id properties","status":"MERGED","created":"2015-07-24 19:00:14.000000000","updated":"2015-07-26 21:37:44.000000000","submitted":"2015-07-26 21:37:43.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8c048ba29325834a63df9161b209715b89de37c6","_number":205676,"virtual_id_number":205676,"owner":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2015-07-26 21:37:43.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-07-26 11:54:26.000000000","_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":2,"date":"2015-07-26 20:35:30.000000000","_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":1,"date":"2015-07-26 20:35:30.000000000","_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-07-25 09:26:50.000000000","updated_by":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"reviewer":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"state":"REVIEWER"},{"updated":"2015-07-26 20:35:30.000000000","updated_by":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"reviewer":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"state":"REVIEWER"},{"updated":"2015-07-26 21:37:43.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"92f584b554b9cd095f088ad29ad250869c6efece","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-07-24 19:00:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e892a781ef8903fbc595525e085864af0afadf54","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-24 20:58:02.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/76/205676/1/check/gate-python-keystoneclient-python26/b0e52cc/ : SUCCESS in 2m 50s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/76/205676/1/check/gate-python-keystoneclient-pep8/4f10a3a/ : SUCCESS in 2m 36s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/76/205676/1/check/gate-python-keystoneclient-docs/982b353//doc/build/html/ : SUCCESS in 3m 12s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/76/205676/1/check/gate-python-keystoneclient-python27/8eb69d1/ : SUCCESS in 3m 04s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/76/205676/1/check/gate-python-keystoneclient-python34/3624c53/ : SUCCESS in 3m 23s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/76/205676/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/16d8a73/ : SUCCESS in 47m 24s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/76/205676/1/check/gate-keystoneclient-dsvm-functional/7769e8f/ : SUCCESS in 28m 18s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/76/205676/1/check/gate-python-keystoneclient-tox-bandit/697676b/ : SUCCESS in 3m 33s","accounts_in_message":[],"_revision_number":1},{"id":"d94321e2c11701b9c3bf026526f516e447815c17","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2015-07-25 09:26:50.000000000","message":"Patch Set 1: Code-Review+2\n\nkinda messy but i\u0027m not sure of a better way","accounts_in_message":[],"_revision_number":1},{"id":"156219dba3964645966c9d39d79879d59aa83659","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-07-26 11:54:26.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"e78ff32d6a2f72e64bd67ecf52ca3b7b8b30faac","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-26 13:02:44.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/76/205676/2/check/gate-python-keystoneclient-python26/24639c8/ : SUCCESS in 2m 56s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/76/205676/2/check/gate-python-keystoneclient-pep8/d08657c/ : SUCCESS in 2m 10s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/76/205676/2/check/gate-python-keystoneclient-docs/c85dfe4//doc/build/html/ : SUCCESS in 5m 26s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/76/205676/2/check/gate-python-keystoneclient-python27/3b559f1/ : SUCCESS in 4m 08s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/76/205676/2/check/gate-python-keystoneclient-python34/999bb5e/ : SUCCESS in 5m 26s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/76/205676/2/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/6ceccff/ : SUCCESS in 1h 07m 46s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/76/205676/2/check/gate-keystoneclient-dsvm-functional/4415e04/ : SUCCESS in 27m 55s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/76/205676/2/check/gate-python-keystoneclient-tox-bandit/75f2293/ : SUCCESS in 2m 41s","accounts_in_message":[],"_revision_number":2},{"id":"e212f35d4d9a60146b87780ba9ea964dddf28f4e","author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"date":"2015-07-26 20:35:30.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"acf0190208c7cad84c1c8aba2fc6b073ce28127e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-26 20:35:35.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"bcd5856d825e57de7fc490a3398dd55dfbd2f12d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-26 21:37:43.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/76/205676/2/gate/gate-python-keystoneclient-python26/872108c/ : SUCCESS in 3m 00s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/76/205676/2/gate/gate-python-keystoneclient-docs/49d7da3//doc/build/html/ : SUCCESS in 3m 03s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/76/205676/2/gate/gate-python-keystoneclient-pep8/d04156a/ : SUCCESS in 2m 48s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/76/205676/2/gate/gate-python-keystoneclient-python27/4a7d675/ : SUCCESS in 5m 34s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/76/205676/2/gate/gate-python-keystoneclient-python34/4cadcac/ : SUCCESS in 3m 20s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/76/205676/2/gate/gate-tempest-dsvm-neutron-src-python-keystoneclient/a653225/ : SUCCESS in 48m 53s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/76/205676/2/gate/gate-keystoneclient-dsvm-functional/8b78af4/ : SUCCESS in 30m 07s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/76/205676/2/gate/gate-python-keystoneclient-tox-bandit/31f9e26/ : SUCCESS in 5m 58s","accounts_in_message":[],"_revision_number":2},{"id":"0afacc0643c6f4c10fb6a30146ffdbce47a00bf5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-26 21:37:44.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"799e1faa505ac0c62d6db76ad68cdbb2d7148888","revisions":{"46d8292742b01c158f8eee514e6af5baa4c7fc12":{"kind":"REWORK","_number":1,"created":"2015-07-24 19:00:14.000000000","uploader":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"ref":"refs/changes/76/205676/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/76/205676/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/76/205676/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/76/205676/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/76/205676/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/76/205676/1"}}},"commit":{"parents":[{"commit":"ea12006d215a5028ee9f142ebda4bbeb2a87f078","subject":"Proper deprecations for modules","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/ea12006d215a5028ee9f142ebda4bbeb2a87f078"}]}],"author":{"name":"Brant Knudson","email":"bknudson@us.ibm.com","date":"2015-07-24 18:16:00.000000000","tz":-300},"committer":{"name":"Brant Knudson","email":"bknudson@us.ibm.com","date":"2015-07-24 18:28:45.000000000","tz":-300},"subject":"Proper deprecation for BaseIdentityPlugin username, password, token_id properties","message":"Proper deprecation for BaseIdentityPlugin username, password, token_id properties\n\nBaseIdentityPlugin\u0027s username, password, and token_id properties\nweren\u0027t properly deprecated since all they had was a comment in\nthe code. Proper deprecation requires use of warnings and\ndocumentation.\n\nWhere the plugins already provide their own properties, the\nproperties need to be un-deprecated.\n\nbp deprecations\n\nChange-Id: Ic9fce89b8544d8c01f16e8f9c2f9dd2659d03c18\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/46d8292742b01c158f8eee514e6af5baa4c7fc12"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/46d8292742b01c158f8eee514e6af5baa4c7fc12"}]},"branch":"refs/heads/master"},"799e1faa505ac0c62d6db76ad68cdbb2d7148888":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2015-07-26 11:54:26.000000000","uploader":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"ref":"refs/changes/76/205676/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/76/205676/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/76/205676/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/76/205676/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/76/205676/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/76/205676/2"}}},"commit":{"parents":[{"commit":"85b32fcb9d1df1362209c2902768a4de013004cb","subject":"Proper deprecations for modules","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/85b32fcb9d1df1362209c2902768a4de013004cb"}]}],"author":{"name":"Brant Knudson","email":"bknudson@us.ibm.com","date":"2015-07-24 18:16:00.000000000","tz":-300},"committer":{"name":"Brant Knudson","email":"bknudson@us.ibm.com","date":"2015-07-26 11:54:22.000000000","tz":-300},"subject":"Proper deprecation for BaseIdentityPlugin username, password, token_id properties","message":"Proper deprecation for BaseIdentityPlugin username, password, token_id properties\n\nBaseIdentityPlugin\u0027s username, password, and token_id properties\nweren\u0027t properly deprecated since all they had was a comment in\nthe code. Proper deprecation requires use of warnings and\ndocumentation.\n\nWhere the plugins already provide their own properties, the\nproperties need to be un-deprecated.\n\nbp deprecations\n\nChange-Id: Ic9fce89b8544d8c01f16e8f9c2f9dd2659d03c18\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/799e1faa505ac0c62d6db76ad68cdbb2d7148888"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/799e1faa505ac0c62d6db76ad68cdbb2d7148888"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}