)]}'
{"id":"openstack%2Fpython-keystoneclient~205677","triplet_id":"openstack%2Fpython-keystoneclient~master~I15d4e019bfc5542990120ba39be65ad83cf040d5","project":"openstack/python-keystoneclient","branch":"master","topic":"bp/deprecations","hashtags":[],"change_id":"I15d4e019bfc5542990120ba39be65ad83cf040d5","subject":"Proper deprecation for BaseIdentityPlugin trust_id property","status":"MERGED","created":"2015-07-24 19:00:14.000000000","updated":"2015-07-26 21:37:51.000000000","submitted":"2015-07-26 21:37:50.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"50b1dc99e4894475742819f7ad199ba38cfe61a3","_number":205677,"virtual_id_number":205677,"owner":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2015-07-26 21:37:50.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":2,"date":"2015-07-26 12:17:50.000000000","_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":2,"date":"2015-07-26 20:35:59.000000000","_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":1,"date":"2015-07-26 20:35:59.000000000","_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-07-26 12:17:50.000000000","updated_by":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"reviewer":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"state":"REVIEWER"},{"updated":"2015-07-26 20:35:59.000000000","updated_by":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"reviewer":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"state":"REVIEWER"},{"updated":"2015-07-26 21:37:50.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"f7db65d8a6dc7f667e84cfd12142e57385bc2ba0","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-07-24 19:00:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3cbe086de37d2ca25afe4d1b78b494bf7b9ff210","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-24 21:02:43.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/77/205677/1/check/gate-python-keystoneclient-python26/7f235cb/ : SUCCESS in 2m 50s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/77/205677/1/check/gate-python-keystoneclient-pep8/c16b55c/ : SUCCESS in 2m 32s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/77/205677/1/check/gate-python-keystoneclient-docs/af20cd6//doc/build/html/ : SUCCESS in 3m 33s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/77/205677/1/check/gate-python-keystoneclient-python27/5234b6e/ : SUCCESS in 2m 42s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/77/205677/1/check/gate-python-keystoneclient-python34/5bff3fa/ : SUCCESS in 3m 30s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/77/205677/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/ea3ee8d/ : SUCCESS in 52m 03s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/77/205677/1/check/gate-keystoneclient-dsvm-functional/94c4e2f/ : SUCCESS in 33m 09s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/77/205677/1/check/gate-python-keystoneclient-tox-bandit/f67bdbf/ : SUCCESS in 3m 08s","accounts_in_message":[],"_revision_number":1},{"id":"d20a71026f800dad33dc294103b1846a4f745c8b","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2015-07-25 09:29:36.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"98b4e903cc2a0c1431672c81580e6a5ab2f50983","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-07-26 11:46:43.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e1b6e238e2727d751519403c80e7949704d6efbc","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-07-26 11:54:26.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"213b6c7de02209c22920d9d81851c09062f507ec","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2015-07-26 12:17:50.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"d2aeb7dea4d237674c9684791dc979d45da473ee","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-26 13:04:52.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/77/205677/2/check/gate-python-keystoneclient-python26/b30f31e/ : SUCCESS in 2m 13s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/77/205677/2/check/gate-python-keystoneclient-pep8/cec6249/ : SUCCESS in 2m 21s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/77/205677/2/check/gate-python-keystoneclient-docs/5d7e091//doc/build/html/ : SUCCESS in 2m 55s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/77/205677/2/check/gate-python-keystoneclient-python27/366605e/ : SUCCESS in 3m 56s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/77/205677/2/check/gate-python-keystoneclient-python34/9e9adbc/ : SUCCESS in 4m 23s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/77/205677/2/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/b9eef33/ : SUCCESS in 1h 09m 55s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/77/205677/2/check/gate-keystoneclient-dsvm-functional/4b1f54e/ : SUCCESS in 23m 00s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/77/205677/2/check/gate-python-keystoneclient-tox-bandit/503e811/ : SUCCESS in 4m 56s","accounts_in_message":[],"_revision_number":2},{"id":"3224e878ee2a6d5edb7809be4d2f48351b0411a3","author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"date":"2015-07-26 20:35:59.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"78167196583ced7f51a62e214e70b5af9a1e79c2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-26 20:36:04.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"63e6cd32b4a8dabed89d80bffb1586d77c9370a7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-26 21:37:50.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/77/205677/2/gate/gate-python-keystoneclient-python26/3b7336b/ : SUCCESS in 2m 54s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/77/205677/2/gate/gate-python-keystoneclient-docs/e35236b//doc/build/html/ : SUCCESS in 2m 58s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/77/205677/2/gate/gate-python-keystoneclient-pep8/5151388/ : SUCCESS in 1m 59s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/77/205677/2/gate/gate-python-keystoneclient-python27/4a8318f/ : SUCCESS in 2m 13s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/77/205677/2/gate/gate-python-keystoneclient-python34/661df2c/ : SUCCESS in 3m 48s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/77/205677/2/gate/gate-tempest-dsvm-neutron-src-python-keystoneclient/e10c05e/ : SUCCESS in 49m 12s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/77/205677/2/gate/gate-keystoneclient-dsvm-functional/40c41a5/ : SUCCESS in 20m 53s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/77/205677/2/gate/gate-python-keystoneclient-tox-bandit/6ebe877/ : SUCCESS in 4m 43s","accounts_in_message":[],"_revision_number":2},{"id":"6b600e36eaaa51e498abfad10a16dc200c490228","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-26 21:37:51.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b1496abbb77360672d1d94e689513daeeb3cafd0","revisions":{"a0ccc13cf7e3563df777a6ca6c6f62a743300993":{"kind":"REWORK","_number":1,"created":"2015-07-24 19:00:14.000000000","uploader":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"ref":"refs/changes/77/205677/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/77/205677/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/77/205677/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/77/205677/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/77/205677/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/77/205677/1"}}},"commit":{"parents":[{"commit":"46d8292742b01c158f8eee514e6af5baa4c7fc12","subject":"Proper deprecation for BaseIdentityPlugin username, password, token_id properties","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/46d8292742b01c158f8eee514e6af5baa4c7fc12"}]}],"author":{"name":"Brant Knudson","email":"bknudson@us.ibm.com","date":"2015-07-24 18:57:12.000000000","tz":-300},"committer":{"name":"Brant Knudson","email":"bknudson@us.ibm.com","date":"2015-07-24 18:58:51.000000000","tz":-300},"subject":"Proper deprecation for BaseIdentityPlugin trust_id property","message":"Proper deprecation for BaseIdentityPlugin trust_id property\n\nBaseIdentityPlugin\u0027s trust_id property wasn\u0027t properly deprecated\nsince all it had was a comment in the code. Proper deprecation\nrequires use of warnings and documentation.\n\nWhere the plugins already provide their own trust_id, the\nproperty needs to be un-deprecated.\n\nbp deprecations\n\nChange-Id: I15d4e019bfc5542990120ba39be65ad83cf040d5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/a0ccc13cf7e3563df777a6ca6c6f62a743300993"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/a0ccc13cf7e3563df777a6ca6c6f62a743300993"}]},"branch":"refs/heads/master"},"b1496abbb77360672d1d94e689513daeeb3cafd0":{"kind":"REWORK","_number":2,"created":"2015-07-26 11:54:26.000000000","uploader":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"ref":"refs/changes/77/205677/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/77/205677/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/77/205677/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/77/205677/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/77/205677/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/77/205677/2"}}},"commit":{"parents":[{"commit":"799e1faa505ac0c62d6db76ad68cdbb2d7148888","subject":"Proper deprecation for BaseIdentityPlugin username, password, token_id properties","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/799e1faa505ac0c62d6db76ad68cdbb2d7148888"}]}],"author":{"name":"Brant Knudson","email":"bknudson@us.ibm.com","date":"2015-07-24 18:57:12.000000000","tz":-300},"committer":{"name":"Brant Knudson","email":"bknudson@us.ibm.com","date":"2015-07-26 11:54:22.000000000","tz":-300},"subject":"Proper deprecation for BaseIdentityPlugin trust_id property","message":"Proper deprecation for BaseIdentityPlugin trust_id property\n\nBaseIdentityPlugin\u0027s trust_id property wasn\u0027t properly deprecated\nsince all it had was a comment in the code. Proper deprecation\nrequires use of warnings and documentation.\n\nWhere the plugins already provide their own trust_id, the\nproperty needs to be un-deprecated.\n\nbp deprecations\n\nChange-Id: I15d4e019bfc5542990120ba39be65ad83cf040d5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/b1496abbb77360672d1d94e689513daeeb3cafd0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/b1496abbb77360672d1d94e689513daeeb3cafd0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}