)]}'
{"id":"openstack%2Fpython-keystoneclient~205687","triplet_id":"openstack%2Fpython-keystoneclient~master~I1c50c1441b23a79831e6e1df749084130e4b9af7","project":"openstack/python-keystoneclient","branch":"master","topic":"bp/deprecations","hashtags":[],"change_id":"I1c50c1441b23a79831e6e1df749084130e4b9af7","subject":"Proper deprecation for client.HTTPClient","status":"MERGED","created":"2015-07-24 19:46:34.000000000","updated":"2015-07-26 21:38:57.000000000","submitted":"2015-07-26 21:38:56.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a092db672fdfae2ab134b821712961b50cc8db1e","_number":205687,"virtual_id_number":205687,"owner":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2015-07-26 21:38:56.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-07-26 12:19:53.000000000","_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":2,"date":"2015-07-26 20:37:59.000000000","_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":1,"date":"2015-07-26 20:37:59.000000000","_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-07-26 12:19:53.000000000","updated_by":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"reviewer":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"state":"REVIEWER"},{"updated":"2015-07-26 20:37:59.000000000","updated_by":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"reviewer":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"state":"REVIEWER"},{"updated":"2015-07-26 21:38:56.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"2c53661642c6b30272b2995efd5052797f61ce96","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-07-24 19:46:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d07f50eee412beb3d910b3492688da374adaf243","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-24 21:42:56.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/87/205687/1/check/gate-python-keystoneclient-python26/7fb34c2/ : SUCCESS in 2m 31s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/87/205687/1/check/gate-python-keystoneclient-pep8/b71aee8/ : SUCCESS in 2m 03s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/87/205687/1/check/gate-python-keystoneclient-docs/090f1a6//doc/build/html/ : SUCCESS in 3m 21s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/87/205687/1/check/gate-python-keystoneclient-python27/086581d/ : SUCCESS in 2m 14s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/87/205687/1/check/gate-python-keystoneclient-python34/345783e/ : SUCCESS in 2m 59s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/87/205687/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/9c0dfac/ : SUCCESS in 1h 01m 24s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/87/205687/1/check/gate-keystoneclient-dsvm-functional/93372b8/ : SUCCESS in 29m 54s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/87/205687/1/check/gate-python-keystoneclient-tox-bandit/235e03e/ : SUCCESS in 2m 50s","accounts_in_message":[],"_revision_number":1},{"id":"829d0b8f2f01d93450055404f5b7fb659009e243","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-07-26 11:54:26.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"4a4d3c80b6d8f8cf8530de39917455efbf0e1f18","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2015-07-26 12:19:53.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"5a5c411d60dd8943333b878ace8546c18376c887","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-26 12:55:52.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/87/205687/2/check/gate-python-keystoneclient-python26/77f7e8c/ : SUCCESS in 5m 10s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/87/205687/2/check/gate-python-keystoneclient-pep8/8387cb1/ : SUCCESS in 2m 38s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/87/205687/2/check/gate-python-keystoneclient-docs/eefb74c//doc/build/html/ : SUCCESS in 2m 59s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/87/205687/2/check/gate-python-keystoneclient-python27/b3a8c72/ : SUCCESS in 2m 24s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/87/205687/2/check/gate-python-keystoneclient-python34/94fe476/ : SUCCESS in 2m 47s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/87/205687/2/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/41c16d9/ : SUCCESS in 1h 00m 50s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/87/205687/2/check/gate-keystoneclient-dsvm-functional/fbfc7fa/ : SUCCESS in 25m 58s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/87/205687/2/check/gate-python-keystoneclient-tox-bandit/77f40a5/ : SUCCESS in 3m 09s","accounts_in_message":[],"_revision_number":2},{"id":"5de7279f4ffb7fb379861a14889bddfa3072a739","author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"date":"2015-07-26 20:37:59.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"4fd6d520a1f80fa519dd9f2e65bd7cacd01d918a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-26 20:38:05.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"50f3c124e10cdaa18737d180c043212cfa224771","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-26 21:38:56.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/87/205687/2/gate/gate-python-keystoneclient-python26/154ff57/ : SUCCESS in 2m 15s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/87/205687/2/gate/gate-python-keystoneclient-docs/3e9033d//doc/build/html/ : SUCCESS in 6m 49s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/87/205687/2/gate/gate-python-keystoneclient-pep8/e8d2c05/ : SUCCESS in 2m 30s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/87/205687/2/gate/gate-python-keystoneclient-python27/9bb57bc/ : SUCCESS in 2m 17s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/87/205687/2/gate/gate-python-keystoneclient-python34/bd49fc3/ : SUCCESS in 2m 53s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/87/205687/2/gate/gate-tempest-dsvm-neutron-src-python-keystoneclient/c085e5f/ : SUCCESS in 46m 54s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/87/205687/2/gate/gate-keystoneclient-dsvm-functional/e4e87a7/ : SUCCESS in 28m 04s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/87/205687/2/gate/gate-python-keystoneclient-tox-bandit/7a1609e/ : SUCCESS in 2m 17s","accounts_in_message":[],"_revision_number":2},{"id":"bbccc469ef5ebc06e51f91cd271d3c2ad7a817d6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-26 21:38:57.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"ce58b07eea29a43ee42655627e78820add16d1f5","revisions":{"af800746fe842b923b7ae43e175997685cf6595b":{"kind":"REWORK","_number":1,"created":"2015-07-24 19:46:34.000000000","uploader":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"ref":"refs/changes/87/205687/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/87/205687/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/87/205687/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/87/205687/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/87/205687/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/87/205687/1"}}},"commit":{"parents":[{"commit":"7e06f18cbe215823b902b85c8283f11056a51a52","subject":"Proper deprecation for Manager.api","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/7e06f18cbe215823b902b85c8283f11056a51a52"}]}],"author":{"name":"Brant Knudson","email":"bknudson@us.ibm.com","date":"2015-07-24 19:21:37.000000000","tz":-300},"committer":{"name":"Brant Knudson","email":"bknudson@us.ibm.com","date":"2015-07-24 19:21:37.000000000","tz":-300},"subject":"Proper deprecation for client.HTTPClient","message":"Proper deprecation for client.HTTPClient\n\nclient.HTTPClient wasn\u0027t properly deprecated since all it had was\na comment in the code. Proper deprecation requires use of warnings\nand documentation.\n\nbp deprecations\n\nChange-Id: I1c50c1441b23a79831e6e1df749084130e4b9af7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/af800746fe842b923b7ae43e175997685cf6595b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/af800746fe842b923b7ae43e175997685cf6595b"}]},"branch":"refs/heads/master"},"ce58b07eea29a43ee42655627e78820add16d1f5":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2015-07-26 11:54:26.000000000","uploader":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"ref":"refs/changes/87/205687/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/87/205687/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/87/205687/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/87/205687/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/87/205687/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/87/205687/2"}}},"commit":{"parents":[{"commit":"c5b03191b6714fed15bd88769c89e897257c337d","subject":"Proper deprecation for Manager.api","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/c5b03191b6714fed15bd88769c89e897257c337d"}]}],"author":{"name":"Brant Knudson","email":"bknudson@us.ibm.com","date":"2015-07-24 19:21:37.000000000","tz":-300},"committer":{"name":"Brant Knudson","email":"bknudson@us.ibm.com","date":"2015-07-26 11:54:23.000000000","tz":-300},"subject":"Proper deprecation for client.HTTPClient","message":"Proper deprecation for client.HTTPClient\n\nclient.HTTPClient wasn\u0027t properly deprecated since all it had was\na comment in the code. Proper deprecation requires use of warnings\nand documentation.\n\nbp deprecations\n\nChange-Id: I1c50c1441b23a79831e6e1df749084130e4b9af7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/ce58b07eea29a43ee42655627e78820add16d1f5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/ce58b07eea29a43ee42655627e78820add16d1f5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}