)]}'
{"keystoneclient/service_catalog.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"d3dea224eb62856678f3cac41882376af3d84c64","unresolved":false,"context_lines":[{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        if attr and not filter_value:"},{"line_number":193,"context_line":"            warnings.warn("},{"line_number":194,"context_line":"                \u0027Setting attr and not filter_value to get_urls is deprecated \u0027"},{"line_number":195,"context_line":"                \u0027in favor of not setting both as of the 1.7.0 release and may \u0027"},{"line_number":196,"context_line":"                \u0027be removed in the 2.0.0 release.\u0027)"},{"line_number":197,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_0103bc74","line":194,"updated":"2015-08-03 20:27:04.000000000","message":"s/Setting/Providing/ ?\n\ns/and not/without/\n\ns/get_urls/get_urls()/","commit_id":"836ae7760f2dac831f29c299e26e1b59382bfbf4"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"fa5efb9c25dc44912e5e51c25307c479f638eb3e","unresolved":false,"context_lines":[{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        if attr and not filter_value:"},{"line_number":193,"context_line":"            warnings.warn("},{"line_number":194,"context_line":"                \u0027Setting attr and not filter_value to get_urls is deprecated \u0027"},{"line_number":195,"context_line":"                \u0027in favor of not setting both as of the 1.7.0 release and may \u0027"},{"line_number":196,"context_line":"                \u0027be removed in the 2.0.0 release.\u0027)"},{"line_number":197,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_fc9f2001","line":194,"in_reply_to":"1a4dcd0f_0103bc74","updated":"2015-08-04 19:24:44.000000000","message":"Done","commit_id":"836ae7760f2dac831f29c299e26e1b59382bfbf4"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"d3dea224eb62856678f3cac41882376af3d84c64","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        if attr and not filter_value:"},{"line_number":193,"context_line":"            warnings.warn("},{"line_number":194,"context_line":"                \u0027Setting attr and not filter_value to get_urls is deprecated \u0027"},{"line_number":195,"context_line":"                \u0027in favor of not setting both as of the 1.7.0 release and may \u0027"},{"line_number":196,"context_line":"                \u0027be removed in the 2.0.0 release.\u0027)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        if filter_value:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_4109c494","line":195,"updated":"2015-08-03 20:27:04.000000000","message":"in favor of --not-- setting both?","commit_id":"836ae7760f2dac831f29c299e26e1b59382bfbf4"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"fa5efb9c25dc44912e5e51c25307c479f638eb3e","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        if attr and not filter_value:"},{"line_number":193,"context_line":"            warnings.warn("},{"line_number":194,"context_line":"                \u0027Setting attr and not filter_value to get_urls is deprecated \u0027"},{"line_number":195,"context_line":"                \u0027in favor of not setting both as of the 1.7.0 release and may \u0027"},{"line_number":196,"context_line":"                \u0027be removed in the 2.0.0 release.\u0027)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        if filter_value:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_1ca3ec50","line":195,"in_reply_to":"1a4dcd0f_4109c494","updated":"2015-08-04 19:24:44.000000000","message":"Done","commit_id":"836ae7760f2dac831f29c299e26e1b59382bfbf4"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"485405983ae1c5dc5125184cc099fcb295291355","unresolved":false,"context_lines":[{"line_number":190,"context_line":"            return"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        if attr and not filter_value:"},{"line_number":193,"context_line":"            warnings.warn("},{"line_number":194,"context_line":"                \u0027Providing attr without filter_value to get_urls() is \u0027"},{"line_number":195,"context_line":"                \u0027deprecated as of the 1.7.0 release and may be removed in the \u0027"},{"line_number":196,"context_line":"                \u00272.0.0 release. Either both should be provided or neither \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_e12822f1","line":193,"updated":"2015-08-13 16:46:13.000000000","message":"we don\u0027t need to add: \n\n     self.deprecations.expect_deprecations()\n\nto any tests because of this change?","commit_id":"aeefabf41f0a58e807bc47eae1139e568e207cb7"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7fb41a459f6d349504fb057f04744102e272c94a","unresolved":false,"context_lines":[{"line_number":190,"context_line":"            return"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        if attr and not filter_value:"},{"line_number":193,"context_line":"            warnings.warn("},{"line_number":194,"context_line":"                \u0027Providing attr without filter_value to get_urls() is \u0027"},{"line_number":195,"context_line":"                \u0027deprecated as of the 1.7.0 release and may be removed in the \u0027"},{"line_number":196,"context_line":"                \u00272.0.0 release. Either both should be provided or neither \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_11f04966","line":193,"in_reply_to":"1a4dcd0f_7c2fc388","updated":"2015-08-20 14:28:47.000000000","message":"and we\u0027re not going to add a test because it\u0027s deprecated behavior that will soon be removed?","commit_id":"aeefabf41f0a58e807bc47eae1139e568e207cb7"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"f4bf174038c86a1bab9c7d2ee38a4a888559f40c","unresolved":false,"context_lines":[{"line_number":190,"context_line":"            return"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        if attr and not filter_value:"},{"line_number":193,"context_line":"            warnings.warn("},{"line_number":194,"context_line":"                \u0027Providing attr without filter_value to get_urls() is \u0027"},{"line_number":195,"context_line":"                \u0027deprecated as of the 1.7.0 release and may be removed in the \u0027"},{"line_number":196,"context_line":"                \u00272.0.0 release. Either both should be provided or neither \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_7c2fc388","line":193,"in_reply_to":"1a4dcd0f_e12822f1","updated":"2015-08-13 23:59:24.000000000","message":"The tests pass without it so no tests need to be changed.","commit_id":"aeefabf41f0a58e807bc47eae1139e568e207cb7"}]}