)]}'
{"id":"openstack%2Fpython-keystoneclient~207857","triplet_id":"openstack%2Fpython-keystoneclient~master~I5a65a5c710712528f77b5b87810937543d3c3ee3","project":"openstack/python-keystoneclient","branch":"master","topic":"bug/1480212","hashtags":[],"change_id":"I5a65a5c710712528f77b5b87810937543d3c3ee3","subject":"pass correct max_positional_arg 4 utils.positional","status":"ABANDONED","created":"2015-07-31 12:09:36.000000000","updated":"2016-01-25 06:25:36.000000000","total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8619fb03d347434cd3fa460d7d3346f78c308445","_number":207857,"virtual_id_number":207857,"owner":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2015-09-17 06:42:31.000000000","_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":-1,"date":"2015-12-04 00:17:23.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"disliked":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},{"value":-1,"date":"2015-11-26 04:51:01.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2015-12-01 11:01:06.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":-1,"date":"2015-09-15 19:49:13.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},{"value":1,"date":"2015-09-15 10:55:12.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-08-13 17:55:45.000000000","updated_by":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"reviewer":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"state":"REVIEWER"},{"updated":"2015-09-14 03:30:35.000000000","updated_by":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"reviewer":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"state":"REVIEWER"},{"updated":"2015-09-15 10:55:12.000000000","updated_by":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"reviewer":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"state":"REVIEWER"},{"updated":"2015-09-15 19:49:13.000000000","updated_by":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"reviewer":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"state":"REVIEWER"},{"updated":"2015-11-26 04:51:01.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2015-12-01 11:01:06.000000000","updated_by":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"reviewer":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"state":"REVIEWER"},{"updated":"2015-12-04 00:17:23.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"422573b7af68cb924d5550d242557cc225224b85","author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"date":"2015-07-31 12:09:36.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2bf5b5c14e01e69ddf70755ae7ea0d7166e58a9a","author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"date":"2015-07-31 12:23:39.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"3bb3f659b2082c19cb75c4051b40b58b1a15338c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-31 14:24:38.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/57/207857/2/check/gate-python-keystoneclient-python26/514f407/ : SUCCESS in 2m 12s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/57/207857/2/check/gate-python-keystoneclient-pep8/baf9aac/ : SUCCESS in 2m 22s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/57/207857/2/check/gate-python-keystoneclient-docs/2b0ed71//doc/build/html/ : SUCCESS in 2m 16s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/57/207857/2/check/gate-python-keystoneclient-python27/8f8bfcc/ : SUCCESS in 2m 40s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/57/207857/2/check/gate-python-keystoneclient-python34/df0bac1/ : SUCCESS in 3m 11s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/57/207857/2/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/7e07aae/ : SUCCESS in 1h 10m 04s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/57/207857/2/check/gate-keystoneclient-dsvm-functional/2172303/ : SUCCESS in 27m 56s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/57/207857/2/check/gate-python-keystoneclient-tox-bandit/8331251/ : SUCCESS in 2m 18s","accounts_in_message":[],"_revision_number":2},{"id":"337fc9f02f2176336ba8ac63ce55c0cc84d5322f","author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"date":"2015-08-04 18:40:20.000000000","message":"Patch Set 2: Code-Review+1\n\nNice catch!","accounts_in_message":[],"_revision_number":2},{"id":"1dee5ac20ff7b36a9b90628f64d25b314a9b04df","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2015-08-13 17:55:45.000000000","message":"Patch Set 2: Code-Review+2\n\nThis is consistent with the documentation: \n\nhttps://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/utils.py#L225-L238","accounts_in_message":[],"_revision_number":2},{"id":"e2cee53aae4d8d0f60a6d3e6df05ddb5187f9130","author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"date":"2015-08-18 09:13:24.000000000","message":"Patch Set 2:\n\nthanks","accounts_in_message":[],"_revision_number":2},{"id":"37fb4f97c6cde783bb8d41265be5d8ff2fdc2015","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-26 04:07:06.000000000","message":"Patch Set 2: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":2},{"id":"823e81c0c3a4fa6d49956c46fc131496aa2ee115","author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"date":"2015-08-28 02:51:21.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"c14756322449f8fe5f672244620da020a3d55bc0","author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"date":"2015-08-28 02:54:16.000000000","message":"Patch Set 3:\n\nrebased","accounts_in_message":[],"_revision_number":3},{"id":"770b679cfd1f27a05db6d7595b29dbb7c2759b8e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-28 04:54:56.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/57/207857/3/check/gate-python-keystoneclient-python26/039cdac/ : SUCCESS in 2m 21s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/57/207857/3/check/gate-python-keystoneclient-pep8/8552ec6/ : SUCCESS in 2m 41s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/57/207857/3/check/gate-python-keystoneclient-docs/b337266//doc/build/html/ : SUCCESS in 2m 00s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/57/207857/3/check/gate-python-keystoneclient-python27/d8f9ade/ : SUCCESS in 2m 42s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/57/207857/3/check/gate-python-keystoneclient-python34/88587cc/ : SUCCESS in 3m 24s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/57/207857/3/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/4d56f36/ : SUCCESS in 1h 14m 26s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/57/207857/3/check/gate-keystoneclient-dsvm-functional/3d6d19c/ : SUCCESS in 30m 53s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/57/207857/3/check/gate-python-keystoneclient-tox-bandit/2c4d409/ : SUCCESS in 2m 01s","accounts_in_message":[],"_revision_number":3},{"id":"9d73fcc8c684ec04111effdffc22d54e3828b46b","author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"date":"2015-09-14 03:30:35.000000000","message":"Patch Set 3: Code-Review+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"c40f733a91653ca18c5bd410bd693ce97b09b93a","author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"date":"2015-09-15 06:32:21.000000000","message":"Patch Set 4: Commit message was updated","accounts_in_message":[],"_revision_number":4},{"id":"981dbb0553fb102172ae2adb485f0a975d1c101b","author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"date":"2015-09-15 06:32:52.000000000","message":"Patch Set 3:\n\n(2 comments)\n\nthanks","accounts_in_message":[],"_revision_number":3},{"id":"6e90bf350a9e6a9af5f9212a216216a37ae379aa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-15 07:24:09.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/57/207857/4/check/gate-python-keystoneclient-python26/5ce9b0b/ : SUCCESS in 2m 40s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/57/207857/4/check/gate-python-keystoneclient-pep8/6ef4b9f/ : SUCCESS in 2m 11s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/57/207857/4/check/gate-python-keystoneclient-docs/6195d9a//doc/build/html/ : SUCCESS in 3m 02s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/57/207857/4/check/gate-python-keystoneclient-python27/ef37b85/ : SUCCESS in 2m 46s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/57/207857/4/check/gate-python-keystoneclient-python34/c8d8326/ : SUCCESS in 3m 20s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/57/207857/4/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/f904a04/ : SUCCESS in 50m 11s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/57/207857/4/check/gate-keystoneclient-dsvm-functional/5438bba/ : SUCCESS in 26m 45s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/57/207857/4/check/gate-python-keystoneclient-tox-bandit/7e15a2e/ : SUCCESS in 2m 38s","accounts_in_message":[],"_revision_number":4},{"id":"596b358c6a9047fc6159c9bf076be28b44a02314","author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"date":"2015-09-15 10:55:12.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"d5261ec16511821edccb6f861bb293b69021f06b","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2015-09-15 19:49:13.000000000","message":"Patch Set 4: Code-Review-1\n\nself is accounted for, those options are required keyword arguments, so in\n\n@positional(1)\ndef func(self, a, b, c\u003dNone):\n\nyou must pass a and b as keyword arguments. \n\nWhere are you calling this from that you see these warnings? I\u0027d fix it there, not keystoneclient.","accounts_in_message":[],"_revision_number":4},{"id":"7ed9e6b83b241cfa650276f8591743be956488a0","author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"date":"2015-09-17 06:42:31.000000000","message":"Patch Set 4:\n\n@Jamie Lennox, it\u0027s called by horizon such as:\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/api/keystone.py#L331\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/api/keystone.py#L186\n\nNot sure why we force people to pass everything via keyword argument.","accounts_in_message":[],"_revision_number":4},{"id":"024fc3f3e24d16275c0b81d7f507570c1216f82f","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-11-26 04:51:01.000000000","message":"Patch Set 4: Code-Review-1\n\njust call it with kwargs, it\u0027s much safer that way","accounts_in_message":[],"_revision_number":4},{"id":"fd301c14bda6e044a64df0aa3ddcec678392ec62","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-12-01 11:01:06.000000000","message":"Patch Set 4: Code-Review-1\n\nhorizon seem to be passing the right positional arg.\n\nIf self should be accounted for, perhaps the bug is in utils.positional and should be fixed there.","accounts_in_message":[],"_revision_number":4},{"id":"89419c561ccd87ded5e30772c5a6f9a2d61fd3a9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-04 00:17:23.000000000","message":"Patch Set 4: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":4},{"id":"60381a5ffab6d2c9c784265701b61df045b60d9e","author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"date":"2016-01-25 06:25:36.000000000","message":"Abandoned\n\nJamie Lennox\nSep 16 3:49 AM\n↩\nPatch Set 4: Code-Review-1\nself is accounted for","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"5bb901ae2b4c3c0ecf4017a9648dc32a77951f9d","revisions":{"53fa4e71e69d57231ffe52895dec5866e39a11cf":{"kind":"REWORK","_number":1,"created":"2015-07-31 12:09:36.000000000","uploader":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"ref":"refs/changes/57/207857/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/57/207857/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/57/207857/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/57/207857/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/57/207857/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/57/207857/1"}}},"commit":{"parents":[{"commit":"9e470a5d7757b97ef74a8c3ecdd95852221db450","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/9e470a5d7757b97ef74a8c3ecdd95852221db450"}]}],"author":{"name":"Javeme","email":"zhangmei.li@easystack.cn","date":"2015-07-31 11:38:16.000000000","tz":480},"committer":{"name":"Javeme","email":"zhangmei.li@easystack.cn","date":"2015-07-31 12:09:27.000000000","tz":480},"subject":"pass correct max_positional_arg 4 utils.positional","message":"pass correct max_positional_arg 4 utils.positional\n\nwe should account for the parameter `self` when using\nthe decorator utils.positional.\nafter this patch, there will be no warning log such as\n\u0027create takes at most 1 positional argument (2 given)\u0027\nwhen we passed the correct number of parameters.\n\nChange-Id: I5a65a5c710712528f77b5b87810937543d3c3ee3\nCloses-Bug: #1480212\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/53fa4e71e69d57231ffe52895dec5866e39a11cf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/53fa4e71e69d57231ffe52895dec5866e39a11cf"}]},"branch":"refs/heads/master"},"7fbfb6ee64f91b182c5efbd1624aaf2ca3722bb6":{"kind":"REWORK","_number":2,"created":"2015-07-31 12:23:39.000000000","uploader":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"ref":"refs/changes/57/207857/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/57/207857/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/57/207857/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/57/207857/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/57/207857/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/57/207857/2"}}},"commit":{"parents":[{"commit":"9e470a5d7757b97ef74a8c3ecdd95852221db450","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/9e470a5d7757b97ef74a8c3ecdd95852221db450"}]}],"author":{"name":"Javeme","email":"zhangmei.li@easystack.cn","date":"2015-07-31 11:38:16.000000000","tz":480},"committer":{"name":"Javeme","email":"zhangmei.li@easystack.cn","date":"2015-07-31 12:17:07.000000000","tz":480},"subject":"pass correct max_positional_arg 4 utils.positional","message":"pass correct max_positional_arg 4 utils.positional\n\nwe should account for the parameter `self` when using\nthe decorator utils.positional.\nafter this patch, there will be no warning log such as\n\u0027create takes at most 1 positional argument (2 given)\u0027\nwhen we passed the correct number of parameters.\n\nChange-Id: I5a65a5c710712528f77b5b87810937543d3c3ee3\nCloses-Bug: #1480212\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/7fbfb6ee64f91b182c5efbd1624aaf2ca3722bb6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/7fbfb6ee64f91b182c5efbd1624aaf2ca3722bb6"}]},"branch":"refs/heads/master"},"5b30bdf28bbcea46d2743d7232bb5b837d6a93be":{"kind":"REWORK","_number":3,"created":"2015-08-28 02:51:21.000000000","uploader":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"ref":"refs/changes/57/207857/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/57/207857/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/57/207857/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/57/207857/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/57/207857/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/57/207857/3"}}},"commit":{"parents":[{"commit":"ee6d64a8fb96756abd4d85aa50f7842104602328","subject":"Merge \"Fix Accept header in SAML2 requests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/ee6d64a8fb96756abd4d85aa50f7842104602328"}]}],"author":{"name":"Javeme","email":"zhangmei.li@easystack.cn","date":"2015-07-31 11:38:16.000000000","tz":480},"committer":{"name":"Javeme","email":"zhangmei.li@easystack.cn","date":"2015-08-28 02:50:34.000000000","tz":480},"subject":"pass correct max_positional_arg 4 utils.positional","message":"pass correct max_positional_arg 4 utils.positional\n\nwe should account for the parameter `self` when using\nthe decorator utils.positional.\nafter this patch, there will be no warning log such as\n\u0027create takes at most 1 positional argument (2 given)\u0027\nwhen we passed the correct number of parameters.\n\nChange-Id: I5a65a5c710712528f77b5b87810937543d3c3ee3\nCloses-Bug: #1480212\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/5b30bdf28bbcea46d2743d7232bb5b837d6a93be"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/5b30bdf28bbcea46d2743d7232bb5b837d6a93be"}]},"branch":"refs/heads/master"},"5bb901ae2b4c3c0ecf4017a9648dc32a77951f9d":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2015-09-15 06:32:21.000000000","uploader":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"ref":"refs/changes/57/207857/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/57/207857/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/57/207857/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/57/207857/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/57/207857/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/57/207857/4"}}},"commit":{"parents":[{"commit":"ee6d64a8fb96756abd4d85aa50f7842104602328","subject":"Merge \"Fix Accept header in SAML2 requests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/ee6d64a8fb96756abd4d85aa50f7842104602328"}]}],"author":{"name":"Javeme","email":"zhangmei.li@easystack.cn","date":"2015-07-31 11:38:16.000000000","tz":480},"committer":{"name":"javeme","email":"javaloveme@gmail.com","date":"2015-09-15 06:32:21.000000000","tz":0},"subject":"pass correct max_positional_arg 4 utils.positional","message":"pass correct max_positional_arg 4 utils.positional\n\nWe should account for the parameter `self` when using the\ndecorator utils.positional.\nAfter this patch, there will be no warning in the log such\nas \u0027create takes at most 1 positional argument (2 given)\u0027\nwhen we passed the correct number of parameters.\n\nChange-Id: I5a65a5c710712528f77b5b87810937543d3c3ee3\nCloses-Bug: #1480212\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/5bb901ae2b4c3c0ecf4017a9648dc32a77951f9d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/5bb901ae2b4c3c0ecf4017a9648dc32a77951f9d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}