)]}'
{"id":"openstack%2Fpython-keystoneclient~208218","triplet_id":"openstack%2Fpython-keystoneclient~master~Ic42f5a0bac07113aff59d36d19293dc6d65cd58a","project":"openstack/python-keystoneclient","branch":"master","topic":"cleanup","hashtags":[],"change_id":"Ic42f5a0bac07113aff59d36d19293dc6d65cd58a","subject":"Clarify setting socket_options","status":"MERGED","created":"2015-08-02 16:25:29.000000000","updated":"2015-08-03 21:42:39.000000000","submitted":"2015-08-03 21:42:37.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c5adff17caf297c342f11fe2a1789b5a149c6cc5","_number":208218,"virtual_id_number":208218,"owner":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2015-08-03 21:42:37.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-08-03 20:37:43.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":2,"date":"2015-08-02 18:10:08.000000000","_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-08-03 20:37:43.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-08-02 18:10:08.000000000","updated_by":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"reviewer":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"state":"REVIEWER"},{"updated":"2015-08-03 20:37:43.000000000","updated_by":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"reviewer":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"state":"REVIEWER"},{"updated":"2015-08-03 21:42:37.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"0837eeb5a345aeea629176b019d5341e61d7af40","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-08-02 16:25:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9e131200a61e168e507c3511f0685965a1ee40f8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-02 17:38:17.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/18/208218/1/check/gate-python-keystoneclient-python26/6c90a06/ : SUCCESS in 2m 15s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/18/208218/1/check/gate-python-keystoneclient-pep8/3d51d54/ : SUCCESS in 2m 23s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/18/208218/1/check/gate-python-keystoneclient-docs/2eea3cb//doc/build/html/ : SUCCESS in 3m 01s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/18/208218/1/check/gate-python-keystoneclient-python27/44d7c68/ : SUCCESS in 2m 31s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/18/208218/1/check/gate-python-keystoneclient-python34/4ba2131/ : SUCCESS in 3m 25s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/18/208218/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/47dac39/ : SUCCESS in 1h 12m 34s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/18/208218/1/check/gate-keystoneclient-dsvm-functional/712f9fb/ : SUCCESS in 19m 37s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/18/208218/1/check/gate-python-keystoneclient-tox-bandit/31132cf/ : SUCCESS in 2m 41s","accounts_in_message":[],"_revision_number":1},{"id":"e84c95f9ff332af04cd2c4f624c1b3c3ebc350b3","author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"date":"2015-08-02 18:10:08.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"93b25f13c54a0a044629e002513e2874d1bd097d","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2015-08-03 20:37:43.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"a6fcf19049c86b8998c7292337bdd4ae0da8a777","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-03 20:37:48.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"9b3e25129d7478319ef9ce22c58f3d7be2160e53","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-03 21:42:37.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/18/208218/1/gate/gate-python-keystoneclient-python26/017091c/ : SUCCESS in 2m 51s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/18/208218/1/gate/gate-python-keystoneclient-docs/315bbc5//doc/build/html/ : SUCCESS in 3m 16s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/18/208218/1/gate/gate-python-keystoneclient-pep8/af4b7f0/ : SUCCESS in 2m 21s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/18/208218/1/gate/gate-python-keystoneclient-python27/6bf2cdf/ : SUCCESS in 3m 14s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/18/208218/1/gate/gate-python-keystoneclient-python34/f0cd1e5/ : SUCCESS in 3m 25s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/18/208218/1/gate/gate-tempest-dsvm-neutron-src-python-keystoneclient/929be52/ : SUCCESS in 1h 02m 03s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/18/208218/1/gate/gate-keystoneclient-dsvm-functional/8430466/ : SUCCESS in 30m 43s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/18/208218/1/gate/gate-python-keystoneclient-tox-bandit/3b94a54/ : SUCCESS in 3m 14s","accounts_in_message":[],"_revision_number":1},{"id":"901142203cd8883373ad088330dfb4e873ed9e55","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-03 21:42:39.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"22236fd763ed8d240b254ed54f892fb6fc0f454a","revisions":{"22236fd763ed8d240b254ed54f892fb6fc0f454a":{"kind":"REWORK","_number":1,"created":"2015-08-02 16:25:29.000000000","uploader":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"ref":"refs/changes/18/208218/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/18/208218/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/18/208218/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/18/208218/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/18/208218/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/18/208218/1"}}},"commit":{"parents":[{"commit":"aa5738c23de6b88ff98ad649bef7b023d71a1b02","subject":"Remove check for requests version","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/aa5738c23de6b88ff98ad649bef7b023d71a1b02"}]}],"author":{"name":"Brant Knudson","email":"bknudson@us.ibm.com","date":"2015-08-02 16:22:18.000000000","tz":-300},"committer":{"name":"Brant Knudson","email":"bknudson@us.ibm.com","date":"2015-08-02 16:22:18.000000000","tz":-300},"subject":"Clarify setting socket_options","message":"Clarify setting socket_options\n\nThere was a lot of code that would have no effect if kwargs already\nhad socket_options set. To make the code clearer, only execute the\ncode if it\u0027s going to have an effect.\n\nChange-Id: Ic42f5a0bac07113aff59d36d19293dc6d65cd58a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/22236fd763ed8d240b254ed54f892fb6fc0f454a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/22236fd763ed8d240b254ed54f892fb6fc0f454a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}