)]}'
{"id":"openstack%2Fpython-keystoneclient~21258","triplet_id":"openstack%2Fpython-keystoneclient~master~I0a778849ff44a76a2647aa46057fdb35401fae5f","project":"openstack/python-keystoneclient","branch":"master","topic":"bug/1116740","hashtags":[],"change_id":"I0a778849ff44a76a2647aa46057fdb35401fae5f","subject":"Pin requests module more strictly.","status":"MERGED","created":"2013-02-05 23:02:54.000000000","updated":"2013-02-06 15:12:31.000000000","submitted":"2013-02-06 15:12:31.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2f4f46e0b1f8c161288cf3b9fa9fe4c2e03e428a","_number":21258,"virtual_id_number":21258,"owner":{"_account_id":6039,"name":"Joni Harker","email":"code@gentlydownthe.net","username":"jesusaurus"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2013-02-06 15:12:31.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"value":0,"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"value":0,"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-02-06 13:52:54.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":1,"date":"2013-02-06 08:51:20.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"value":-1,"date":"2013-02-06 14:29:49.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"value":0,"date":"2013-02-06 13:56:36.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-02-06 00:51:05.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"value":0,"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"value":1,"date":"2013-02-06 13:56:36.000000000","_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-02-06 00:51:05.000000000","updated_by":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"reviewer":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"state":"REVIEWER"},{"updated":"2013-02-06 08:51:20.000000000","updated_by":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"reviewer":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"state":"REVIEWER"},{"updated":"2013-02-06 13:56:36.000000000","updated_by":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"reviewer":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"state":"REVIEWER"},{"updated":"2013-02-06 14:29:49.000000000","updated_by":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"reviewer":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"state":"REVIEWER"},{"updated":"2013-02-06 15:12:31.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"410ce7a813da4cd2315dabfefc6139c6b1b52f81","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-05 23:46:31.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/21258/1/check/gate-python-keystoneclient-docs/589 : SUCCESS\n- http://logs.openstack.org/21258/1/check/gate-python-keystoneclient-pep8/733 : SUCCESS\n- http://logs.openstack.org/21258/1/check/gate-python-keystoneclient-python26/663 : SUCCESS\n- http://logs.openstack.org/21258/1/check/gate-python-keystoneclient-python27/667 : SUCCESS\n- http://logs.openstack.org/21258/1/check/gate-tempest-devstack-vm-full/1071 : SUCCESS\n- http://logs.openstack.org/21258/1/check/gate-tempest-devstack-vm-postgres-full/798 : SUCCESS (non-voting)\n- http://logs.openstack.org/21258/1/check/gate-tempest-devstack-vm-quantum/5008 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"201ec46f36e97492831a5c0ea199865956e12dab","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2013-02-06 00:51:05.000000000","message":"Patch Set 1:\n\nI\u0027d like to resolve this catch-22 by fixing keystoneclient rather than bouncing back and forth between two issues... https://review.openstack.org/#/c/21221/\n\n\"Bump the version requirements for requests so it does\nnot conflict with the version of requests required\nfor glance (unpinned).\"","accounts_in_message":[],"_revision_number":1},{"id":"668611ee54a5d154549842e3913524808d396da9","author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"date":"2013-02-06 08:51:20.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nThis is blocking a lot of merges, so I\u0027d rather pin everyone to requests \u003c1.0 while we figure it out. That may mean pinning glance to fix the Glance/python-keystoneclient issue that originally triggered the requirement relax.","accounts_in_message":[],"_revision_number":1},{"id":"d0c6b3c424490dbb36ea0b4631962a301cb1a63c","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2013-02-06 13:52:54.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"781a0cdbe7958fea00303fe17cd7151518e4af50","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-06 13:56:36.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"8f1403fa3481386b62ca56ef9712659a53eceeb4","author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"date":"2013-02-06 13:56:36.000000000","message":"Patch Set 1: Approved\n\n","accounts_in_message":[],"_revision_number":1},{"id":"9a2f5d36a2fb48032057caf73c29b4b6593779cb","author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"date":"2013-02-06 14:29:49.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nThis doesnt fix the problem where glance is using requests version 1.1. I believe I have a more proper fix coming up shortly.","accounts_in_message":[],"_revision_number":1},{"id":"40ed1beb073bcd1f2c6d42de2d5d5d16f302b5ef","author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"date":"2013-02-06 14:53:14.000000000","message":"Patch Set 1:\n\nI think a better solution would be the following:\n\nhttps://review.openstack.org/#/c/21313/","accounts_in_message":[],"_revision_number":1},{"id":"80b9b715184ee9e257321b92d2de1557d8ccd7c1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-06 15:12:31.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1},{"id":"d7eca93ce2a61af5984a664a27d552caa2909726","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-06 15:12:31.000000000","message":"Patch Set 1: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/21258/1/gate/gate-python-keystoneclient-docs/591 : SUCCESS\n- http://logs.openstack.org/21258/1/gate/gate-python-keystoneclient-pep8/735 : SUCCESS\n- http://logs.openstack.org/21258/1/gate/gate-python-keystoneclient-python26/665 : SUCCESS\n- http://logs.openstack.org/21258/1/gate/gate-python-keystoneclient-python27/669 : SUCCESS\n- http://logs.openstack.org/21258/1/gate/gate-tempest-devstack-vm-full/1168 : SUCCESS\n- http://logs.openstack.org/21258/1/gate/gate-tempest-devstack-vm-postgres-full/895 : SUCCESS\n- http://logs.openstack.org/21258/1/gate/gate-tempest-devstack-vm-quantum/5136 : SUCCESS\n","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a564b88e688282a16fcb27b71004576468bf1cf0","revisions":{"a564b88e688282a16fcb27b71004576468bf1cf0":{"kind":"REWORK","_number":1,"created":"2013-02-05 23:02:54.000000000","uploader":{"_account_id":6039,"name":"Joni Harker","email":"code@gentlydownthe.net","username":"jesusaurus"},"ref":"refs/changes/58/21258/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/58/21258/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/58/21258/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/58/21258/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/58/21258/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/58/21258/1"}}},"commit":{"parents":[{"commit":"6cf76c94a5ab74d90b619f2cb9665a5ffeef39fd","subject":"Update requests requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/6cf76c94a5ab74d90b619f2cb9665a5ffeef39fd"}]}],"author":{"name":"K Jonathan Harker","email":"k.jonathan.harker@hp.com","date":"2013-02-05 22:59:49.000000000","tz":-480},"committer":{"name":"K Jonathan Harker","email":"k.jonathan.harker@hp.com","date":"2013-02-05 22:59:49.000000000","tz":-480},"subject":"Pin requests module more strictly.","message":"Pin requests module more strictly.\n\nrequests.request() does not accept the keyword argument \u0027config\u0027\n(used on keystoneclient/client.py:339) after version 1.0.0.\n\nFixes bug #1116740\n\nChange-Id: I0a778849ff44a76a2647aa46057fdb35401fae5f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/a564b88e688282a16fcb27b71004576468bf1cf0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/a564b88e688282a16fcb27b71004576468bf1cf0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}