)]}'
{"id":"openstack%2Fpython-keystoneclient~212819","triplet_id":"openstack%2Fpython-keystoneclient~master~Id0f1cbf5082e10abe0fcb7a887f0b6197ade429e","project":"openstack/python-keystoneclient","branch":"master","topic":"bug/1240163","hashtags":[],"change_id":"Id0f1cbf5082e10abe0fcb7a887f0b6197ade429e","subject":"Shorten PKI Token Identifier to MI","status":"ABANDONED","created":"2015-08-13 22:23:23.000000000","updated":"2015-11-03 04:41:53.000000000","total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"407670ca188403063375a96bbfe6f4d070c17bdf","_number":212819,"virtual_id_number":212819,"owner":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2015-10-16 20:15:47.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},{"value":1,"date":"2015-10-19 09:27:02.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-08-17 02:28:05.000000000","updated_by":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"reviewer":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"state":"REVIEWER"},{"updated":"2015-09-10 16:30:18.000000000","updated_by":{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"},"reviewer":{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"},"state":"REVIEWER"},{"updated":"2015-10-16 15:51:44.000000000","updated_by":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"reviewer":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"state":"REVIEWER"},{"updated":"2015-10-16 20:15:47.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-10-19 09:27:02.000000000","updated_by":{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},"reviewer":{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},"state":"REVIEWER"}],"messages":[{"id":"30c44e6ee59171d05105bf4ce00bd970a8a221b4","author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"date":"2015-08-13 22:23:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c9e54d81fba29fd2264594bf6423b59cb15af0c1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-13 23:44:28.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/19/212819/1/check/gate-python-keystoneclient-python26/94f0dc3/ : SUCCESS in 2m 12s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/19/212819/1/check/gate-python-keystoneclient-pep8/ffc646b/ : SUCCESS in 2m 48s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/19/212819/1/check/gate-python-keystoneclient-docs/d639c80//doc/build/html/ : SUCCESS in 3m 11s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/19/212819/1/check/gate-python-keystoneclient-python27/86a7708/ : SUCCESS in 3m 10s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/19/212819/1/check/gate-python-keystoneclient-python34/4a065d6/ : SUCCESS in 3m 51s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/19/212819/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/82f6526/ : SUCCESS in 1h 16m 46s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/19/212819/1/check/gate-keystoneclient-dsvm-functional/0da6d62/ : SUCCESS in 29m 56s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/19/212819/1/check/gate-python-keystoneclient-tox-bandit/01a2512/ : SUCCESS in 2m 28s","accounts_in_message":[],"_revision_number":1},{"id":"5f645e5d630e664a826c59b9c3f75e9809e5ff70","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2015-08-17 02:28:05.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"5150d521a97043111325884e43cf597c649cf1af","author":{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},"date":"2015-09-03 09:57:46.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nJust a minor nitpick. Looks good to me otherwise.","accounts_in_message":[],"_revision_number":1},{"id":"de304ea3d77e5c8f840015896c3fcc1dc2c326b5","author":{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"},"date":"2015-09-10 16:30:18.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\na test of this would be good","accounts_in_message":[],"_revision_number":1},{"id":"ef6fe3d7b4e2edd5559887a3e3b886ce7584a35a","author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"date":"2015-10-16 15:51:44.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ba9335e4b943802d77d6d5cb24045393309dc80e","author":{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"},"date":"2015-10-16 19:00:53.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"33b640ed29cf4184bdeb8e3084adb72fd7e0beb2","author":{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"},"date":"2015-10-16 19:02:07.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"1e5e11c5dc268bc93c3518bc9ccacc491b57ad11","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-16 20:15:47.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/19/212819/2/check/gate-python-keystoneclient-python26/6fc2639/ : SUCCESS in 2m 31s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/19/212819/2/check/gate-python-keystoneclient-pep8/589fa55/ : SUCCESS in 2m 30s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/19/212819/2/check/gate-python-keystoneclient-docs/780b7b8//doc/build/html/ : SUCCESS in 3m 30s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/19/212819/2/check/gate-python-keystoneclient-python27/68aacf1/ : SUCCESS in 2m 23s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/19/212819/2/check/gate-python-keystoneclient-python34/071d032/ : SUCCESS in 2m 47s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/19/212819/2/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/3fc5bd0/ : SUCCESS in 1h 08m 35s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/19/212819/2/check/gate-keystoneclient-dsvm-functional/f8c47b2/ : SUCCESS in 36m 13s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/19/212819/2/check/gate-python-keystoneclient-tox-bandit/7175a53/ : SUCCESS in 2m 26s","accounts_in_message":[],"_revision_number":2},{"id":"6668980f1b144b841ae329a6bf9fee5d19a1b1f9","author":{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},"date":"2015-10-19 09:27:02.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"fa0a766aefc0cc570453c5eca048b976cacb2331","author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"date":"2015-11-03 04:41:53.000000000","message":"Abandoned\n\nWe should be deprecating the PKI and PKIZ tokens.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"6a35a2adaca550901620501f47aedcad0eff5726","revisions":{"9f0792a2af8d28129abf878a3620516a1400bbe8":{"kind":"REWORK","_number":1,"created":"2015-08-13 22:23:23.000000000","uploader":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"ref":"refs/changes/19/212819/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/19/212819/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/19/212819/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/19/212819/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/19/212819/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/19/212819/1"}}},"commit":{"parents":[{"commit":"2267cbcdd0e7f2331938509009dfe02c40cb443b","subject":"Merge \"Stop using .keys() on dicts where not needed\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/2267cbcdd0e7f2331938509009dfe02c40cb443b"}]}],"author":{"name":"Adam Young","email":"ayoung@redhat.com","date":"2015-08-13 22:19:48.000000000","tz":-240},"committer":{"name":"Adam Young","email":"ayoung@redhat.com","date":"2015-08-13 22:23:19.000000000","tz":-240},"subject":"Shorten PKI Token Identifier to MI","message":"Shorten PKI Token Identifier to MI\n\nUsing a PREFIX of MII the size is limited to about 16000\n\nShortening the check to only MI increases the size of tokens\nto the point where the size will not be possible to fill.\n\nThe drawback is the MI is more likely to get a false positive against any\nblock, including an ASN1 document of different length.  However,\nthis is not a practical issue, as the token would still be rejected.\n\nChange-Id: Id0f1cbf5082e10abe0fcb7a887f0b6197ade429e\nCloses-Bug: 1240163\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/9f0792a2af8d28129abf878a3620516a1400bbe8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/9f0792a2af8d28129abf878a3620516a1400bbe8"}]},"branch":"refs/heads/master"},"6a35a2adaca550901620501f47aedcad0eff5726":{"kind":"REWORK","_number":2,"created":"2015-10-16 19:02:07.000000000","uploader":{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"},"ref":"refs/changes/19/212819/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/19/212819/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/19/212819/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/19/212819/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/19/212819/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/19/212819/2"}}},"commit":{"parents":[{"commit":"8f2aaedfe331181622d86ffb9f522b92c6f26e14","subject":"Merge \"Fix typo that says V3 token only works for v2\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/8f2aaedfe331181622d86ffb9f522b92c6f26e14"}]}],"author":{"name":"Adam Young","email":"ayoung@redhat.com","date":"2015-08-13 22:19:48.000000000","tz":-240},"committer":{"name":"henriquetruta","email":"henrique@lsd.ufcg.edu.br","date":"2015-10-16 19:01:07.000000000","tz":-180},"subject":"Shorten PKI Token Identifier to MI","message":"Shorten PKI Token Identifier to MI\n\nUsing a PREFIX of MII the size is limited to about 16000\n\nShortening the check to only MI increases the size of tokens\nto the point where the size will not be possible to fill.\n\nThe drawback is the MI is more likely to get a false positive against any\nblock, including an ASN1 document of different length.  However,\nthis is not a practical issue, as the token would still be rejected.\n\nCo-Authored-By: Henrique Truta \u003chenrique@lsd.ufcg.edu.br\u003e\n\nChange-Id: Id0f1cbf5082e10abe0fcb7a887f0b6197ade429e\nCloses-Bug: 1240163\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/6a35a2adaca550901620501f47aedcad0eff5726"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/6a35a2adaca550901620501f47aedcad0eff5726"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
