)]}'
{"keystoneclient/tests/unit/v3/test_endpoints.py":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"9e6a43cdf06bbe23a1170e3241e0c03d0f92a67a","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        expected_path \u003d \u0027v3/%s?region_id\u003d%s\u0027 % (self.collection_key, region_id)"},{"line_number":98,"context_line":"        expected_query \u003d {\u0027region_id\u0027: region_id}"},{"line_number":99,"context_line":"        self.test_list(ref_list\u003dref_list, expected_path\u003dexpected_path,"},{"line_number":100,"context_line":"                       expected_query\u003dexpected_query, region\u003dregion_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_1b73d881","line":100,"updated":"2015-08-25 06:00:05.000000000","message":"@Lin, I am still think this should be region_id\u003dregion_id.\nAnd this is acutally the filter we passed into the service API.\n\njust remove expected_query\u003dexpected_query, and run the test, you will find the error.\n\nActually, if expected_query is here, there is no need to pass the kwargs as what you found.\nhttps://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/tests/unit/v3/utils.py#L273-L275","commit_id":"9b2b3e7943bb0564a8de9f629fe2cbfeab65c911"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"44ba17c4470ef76e1f6bc4948d20672c6e35ea8a","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        expected_path \u003d \u0027v3/%s?region_id\u003d%s\u0027 % (self.collection_key, region_id)"},{"line_number":98,"context_line":"        expected_query \u003d {\u0027region_id\u0027: region_id}"},{"line_number":99,"context_line":"        self.test_list(ref_list\u003dref_list, expected_path\u003dexpected_path,"},{"line_number":100,"context_line":"                       expected_query\u003dexpected_query, region\u003dregion_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_bb63cc40","line":100,"in_reply_to":"fa1b9901_1b73d881","updated":"2015-08-25 06:13:10.000000000","message":"@Dave, the region\u003dregion_id goes into the **filter_kwargs of test_list().\n\nand inside test_list(), it will invoke the manager list as: self.manager.list(**filter_kwargs)\n\nAt this point we want to pass \"region\" as argument name,  because EndpointManager.list() exposes this argument, and we want to keep using that.\n\nInside EndpointManager.list(), it calls super(EndpointManager, self).list(region_id\u003dregion), this is what gets passed to the Service API.\n\nexpected_query is used to match against the result returned by the query.","commit_id":"9b2b3e7943bb0564a8de9f629fe2cbfeab65c911"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"19d7b64aaf04540f0dc8d9ff22f63dd8c3fbd8b5","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        expected_path \u003d \u0027v3/%s?region_id\u003d%s\u0027 % (self.collection_key, region_id)"},{"line_number":98,"context_line":"        expected_query \u003d {\u0027region_id\u0027: region_id}"},{"line_number":99,"context_line":"        self.test_list(ref_list\u003dref_list, expected_path\u003dexpected_path,"},{"line_number":100,"context_line":"                       expected_query\u003dexpected_query, region\u003dregion_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_de4b0e58","line":100,"in_reply_to":"fa1b9901_bb63cc40","updated":"2015-08-25 06:23:31.000000000","message":"@Lin, thanks for explaination, make sense to me.","commit_id":"9b2b3e7943bb0564a8de9f629fe2cbfeab65c911"}],"keystoneclient/v3/endpoints.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"341f4d39b3e68be115ff4385c4b3f1b9d2948d71","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        return super(EndpointManager, self).list("},{"line_number":79,"context_line":"            service_id\u003dbase.getid(service),"},{"line_number":80,"context_line":"            interface\u003dinterface,"},{"line_number":81,"context_line":"            region_id\u003dregion,"},{"line_number":82,"context_line":"            enabled\u003denabled,"},{"line_number":83,"context_line":"            **kwargs)"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_13918299","line":81,"updated":"2015-08-25 04:04:17.000000000","message":"shouldn\u0027t this be:\n\n  region_id\u003dbase.getid(region),\n\nthis way we can pass in a region resource object too.","commit_id":"ab1013538fd748f5b4c50100445c519b49591856"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"63328dab81be78ecbfe93acc478f445be508ba25","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        return super(EndpointManager, self).list("},{"line_number":79,"context_line":"            service_id\u003dbase.getid(service),"},{"line_number":80,"context_line":"            interface\u003dinterface,"},{"line_number":81,"context_line":"            region_id\u003dregion,"},{"line_number":82,"context_line":"            enabled\u003denabled,"},{"line_number":83,"context_line":"            **kwargs)"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_33ffe6ab","line":81,"in_reply_to":"fa1b9901_13918299","updated":"2015-08-25 04:16:20.000000000","message":"good point, done","commit_id":"ab1013538fd748f5b4c50100445c519b49591856"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"2438eed8a898ec0b1b06dcea56045b266e2750f0","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        return super(EndpointManager, self).list("},{"line_number":79,"context_line":"            service_id\u003dbase.getid(service),"},{"line_number":80,"context_line":"            interface\u003dinterface,"},{"line_number":81,"context_line":"            region_id\u003dbase.getid(region),"},{"line_number":82,"context_line":"            enabled\u003denabled,"},{"line_number":83,"context_line":"            **kwargs)"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_8f5b1ef6","line":81,"updated":"2015-08-25 07:44:59.000000000","message":"I\u0027m inclined to just ignore the region\u003d parameter \n\nIf you add region_id\u003d and region_name\u003d parameters and mark the old region\u003d parameter deprecated.","commit_id":"9b2b3e7943bb0564a8de9f629fe2cbfeab65c911"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"7460e4e1fcaa36f2b0cbd0780a94e54a42d3aade","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        return super(EndpointManager, self).list("},{"line_number":79,"context_line":"            service_id\u003dbase.getid(service),"},{"line_number":80,"context_line":"            interface\u003dinterface,"},{"line_number":81,"context_line":"            region_id\u003dbase.getid(region),"},{"line_number":82,"context_line":"            enabled\u003denabled,"},{"line_number":83,"context_line":"            **kwargs)"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_338b31c5","line":81,"in_reply_to":"fa1b9901_8f5b1ef6","updated":"2015-08-25 23:49:22.000000000","message":"How about adding region_id in the parameter, and change this line into \n\nregion_id\u003dregion_id or base.getid(region),","commit_id":"9b2b3e7943bb0564a8de9f629fe2cbfeab65c911"}]}