)]}'
{"keystoneclient/middleware/test.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"690fd5645e8f2dfd42e73cd955b1cc4aab3a38a5","unresolved":false,"context_lines":[{"line_number":22,"context_line":"import sys"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"ROOTDIR \u003d os.path.dirname(os.path.abspath(os.curdir))"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def rootdir(*p):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2B8HM%3D","side":"PARENT","line":25,"updated":"2013-02-13 20:49:50.000000000","message":"did you consider calculating directory relative to __file__ rather than os.curdir?\n\n os.path.dirname(os.path.abspath(__file__))\n\nit might be more flexible because then could run from any directory.","commit_id":"acdba5ee521fb2a08a338587bb81e25023ee94f9"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"2ee37bda302123987266b51c04318b5613eca4a7","unresolved":false,"context_lines":[{"line_number":22,"context_line":"import sys"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"ROOTDIR \u003d os.path.dirname(os.path.abspath(os.curdir))"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def rootdir(*p):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2B7YY%3D","side":"PARENT","line":25,"in_reply_to":"AAAAM3%2F%2B8HM%3D","updated":"2013-02-14 04:08:15.000000000","message":"I\u0027m guessing it was originally written that way, but unfortunately I don\u0027t think run_tests.sh supports being executed from anywhere anyway (at least, I can\u0027t get it to work).\n\nPretty sure you\u0027d also have to call dirname() on __file__ three times to get to the project\u0027s directory, as well?","commit_id":"acdba5ee521fb2a08a338587bb81e25023ee94f9"}],"tests/test_auth_token_middleware.py":[{"author":{"_account_id":6456,"name":"Sahdev Zala","email":"spzala@us.ibm.com","username":"spzala"},"change_message_id":"01596bbb7fdf5a3eb0f2a4413d0d23a4dc9af685","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"CERTDIR \u003d test.rootdir(\"python-keystoneclient/examples/pki/certs\")"},{"line_number":36,"context_line":"KEYDIR \u003d test.rootdir(\"python-keystoneclient/examples/pki/private\")"},{"line_number":37,"context_line":"CMSDIR \u003d test.rootdir(\"python-keystoneclient/examples/pki/cms\")"},{"line_number":38,"context_line":"SIGNING_CERT \u003d os.path.join(CERTDIR, \u0027signing_cert.pem\u0027)"},{"line_number":39,"context_line":"SIGNING_KEY \u003d os.path.join(KEYDIR, \u0027signing_key.pem\u0027)"},{"line_number":40,"context_line":"CA \u003d os.path.join(CERTDIR, \u0027ca.pem\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2B6lU%3D","side":"PARENT","line":37,"updated":"2013-02-14 16:29:55.000000000","message":"Hi Dolph, yesterday I downloaded latest code and in the test_auth_token_middleware.py I have \nCERTDIR \u003d test.rootdir(\"examples/pki/certs\")\nKEYDIR \u003d test.rootdir(\"examples/pki/private\")\nCMSDIR \u003d test.rootdir(\"examples/pki/cms\")\nwhere it seems like the issue of hard coded path to the examples is already taken care. \nI also reviewed another bug (https://review.openstack.org/#/c/21964/) this morning (where I could reproduce the problem and verify the fix) which has changes for the same file tests/test_auth_token_middleware.py and I see the content is same as I have. \nSo I am wondering of this behavior and that if there is any overlapping going on..? Thanks!","commit_id":"acdba5ee521fb2a08a338587bb81e25023ee94f9"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"32c41c86064886c9999ab04d9e97b671af4073e6","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"CERTDIR \u003d test.rootdir(\"python-keystoneclient/examples/pki/certs\")"},{"line_number":36,"context_line":"KEYDIR \u003d test.rootdir(\"python-keystoneclient/examples/pki/private\")"},{"line_number":37,"context_line":"CMSDIR \u003d test.rootdir(\"python-keystoneclient/examples/pki/cms\")"},{"line_number":38,"context_line":"SIGNING_CERT \u003d os.path.join(CERTDIR, \u0027signing_cert.pem\u0027)"},{"line_number":39,"context_line":"SIGNING_KEY \u003d os.path.join(KEYDIR, \u0027signing_key.pem\u0027)"},{"line_number":40,"context_line":"CA \u003d os.path.join(CERTDIR, \u0027ca.pem\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2B6YU%3D","side":"PARENT","line":37,"in_reply_to":"AAAAM3%2F%2B6lU%3D","updated":"2013-02-14 17:49:28.000000000","message":"hmm... i did see a similar change in review a while back, but as a i remember it was part of a larger change and was abandoned... just rebased and that doesn\u0027t appear to be the case? are you looking in keystone or keystoneclient? these same tests remain in keystone but have diverged a bit","commit_id":"acdba5ee521fb2a08a338587bb81e25023ee94f9"}]}