)]}'
{"id":"openstack%2Fpython-keystoneclient~219004","triplet_id":"openstack%2Fpython-keystoneclient~master~Ifd95d3fb624b4636fb72cc11762af62e00a026a0","project":"openstack/python-keystoneclient","branch":"master","topic":"bug/1490693","hashtags":[],"change_id":"Ifd95d3fb624b4636fb72cc11762af62e00a026a0","subject":"Mask passwords when logging the HTTP response","status":"MERGED","created":"2015-08-31 19:49:48.000000000","updated":"2015-10-09 15:09:38.000000000","submitted":"2015-09-03 20:29:08.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"17a3a46b2895999c1d4691789b1a831b880c3b1e","_number":219004,"virtual_id_number":219004,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2015-09-03 20:29:08.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2015-09-03 17:15:26.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":0,"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"value":0,"date":"2015-08-31 21:30:17.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":2,"date":"2015-08-31 21:32:15.000000000","_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":2,"date":"2015-09-03 07:01:48.000000000","_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2015-09-02 09:54:36.000000000","_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":1,"date":"2015-09-03 07:01:48.000000000","_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-08-31 21:32:15.000000000","updated_by":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"reviewer":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"state":"REVIEWER"},{"updated":"2015-09-02 09:54:36.000000000","updated_by":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"reviewer":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"state":"REVIEWER"},{"updated":"2015-09-03 07:01:48.000000000","updated_by":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"reviewer":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"state":"REVIEWER"},{"updated":"2015-09-03 17:15:26.000000000","updated_by":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"reviewer":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"state":"REVIEWER"},{"updated":"2015-09-03 20:29:08.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"c5372d1f801663396bb47eb78c541f0a74d9b83d","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-08-31 19:49:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1658b1f9e8b98022ec880963adcf8292f215c832","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2015-08-31 20:32:08.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"3c1b6e0c2898cf4de8c17e85366a055305c327e5","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-08-31 21:30:17.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"364e92f63b3035479f03b4f68740c6cb13c51b71","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2015-08-31 21:32:15.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)\n\nThanks!","accounts_in_message":[],"_revision_number":1},{"id":"fdbf69a90c40c85fbdc464e3a85103e61abd2535","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-31 21:43:53.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/04/219004/1/check/gate-python-keystoneclient-python26/ec1a70f/ : SUCCESS in 2m 21s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/04/219004/1/check/gate-python-keystoneclient-pep8/b3504b4/ : SUCCESS in 2m 27s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/04/219004/1/check/gate-python-keystoneclient-docs/4517d47//doc/build/html/ : SUCCESS in 2m 00s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/04/219004/1/check/gate-python-keystoneclient-python27/c5c397c/ : SUCCESS in 2m 48s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/04/219004/1/check/gate-python-keystoneclient-python34/11817b1/ : SUCCESS in 3m 38s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/04/219004/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/011986c/ : SUCCESS in 1h 07m 40s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/04/219004/1/check/gate-keystoneclient-dsvm-functional/1630b5f/ : SUCCESS in 29m 24s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/04/219004/1/check/gate-python-keystoneclient-tox-bandit/7c45c70/ : SUCCESS in 2m 02s","accounts_in_message":[],"_revision_number":1},{"id":"6b5930a8899247fa88b7b85638af3908dd7e17a2","author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"date":"2015-09-02 09:54:36.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"0f560dff15e277fa6e2c0fff16efbe6344dcaa46","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2015-09-03 07:01:48.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"1bd983aea074c98f08da9796b045351d69da0bf9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-03 07:01:54.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"b822767b469652d8d38705f20ff5a544232537ee","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-03 08:14:03.000000000","message":"Patch Set 1: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/04/219004/1/gate/gate-python-keystoneclient-python26/5c863d3/ : SUCCESS in 2m 43s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/04/219004/1/gate/gate-python-keystoneclient-docs/acc601e//doc/build/html/ : SUCCESS in 3m 23s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/04/219004/1/gate/gate-python-keystoneclient-pep8/952cbe3/ : SUCCESS in 2m 25s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/04/219004/1/gate/gate-python-keystoneclient-python27/04693e7/ : SUCCESS in 4m 00s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/04/219004/1/gate/gate-python-keystoneclient-python34/108a28b/ : SUCCESS in 3m 22s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/04/219004/1/gate/gate-tempest-dsvm-neutron-src-python-keystoneclient/bec1838/ : SUCCESS in 1h 09m 58s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/04/219004/1/gate/gate-keystoneclient-dsvm-functional/bac7103/ : FAILURE in 21m 27s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/04/219004/1/gate/gate-python-keystoneclient-tox-bandit/d3484a8/ : SUCCESS in 2m 41s","accounts_in_message":[],"_revision_number":1},{"id":"a333af40deecc87b58070e4248e7b115023aadb8","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2015-09-03 17:15:26.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"a57e76a001c23e3e4e8779d1b438105d0f1efece","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-03 18:58:50.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/04/219004/1/check/gate-python-keystoneclient-python26/0d5eec4/ : SUCCESS in 2m 04s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/04/219004/1/check/gate-python-keystoneclient-pep8/3a3f280/ : SUCCESS in 2m 44s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/04/219004/1/check/gate-python-keystoneclient-docs/1bdb309//doc/build/html/ : SUCCESS in 4m 04s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/04/219004/1/check/gate-python-keystoneclient-python27/ea3be00/ : SUCCESS in 2m 47s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/04/219004/1/check/gate-python-keystoneclient-python34/4cde6f7/ : SUCCESS in 4m 21s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/04/219004/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/171d185/ : SUCCESS in 1h 13m 00s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/04/219004/1/check/gate-keystoneclient-dsvm-functional/5ed83ca/ : SUCCESS in 30m 10s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/04/219004/1/check/gate-python-keystoneclient-tox-bandit/0393eff/ : SUCCESS in 2m 45s","accounts_in_message":[],"_revision_number":1},{"id":"c0c556a83830f7dcf023eced8cdf3dc01e1efc51","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-03 18:58:55.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"28d552341ec3e0f1d85ab668f22c6d0662aad419","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-03 20:29:08.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/04/219004/1/gate/gate-python-keystoneclient-python26/a84de0e/ : SUCCESS in 2m 30s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/04/219004/1/gate/gate-python-keystoneclient-docs/a7daeab//doc/build/html/ : SUCCESS in 2m 45s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/04/219004/1/gate/gate-python-keystoneclient-pep8/06b6769/ : SUCCESS in 2m 43s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/04/219004/1/gate/gate-python-keystoneclient-python27/a0968a7/ : SUCCESS in 3m 14s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/04/219004/1/gate/gate-python-keystoneclient-python34/585caed/ : SUCCESS in 3m 30s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/04/219004/1/gate/gate-tempest-dsvm-neutron-src-python-keystoneclient/2ec0fd6/ : SUCCESS in 1h 18m 07s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/04/219004/1/gate/gate-keystoneclient-dsvm-functional/8976adc/ : SUCCESS in 30m 46s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/04/219004/1/gate/gate-python-keystoneclient-tox-bandit/009956a/ : SUCCESS in 2m 42s","accounts_in_message":[],"_revision_number":1},{"id":"eb1d000001dd5d43db9fbc1dab4165278b1c68b0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-03 20:29:09.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1},{"id":"4d3ddce63cdd6e47456890d5466abd82728700ed","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-10-09 15:09:38.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/kilo as commit 4abb48289c969140a2d308205f218e5f2b5a67dc","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"3e26ff824801d5084791a52980021784e794e35f","revisions":{"3e26ff824801d5084791a52980021784e794e35f":{"kind":"REWORK","_number":1,"created":"2015-08-31 19:49:48.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/04/219004/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/04/219004/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/04/219004/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/04/219004/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/04/219004/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/04/219004/1"}}},"commit":{"parents":[{"commit":"ee6d64a8fb96756abd4d85aa50f7842104602328","subject":"Merge \"Fix Accept header in SAML2 requests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/ee6d64a8fb96756abd4d85aa50f7842104602328"}]}],"author":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2015-08-31 19:32:25.000000000","tz":-420},"committer":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2015-08-31 19:49:34.000000000","tz":-420},"subject":"Mask passwords when logging the HTTP response","message":"Mask passwords when logging the HTTP response\n\nWe should sanitize the response body before logging to make sure we\naren\u0027t leaking through credentials like in the case of the response from\nthe os-initialize_connection volume API.\n\nCloses-Bug: #1490693\n\nChange-Id: Ifd95d3fb624b4636fb72cc11762af62e00a026a0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/3e26ff824801d5084791a52980021784e794e35f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/3e26ff824801d5084791a52980021784e794e35f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}