)]}'
{"id":"openstack%2Fpython-keystoneclient~221855","triplet_id":"openstack%2Fpython-keystoneclient~master~Idf6ffa59e2db39e0e1980bff1d8ad5861b0bfd16","project":"openstack/python-keystoneclient","branch":"master","topic":"bug/1492600","hashtags":[],"change_id":"Idf6ffa59e2db39e0e1980bff1d8ad5861b0bfd16","subject":"Revert \"Adding back exception mapping for ConnectionError\"","status":"ABANDONED","created":"2015-09-09 15:54:15.000000000","updated":"2015-09-09 21:49:55.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"fd6157eb011ff5c4db33430d310fe14fb8823ba1","_number":221855,"virtual_id_number":221855,"owner":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2015-09-09 17:32:56.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"date":"2015-09-09 21:49:55.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2015-09-09 17:14:50.000000000","_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":-1,"date":"2015-09-09 16:27:51.000000000","_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-09-09 16:27:51.000000000","updated_by":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"reviewer":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"state":"REVIEWER"},{"updated":"2015-09-09 17:14:50.000000000","updated_by":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"reviewer":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"state":"REVIEWER"},{"updated":"2015-09-09 17:32:56.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"9c3751b047603229e0756679188ba9f534a0c83e","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-09-09 15:54:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a85ce27a332ce56c593b95b15953b3ea033004e9","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2015-09-09 16:27:51.000000000","message":"Patch Set 1: Workflow-1\n\nHolding WIP until we\u0027re sure this is the best course vs incremental changes on top.","accounts_in_message":[],"_revision_number":1},{"id":"c75eb8c1dc98834249b456911dff5974e4178611","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-09 17:32:56.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/55/221855/1/check/gate-python-keystoneclient-python26/65e972c/ : SUCCESS in 2m 26s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/55/221855/1/check/gate-python-keystoneclient-pep8/e783e5b/ : SUCCESS in 2m 38s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/55/221855/1/check/gate-python-keystoneclient-docs/cec5173//doc/build/html/ : SUCCESS in 3m 13s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/55/221855/1/check/gate-python-keystoneclient-python27/59ec625/ : SUCCESS in 3m 12s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/55/221855/1/check/gate-python-keystoneclient-python34/2b28386/ : SUCCESS in 2m 40s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/55/221855/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/8120002/ : SUCCESS in 1h 25m 25s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/55/221855/1/check/gate-keystoneclient-dsvm-functional/96b1ca3/ : SUCCESS in 31m 24s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/55/221855/1/check/gate-python-keystoneclient-tox-bandit/7385f9a/ : SUCCESS in 2m 15s","accounts_in_message":[],"_revision_number":1},{"id":"ac9de15da82e30dd0c00a2e80373dd3bd25e71da","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-09-09 17:56:35.000000000","message":"Abandoned\n\nChanged my mind I\u0027m ok with the change.","accounts_in_message":[],"_revision_number":1},{"id":"094e1feb07802e5dfdef649b4892ac4ab907e249","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-09-09 21:06:34.000000000","message":"Patch Set 1:\n\nhey Brant, curious what made you change your mind here?","accounts_in_message":[],"_revision_number":1},{"id":"46775e5ceb9c215c720205cb0c5da2396d55e115","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-09-09 21:49:55.000000000","message":"Patch Set 1:\n\nBefore I broke things:\n\nkeystoneclient/exceptions.py:\n\nfrom keystoneclient.openstack.common.apiclient.exceptions import *\n(defines ConnectionError and ConnectionRefused)\n\nConnectionError \u003d ConnectionRefused\n\n(so keystoneclient/exceptions.py wound up reassigning ConnectionError)\n\n\nkeystoneclient/openstack/common/apiclient/exceptions.py:\n\nclass ConnectionError(ClientException)\n\nclass ConnectionRefused(ConnectionError)\n\n\nNow we have:\n\n\nkeystoneclient/openstack/common/apiclient/exceptions.py:\n\nConnectionError \u003d exceptions.ConnectionError\nConnectionRefused \u003d exceptions.ConnectionRefused\n\n\nkeystoneclient/exceptions.py:\n\n\nclass ConnectionError(ClientException):\n\n\nclass ConnectionRefused(ConnectionError):\n\n-----\n\nI can\u0027t think of a good way to have things actually not breaking, so let\u0027s just go with what we\u0027ve got.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"bf335d7a1469ff2092b1fc896b5ee4e70ed67254","revisions":{"bf335d7a1469ff2092b1fc896b5ee4e70ed67254":{"kind":"REWORK","_number":1,"created":"2015-09-09 15:54:15.000000000","uploader":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"ref":"refs/changes/55/221855/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/55/221855/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/55/221855/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/55/221855/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/55/221855/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/55/221855/1"}}},"commit":{"parents":[{"commit":"28138b588224c6b0503620ac2e24bd37dad25370","subject":"Merge \"Adding back exception mapping for ConnectionError\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/28138b588224c6b0503620ac2e24bd37dad25370"}]}],"author":{"name":"Brant Knudson","email":"bknudson@us.ibm.com","date":"2015-09-09 15:49:47.000000000","tz":-300},"committer":{"name":"Brant Knudson","email":"bknudson@us.ibm.com","date":"2015-09-09 15:52:51.000000000","tz":-300},"subject":"Revert \"Adding back exception mapping for ConnectionError\"","message":"Revert \"Adding back exception mapping for ConnectionError\"\n\nThis reverts commit c45fd909c37eabe6e3391304f539003aa3bbff2d.\n\nThis change defined ConnectionError \u003d ConnectionRefused, but\nthere\u0027s already a class ConnectionError defined, so the new\nConnectionError is masking the original ConnectionError.\n\nChange-Id: Idf6ffa59e2db39e0e1980bff1d8ad5861b0bfd16\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/bf335d7a1469ff2092b1fc896b5ee4e70ed67254"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/bf335d7a1469ff2092b1fc896b5ee4e70ed67254"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}