)]}'
{"id":"openstack%2Fpython-keystoneclient~223946","triplet_id":"openstack%2Fpython-keystoneclient~master~I243c4803522e6bf9ad84ba0464eae523c5ff05d8","project":"openstack/python-keystoneclient","branch":"master","topic":"add-authorization_code-support","hashtags":[],"change_id":"I243c4803522e6bf9ad84ba0464eae523c5ff05d8","subject":"Add support for grant_type \"authorization_code\"","status":"ABANDONED","created":"2015-09-16 07:23:30.000000000","updated":"2015-09-18 06:45:51.000000000","total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"095e958d9186d9cffc2011e826f3527fc0101bcd","_number":223946,"virtual_id_number":223946,"owner":{"_account_id":11206,"name":"Zhao Jian","email":"jianzj@cn.ibm.com","username":"Eric_Zhao"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":-1,"date":"2015-09-17 02:44:42.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"date":"2015-09-18 03:10:10.000000000","_account_id":11206,"name":"Zhao Jian","email":"jianzj@cn.ibm.com","username":"Eric_Zhao"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"all":[{"value":-1,"date":"2015-09-17 20:39:12.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2015-09-17 12:51:18.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11206,"name":"Zhao Jian","email":"jianzj@cn.ibm.com","username":"Eric_Zhao"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":11206,"name":"Zhao Jian","email":"jianzj@cn.ibm.com","username":"Eric_Zhao"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":11206,"name":"Zhao Jian","email":"jianzj@cn.ibm.com","username":"Eric_Zhao"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-09-17 02:44:42.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-09-17 12:51:18.000000000","updated_by":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"reviewer":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"state":"REVIEWER"},{"updated":"2015-09-17 20:39:12.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"}],"messages":[{"id":"eaa48d510dda13bccb2b9766a25c110931ac9643","author":{"_account_id":11206,"name":"Zhao Jian","email":"jianzj@cn.ibm.com","username":"Eric_Zhao"},"date":"2015-09-16 07:23:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"21b1e1805ad426067c25ebac182a40b53fbd2ddc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-16 08:41:56.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/46/223946/1/check/gate-python-keystoneclient-python26/21bf2b9/ : FAILURE in 2m 19s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/46/223946/1/check/gate-python-keystoneclient-pep8/3ff8c87/ : FAILURE in 1m 50s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/46/223946/1/check/gate-python-keystoneclient-docs/2fc2055//doc/build/html/ : SUCCESS in 3m 00s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/46/223946/1/check/gate-python-keystoneclient-python27/713d0c5/ : FAILURE in 3m 08s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/46/223946/1/check/gate-python-keystoneclient-python34/1eefb47/ : FAILURE in 3m 13s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/46/223946/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/2c62a1c/ : SUCCESS in 1h 18m 19s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/46/223946/1/check/gate-keystoneclient-dsvm-functional/c08aac0/ : SUCCESS in 33m 19s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/46/223946/1/check/gate-python-keystoneclient-tox-bandit/435e2ad/ : SUCCESS in 2m 13s","accounts_in_message":[],"_revision_number":1},{"id":"9353307575eeb42815c26aaf2705c78e0088a25c","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-09-16 18:28:47.000000000","message":"Patch Set 1:\n\nthat\u0027s funny, i was just going to start writing the code for this, thanks for looking at it! I\u0027ll review it soon.","accounts_in_message":[],"_revision_number":1},{"id":"05330aa2904ea20294b67487444c55da531eb94a","author":{"_account_id":11206,"name":"Zhao Jian","email":"jianzj@cn.ibm.com","username":"Eric_Zhao"},"date":"2015-09-17 01:26:04.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ec11e44353dd11a5e0359c4c8eee573f474a3209","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-17 02:44:42.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/46/223946/2/check/gate-python-keystoneclient-python26/074a609/ : FAILURE in 2m 21s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/46/223946/2/check/gate-python-keystoneclient-pep8/e9e692b/ : FAILURE in 1m 55s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/46/223946/2/check/gate-python-keystoneclient-docs/eff2396//doc/build/html/ : SUCCESS in 2m 55s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/46/223946/2/check/gate-python-keystoneclient-python27/6a078de/ : FAILURE in 2m 07s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/46/223946/2/check/gate-python-keystoneclient-python34/71b902c/ : FAILURE in 3m 01s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/46/223946/2/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/c3a1337/ : SUCCESS in 1h 18m 30s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/46/223946/2/check/gate-keystoneclient-dsvm-functional/3d194b6/ : SUCCESS in 20m 44s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/46/223946/2/check/gate-python-keystoneclient-tox-bandit/a29592a/ : SUCCESS in 2m 17s","accounts_in_message":[],"_revision_number":2},{"id":"d92c39d3d73932b7712d80a49e606e3ff924a17f","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2015-09-17 12:51:18.000000000","message":"Patch Set 2: Code-Review-1\n\n(2 comments)\n\nA few comments on the commit message to get you going. Thanks for the patch!","accounts_in_message":[],"_revision_number":2},{"id":"de5c97b06384de8de13672de4fe9d8eefc118b4d","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-09-17 20:39:12.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)\n\ni think we want to separate plugins ... OidcPassword and OidcAuthorizationCode\n\nThere should ideally be a common class for these two OidcBase that does all the common handling.\n\nThis looks really good though, thanks for working on this!","accounts_in_message":[],"_revision_number":2},{"id":"5da38180f944be550f6bacb8bca06222acdd9029","author":{"_account_id":11206,"name":"Zhao Jian","email":"jianzj@cn.ibm.com","username":"Eric_Zhao"},"date":"2015-09-18 03:10:10.000000000","message":"Patch Set 2:\n\nHi Steve and Dolph, thanks for your suggestion and guidance, and I will do it right now.\n\nBy the way, based on my experiment, after we send a post request to OpenID Connect Provider with suitable authentication or authorization parameters, we will get a response with access_token and id_token.\n\nWe could get claims with a get request with \"OIDCOAuthIntorspectionEndpoint\" and query_string is \"access_token\" or \"id_token\", return data may be a little different, so I just add one parameter named \"self.access_token_type\", this may lead to different configuration in wsgi_keystone.conf. \n\nJust list it, in case you needed.","accounts_in_message":[],"_revision_number":2},{"id":"8862834a4a6561e6a8260358dcc118f734ef6d0e","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-09-18 05:55:55.000000000","message":"Patch Set 2:\n\ni like this work, but we should place all future plugins into the keystoneauth repo - i\u0027ve started a new patch to migrate the existing code + this new stuff over: https://review.openstack.org/#/c/224993/","accounts_in_message":[],"_revision_number":2},{"id":"2be725d69e08f11eabb6520769f5cc05ae3dee89","author":{"_account_id":11206,"name":"Zhao Jian","email":"jianzj@cn.ibm.com","username":"Eric_Zhao"},"date":"2015-09-18 06:44:53.000000000","message":"Patch Set 2:\n\nyeah, feel free to do this.","accounts_in_message":[],"_revision_number":2},{"id":"92efab97da1d25532d5ee7022fca7df07ed77450","author":{"_account_id":11206,"name":"Zhao Jian","email":"jianzj@cn.ibm.com","username":"Eric_Zhao"},"date":"2015-09-18 06:45:51.000000000","message":"Abandoned\n\nSince new changes have been moved into https://review.openstack.org/#/c/224993/ , please go there to trace this bug. I abandoned this change.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"46e856a875866e3abcaf19cf3e90c09b588b7d6c","revisions":{"76297c251d2fbd35fbcc3406bbe9c7439837478f":{"kind":"REWORK","_number":1,"created":"2015-09-16 07:23:30.000000000","uploader":{"_account_id":11206,"name":"Zhao Jian","email":"jianzj@cn.ibm.com","username":"Eric_Zhao"},"ref":"refs/changes/46/223946/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/46/223946/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/223946/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/223946/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/223946/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/223946/1"}}},"commit":{"parents":[{"commit":"459574441971bf6f8ff89414c602db1f273f4fdd","subject":"Merge \"Identity plugin thread safety\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/459574441971bf6f8ff89414c602db1f273f4fdd"}]}],"author":{"name":"Zhao_Jian","email":"jianzj@cn.ibm.com","date":"2015-09-16 06:20:30.000000000","tz":480},"committer":{"name":"Zhao_Jian","email":"jianzj@cn.ibm.com","date":"2015-09-16 06:20:30.000000000","tz":480},"subject":"Add support for grant_type \"authorization_code\"","message":"Add support for grant_type \"authorization_code\"\n\nThis is the prototype code for supporting grant_type \"authorization_\ncode\" when we use OpenID Connect as Idp to continue OpenStack work.\n\nChange-Id: I243c4803522e6bf9ad84ba0464eae523c5ff05d8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/76297c251d2fbd35fbcc3406bbe9c7439837478f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/76297c251d2fbd35fbcc3406bbe9c7439837478f"}]},"branch":"refs/heads/master"},"46e856a875866e3abcaf19cf3e90c09b588b7d6c":{"kind":"REWORK","_number":2,"created":"2015-09-17 01:26:04.000000000","uploader":{"_account_id":11206,"name":"Zhao Jian","email":"jianzj@cn.ibm.com","username":"Eric_Zhao"},"ref":"refs/changes/46/223946/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/46/223946/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/223946/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/223946/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/223946/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/46/223946/2"}}},"commit":{"parents":[{"commit":"459574441971bf6f8ff89414c602db1f273f4fdd","subject":"Merge \"Identity plugin thread safety\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/459574441971bf6f8ff89414c602db1f273f4fdd"}]}],"author":{"name":"Zhao_Jian","email":"jianzj@cn.ibm.com","date":"2015-09-16 06:20:30.000000000","tz":480},"committer":{"name":"Zhao_Jian","email":"jianzj@cn.ibm.com","date":"2015-09-17 01:24:43.000000000","tz":480},"subject":"Add support for grant_type \"authorization_code\"","message":"Add support for grant_type \"authorization_code\"\n\nThis is the prototype code for supporting grant_type \"authorization_\ncode\" when we use OpenID Connect as Idp to continue OpenStack work.\n\nChange-Id: I243c4803522e6bf9ad84ba0464eae523c5ff05d8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/46e856a875866e3abcaf19cf3e90c09b588b7d6c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/46e856a875866e3abcaf19cf3e90c09b588b7d6c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}