)]}'
{"id":"openstack%2Fpython-keystoneclient~227691","triplet_id":"openstack%2Fpython-keystoneclient~master~I83d04a71e030f3904c84cead4659c230393631db","project":"openstack/python-keystoneclient","branch":"master","topic":"list-cleanup","hashtags":[],"change_id":"I83d04a71e030f3904c84cead4659c230393631db","subject":"List creation could be rewritten as a list literal","status":"MERGED","created":"2015-09-25 06:48:43.000000000","updated":"2015-10-07 18:05:26.000000000","submitted":"2015-10-07 18:05:25.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7fcf504b0570262ea010a45bb0a6079f3b6ff32a","_number":227691,"virtual_id_number":227691,"owner":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2015-10-07 18:05:25.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2015-09-25 15:51:35.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-10-07 16:48:10.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-10-07 16:48:10.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-09-25 15:51:35.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2015-10-07 16:48:10.000000000","updated_by":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"reviewer":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"state":"REVIEWER"},{"updated":"2015-10-07 18:05:25.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"02c9328521ea861053b2605e5421d31c9b1fe9a3","author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"date":"2015-09-25 06:48:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"225e73257b78e8d227fdd72ff805a3bae2e56388","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-25 07:59:35.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/91/227691/1/check/gate-python-keystoneclient-python26/d378cb5/ : SUCCESS in 2m 29s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/91/227691/1/check/gate-python-keystoneclient-pep8/5f77454/ : SUCCESS in 2m 33s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/91/227691/1/check/gate-python-keystoneclient-docs/60c6df7//doc/build/html/ : SUCCESS in 2m 32s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/91/227691/1/check/gate-python-keystoneclient-python27/ca34fd5/ : SUCCESS in 3m 08s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/91/227691/1/check/gate-python-keystoneclient-python34/066305e/ : FAILURE in 3m 31s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/91/227691/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/7c283a6/ : SUCCESS in 1h 10m 45s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/91/227691/1/check/gate-keystoneclient-dsvm-functional/c605394/ : SUCCESS in 32m 50s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/91/227691/1/check/gate-python-keystoneclient-tox-bandit/00b4979/ : SUCCESS in 2m 37s","accounts_in_message":[],"_revision_number":1},{"id":"c33e334f98405074a00560877a07270d02b74c32","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-09-25 15:51:35.000000000","message":"Patch Set 1: Code-Review+2\n\nsure, i suppose","accounts_in_message":[],"_revision_number":1},{"id":"a59bb23dfdfc0efee94421556cc2909615823168","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-09-28 21:23:24.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"af0f3f00db87037a9e1d37825ff07e6c25d4d3d3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-28 22:25:40.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/91/227691/1/check/gate-python-keystoneclient-python26/275cdd8/ : SUCCESS in 2m 23s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/91/227691/1/check/gate-python-keystoneclient-pep8/16a6854/ : SUCCESS in 2m 48s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/91/227691/1/check/gate-python-keystoneclient-docs/f6fe802//doc/build/html/ : SUCCESS in 3m 48s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/91/227691/1/check/gate-python-keystoneclient-python27/ccd205a/ : SUCCESS in 2m 14s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/91/227691/1/check/gate-python-keystoneclient-python34/727032d/ : SUCCESS in 3m 44s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/91/227691/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/1ff8f29/ : SUCCESS in 1h 02m 09s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/91/227691/1/check/gate-keystoneclient-dsvm-functional/bf0ec5f/ : SUCCESS in 34m 51s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/91/227691/1/check/gate-python-keystoneclient-tox-bandit/ca8cb32/ : SUCCESS in 2m 38s","accounts_in_message":[],"_revision_number":1},{"id":"aa8566f1b1718c42e89c5d38386bee747c05871a","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2015-10-07 16:48:10.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n++Trivial but not sure about \"Fix\"","accounts_in_message":[],"_revision_number":1},{"id":"ca635f7fae8c1066e8a6bbed9ad05a967ab3636b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-07 16:48:16.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"69c197a8dd3a44d26c5ba5c297733fee324c5b38","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-07 18:05:25.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/91/227691/1/gate/gate-python-keystoneclient-python26/d89effc/ : SUCCESS in 2m 24s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/91/227691/1/gate/gate-python-keystoneclient-docs/3a8301b//doc/build/html/ : SUCCESS in 2m 23s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/91/227691/1/gate/gate-python-keystoneclient-pep8/8f0e55d/ : SUCCESS in 2m 07s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/91/227691/1/gate/gate-python-keystoneclient-python27/225d4e0/ : SUCCESS in 2m 26s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/91/227691/1/gate/gate-python-keystoneclient-python34/5be87bb/ : SUCCESS in 3m 01s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/91/227691/1/gate/gate-tempest-dsvm-neutron-src-python-keystoneclient/6e63f72/ : SUCCESS in 1h 13m 56s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/91/227691/1/gate/gate-keystoneclient-dsvm-functional/d0f154a/ : SUCCESS in 28m 52s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/91/227691/1/gate/gate-python-keystoneclient-tox-bandit/28a0028/ : SUCCESS in 3m 04s","accounts_in_message":[],"_revision_number":1},{"id":"99d353b39d7ab5ae583bec8d7629cc8b1390cd53","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-07 18:05:26.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f00156ea9adb7675e453e64acc3cf470bfd6a6c3","revisions":{"f00156ea9adb7675e453e64acc3cf470bfd6a6c3":{"kind":"REWORK","_number":1,"created":"2015-09-25 06:48:43.000000000","uploader":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"ref":"refs/changes/91/227691/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/91/227691/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/91/227691/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/91/227691/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/91/227691/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/91/227691/1"}}},"commit":{"parents":[{"commit":"8cf0b8fe582530bb1c9379b1a8b6e293ab976e10","subject":"Change ignore-errors to ignore_errors","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/8cf0b8fe582530bb1c9379b1a8b6e293ab976e10"}]}],"author":{"name":"Ankit Agrawal","email":"ankit11.agrawal@nttdata.com","date":"2015-09-24 13:59:12.000000000","tz":-420},"committer":{"name":"Ankit Agrawal","email":"ankit11.agrawal@nttdata.com","date":"2015-09-24 13:59:12.000000000","tz":-420},"subject":"List creation could be rewritten as a list literal","message":"List creation could be rewritten as a list literal\n\nIn _http_log_response method of session.py module,\nlist \"string_parts\u0027 is created as below.\n\nstring_parts \u003d [\u0027RESP:\u0027]\nstring_parts.append(\u0027[%s]\u0027 % response.status_code)\n\nCould be rewritten as\n\nstring_parts \u003d [\n    \u0027RESP:\u0027,\n    \u0027[%s]\u0027 % response.status_code\n]\n\nTrivialFix\n\nChange-Id: I83d04a71e030f3904c84cead4659c230393631db\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/f00156ea9adb7675e453e64acc3cf470bfd6a6c3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/f00156ea9adb7675e453e64acc3cf470bfd6a6c3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}