)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"8e5f18e1282870c82ca079c0ba660ff466d2aadd","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Using a mutable type implies that it\u0027s acceptable for the set of"},{"line_number":10,"context_line":"publicly-accessible attributes to be mutated at runtime, which defeats"},{"line_number":11,"context_line":"their intended purpose of documenting the public interface. Tuples are"},{"line_number":12,"context_line":"immutable."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ib3ab93224ba240040b08ece481ef5ba620c3f658"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a2fa921_47bf8ed0","line":12,"updated":"2015-10-05 20:52:44.000000000","message":"just because you can\u0027t mutate the value doesn\u0027t mean you can\u0027t change it, so this isn\u0027t accomplishing anything. Another module could come in and set mod1.__all__ \u003d [\u0027abc\u0027] just as well as it could mod1.__all__.extend(\u0027abc\u0027).\n\nIn other reviews I\u0027ve been -1d because I used a tuple where a list would be more appropriate -- it didn\u0027t have anything to do with mutability but the data in it (whether they\u0027re all the same (use a list) or whether they\u0027re different (use a tuple)).\n\nAll the documentation I\u0027ve found makes __all__ a list. Can we add something that prevents a new use of __all__ being a list rather than a tuple?","commit_id":"eb77abd77a25baa556de4df527404b907748d3c6"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"a13bd19cd7dd17b57961581d87cc42320ef1ec7f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Using a mutable type implies that it\u0027s acceptable for the set of"},{"line_number":10,"context_line":"publicly-accessible attributes to be mutated at runtime, which defeats"},{"line_number":11,"context_line":"their intended purpose of documenting the public interface. Tuples are"},{"line_number":12,"context_line":"immutable."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ib3ab93224ba240040b08ece481ef5ba620c3f658"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a2fa921_4709ce94","line":12,"in_reply_to":"7a2fa921_47bf8ed0","updated":"2015-10-05 20:53:47.000000000","message":"Also, there should be developer docs that say that this needs to be a list and why that we can point to if we can\u0027t add a test.","commit_id":"eb77abd77a25baa556de4df527404b907748d3c6"}]}