)]}'
{"id":"openstack%2Fpython-keystoneclient~230020","triplet_id":"openstack%2Fpython-keystoneclient~master~Ib3ab93224ba240040b08ece481ef5ba620c3f658","project":"openstack/python-keystoneclient","branch":"master","topic":"bug/1501544","hashtags":[],"change_id":"Ib3ab93224ba240040b08ece481ef5ba620c3f658","subject":"Make __all__ immutable","status":"MERGED","created":"2015-10-01 17:02:25.000000000","updated":"2015-10-07 21:41:09.000000000","submitted":"2015-10-07 21:41:07.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0c14c6cc823fc7988a597be1261da99b4be4f738","_number":230020,"virtual_id_number":230020,"owner":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2015-10-07 21:41:07.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2015-10-07 20:41:18.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-10-06 20:05:37.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},{"value":-1,"date":"2015-10-05 20:52:44.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":2,"date":"2015-10-02 06:39:07.000000000","_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":1,"date":"2015-10-07 20:41:18.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-10-02 06:39:07.000000000","updated_by":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"reviewer":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"state":"REVIEWER"},{"updated":"2015-10-05 20:52:44.000000000","updated_by":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"reviewer":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"state":"REVIEWER"},{"updated":"2015-10-06 20:05:37.000000000","updated_by":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"reviewer":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"state":"REVIEWER"},{"updated":"2015-10-07 20:41:18.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2015-10-07 21:41:07.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"3e189e9c51db1da957dd1aeb2c1c0897bcf6c905","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2015-10-01 17:02:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3b1353323444114aa3fc493f01bbf2055ac48248","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-01 17:45:12.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/20/230020/1/check/gate-python-keystoneclient-python26/1b6fb34/ : FAILURE in 1m 51s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/20/230020/1/check/gate-python-keystoneclient-pep8/3107962/ : SUCCESS in 2m 25s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/20/230020/1/check/gate-python-keystoneclient-docs/5465c3d//doc/build/html/ : SUCCESS in 2m 58s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/20/230020/1/check/gate-python-keystoneclient-python27/e1c0581/ : FAILURE in 2m 33s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/20/230020/1/check/gate-python-keystoneclient-python34/cbbdf9a/ : FAILURE in 2m 54s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/20/230020/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/ca6cad2/ : FAILURE in 24m 09s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/20/230020/1/check/gate-keystoneclient-dsvm-functional/3b50081/ : FAILURE in 36m 59s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/20/230020/1/check/gate-python-keystoneclient-tox-bandit/a911d27/ : SUCCESS in 2m 42s","accounts_in_message":[],"_revision_number":1},{"id":"270d37d27d13f70b2d4e00873aeea95f785a94d1","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2015-10-01 18:18:19.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"87d143ac5478201cba9d9c8ddf406d1f4d5b6c2e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-01 19:27:43.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/20/230020/2/check/gate-python-keystoneclient-python26/3c1ad37/ : SUCCESS in 2m 03s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/20/230020/2/check/gate-python-keystoneclient-pep8/a2c7a17/ : SUCCESS in 3m 40s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/20/230020/2/check/gate-python-keystoneclient-docs/3628f40//doc/build/html/ : SUCCESS in 3m 41s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/20/230020/2/check/gate-python-keystoneclient-python27/c43b9ff/ : SUCCESS in 2m 49s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/20/230020/2/check/gate-python-keystoneclient-python34/6c87e73/ : SUCCESS in 3m 21s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/20/230020/2/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/202ceb2/ : SUCCESS in 58m 49s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/20/230020/2/check/gate-keystoneclient-dsvm-functional/73273d5/ : SUCCESS in 24m 35s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/20/230020/2/check/gate-python-keystoneclient-tox-bandit/2ee0c2e/ : SUCCESS in 2m 41s","accounts_in_message":[],"_revision_number":2},{"id":"c702dcd2a5a2ae875e81b3f6f00d89e2c7ac3ff9","author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"date":"2015-10-02 06:39:07.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"8e5f18e1282870c82ca079c0ba660ff466d2aadd","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-10-05 20:52:44.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"a13bd19cd7dd17b57961581d87cc42320ef1ec7f","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-10-05 20:53:47.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"ac88cf339990669235ae8e446e54a6c19e202cc7","author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"date":"2015-10-06 20:05:37.000000000","message":"Patch Set 2: Code-Review+1\n\nYes Brant you are correct you can just assign a new value to the tuple, making it technically not \u0027immutable\u0027. I think since pep257 is being turned on, when it runs it gives you a warning, which is why this is being changed. Here is a link to the warning message. https://github.com/GreenSteam/pep257/blob/master/src/pep257.py#L366","accounts_in_message":[],"_revision_number":2},{"id":"4d1e9e37aa4fdc71fd5680e6376dfd0045950dea","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-10-07 20:41:18.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\ni\u0027m OK with this, it\u0027s not tied to pep257 yet.","accounts_in_message":[],"_revision_number":2},{"id":"071eceb8af76b9bcf50492699a673f36bf37d8f0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-07 20:41:23.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"c9774e22a9dfdf99da9cdcf2f9c831cb502fba6c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-07 21:41:07.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/20/230020/2/gate/gate-python-keystoneclient-python26/80fd64d/ : SUCCESS in 2m 21s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/20/230020/2/gate/gate-python-keystoneclient-docs/9babd8b//doc/build/html/ : SUCCESS in 2m 31s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/20/230020/2/gate/gate-python-keystoneclient-pep8/5a447ed/ : SUCCESS in 2m 49s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/20/230020/2/gate/gate-python-keystoneclient-python27/0ed0de8/ : SUCCESS in 2m 36s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/20/230020/2/gate/gate-python-keystoneclient-python34/4014db9/ : SUCCESS in 2m 26s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/20/230020/2/gate/gate-tempest-dsvm-neutron-src-python-keystoneclient/69a138e/ : SUCCESS in 57m 52s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/20/230020/2/gate/gate-keystoneclient-dsvm-functional/fd9c68b/ : SUCCESS in 22m 58s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/20/230020/2/gate/gate-python-keystoneclient-tox-bandit/6614f1e/ : SUCCESS in 2m 22s","accounts_in_message":[],"_revision_number":2},{"id":"6ed36454d528fbeaea763cf0628e8aa30cec9653","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-07 21:41:09.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"eb77abd77a25baa556de4df527404b907748d3c6","revisions":{"c85192624b91c0f6c6ba380346052823d317d275":{"kind":"REWORK","_number":1,"created":"2015-10-01 17:02:25.000000000","uploader":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"ref":"refs/changes/20/230020/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/20/230020/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/20/230020/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/20/230020/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/20/230020/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/20/230020/1"}}},"commit":{"parents":[{"commit":"eb1dbe8e5a20700a64de50f1d85a972a00c23319","subject":"Merge \"Add shields.io version/downloads links/badges into README.rst\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/eb1dbe8e5a20700a64de50f1d85a972a00c23319"}]}],"author":{"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","date":"2015-10-01 16:56:33.000000000","tz":0},"committer":{"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","date":"2015-10-01 16:56:33.000000000","tz":0},"subject":"Make __all__ immutable","message":"Make __all__ immutable\n\nUsing a mutable type implies that it\u0027s acceptable for the set of\npublicly-accessible attributes to be mutated at runtime, which defeats\ntheir intended purpose of documenting the public interface. Tuples are\nimmutable.\n\nChange-Id: Ib3ab93224ba240040b08ece481ef5ba620c3f658\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/c85192624b91c0f6c6ba380346052823d317d275"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/c85192624b91c0f6c6ba380346052823d317d275"}]},"branch":"refs/heads/master"},"eb77abd77a25baa556de4df527404b907748d3c6":{"kind":"REWORK","_number":2,"created":"2015-10-01 18:18:19.000000000","uploader":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"ref":"refs/changes/20/230020/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/20/230020/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/20/230020/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/20/230020/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/20/230020/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/20/230020/2"}}},"commit":{"parents":[{"commit":"eb1dbe8e5a20700a64de50f1d85a972a00c23319","subject":"Merge \"Add shields.io version/downloads links/badges into README.rst\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/eb1dbe8e5a20700a64de50f1d85a972a00c23319"}]}],"author":{"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","date":"2015-10-01 16:56:33.000000000","tz":0},"committer":{"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","date":"2015-10-01 18:18:13.000000000","tz":0},"subject":"Make __all__ immutable","message":"Make __all__ immutable\n\nUsing a mutable type implies that it\u0027s acceptable for the set of\npublicly-accessible attributes to be mutated at runtime, which defeats\ntheir intended purpose of documenting the public interface. Tuples are\nimmutable.\n\nChange-Id: Ib3ab93224ba240040b08ece481ef5ba620c3f658\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/eb77abd77a25baa556de4df527404b907748d3c6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/eb77abd77a25baa556de4df527404b907748d3c6"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}