)]}'
{"id":"openstack%2Fpython-keystoneclient~230231","triplet_id":"openstack%2Fpython-keystoneclient~stable%2Fliberty~Idab5f381fcbfb8c561184845d3aa5c8aab142ecd","project":"openstack/python-keystoneclient","branch":"stable/liberty","topic":"bug/1501918","hashtags":[],"change_id":"Idab5f381fcbfb8c561184845d3aa5c8aab142ecd","subject":"Redirect on 303 in SAML plugin","status":"MERGED","created":"2015-10-02 01:46:50.000000000","updated":"2015-10-05 18:04:55.000000000","submitted":"2015-10-05 18:04:53.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a6a657611979f112f59851c4ec5882d2a4b8d59b","_number":230231,"virtual_id_number":230231,"owner":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2015-10-05 18:04:53.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},{"value":0,"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2015-10-05 03:09:18.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":1,"date":"2015-10-05 08:43:48.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},{"value":2,"date":"2015-10-05 16:48:27.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":1,"date":"2015-10-03 07:20:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},{"value":1,"date":"2015-10-05 16:26:22.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},{"value":1,"date":"2015-10-05 16:48:27.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},{"value":0,"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-10-02 13:22:43.000000000","updated_by":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"reviewer":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"state":"REVIEWER"},{"updated":"2015-10-03 07:20:19.000000000","updated_by":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"reviewer":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"state":"REVIEWER"},{"updated":"2015-10-05 03:09:18.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2015-10-05 08:43:48.000000000","updated_by":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"reviewer":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"state":"REVIEWER"},{"updated":"2015-10-05 16:26:22.000000000","updated_by":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"reviewer":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"state":"REVIEWER"},{"updated":"2015-10-05 16:48:27.000000000","updated_by":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"reviewer":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"state":"REVIEWER"},{"updated":"2015-10-05 18:04:53.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"3a63a1197e31fd53a71a7cc822717cf215922c44","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2015-10-02 01:46:50.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f689826d644fd89ef9a720ac7899ef9e7ba001f0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-02 02:47:05.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/31/230231/1/check/gate-python-keystoneclient-python26/b2e0bdf/ : SUCCESS in 1m 52s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/31/230231/1/check/gate-python-keystoneclient-pep8/5f9935e/ : SUCCESS in 2m 25s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/31/230231/1/check/gate-python-keystoneclient-docs/8db99ab//doc/build/html/ : SUCCESS in 3m 04s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/31/230231/1/check/gate-python-keystoneclient-python27/5582dfa/ : SUCCESS in 2m 40s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/31/230231/1/check/gate-python-keystoneclient-python34/a0f7971/ : FAILURE in 3m 37s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/31/230231/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/07be684/ : SUCCESS in 58m 07s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/31/230231/1/check/gate-keystoneclient-dsvm-functional/05fd938/ : SUCCESS in 16m 59s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/31/230231/1/check/gate-python-keystoneclient-tox-bandit/9bc1345/ : SUCCESS in 2m 48s","accounts_in_message":[],"_revision_number":1},{"id":"da665e17449c68fd7b32580615e6e480fa2b4562","author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"date":"2015-10-02 06:50:08.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"11ddf80285309e3d03242d5bbac41b95f0fd0d9d","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2015-10-02 13:22:43.000000000","message":"Patch Set 1:\n\nIs there a fix up for the fatal deprecations in py34?","accounts_in_message":[],"_revision_number":1},{"id":"ddd7d7f1490fcaf3ae046fc256fa6477dc96878d","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2015-10-02 22:23:06.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"0d18f3a7fe6beee1ead3299786c9cb5a93732d4d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-02 23:32:47.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/31/230231/2/check/gate-python-keystoneclient-python26/7793ca1/ : SUCCESS in 2m 42s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/31/230231/2/check/gate-python-keystoneclient-pep8/ed96639/ : SUCCESS in 2m 25s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/31/230231/2/check/gate-python-keystoneclient-docs/30d5928//doc/build/html/ : SUCCESS in 2m 18s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/31/230231/2/check/gate-python-keystoneclient-python27/6323bb1/ : SUCCESS in 2m 12s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/31/230231/2/check/gate-python-keystoneclient-python34/7e777b3/ : SUCCESS in 3m 02s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/31/230231/2/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/79cc085/ : SUCCESS in 1h 09m 33s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/31/230231/2/check/gate-keystoneclient-dsvm-functional/9ebd022/ : SUCCESS in 33m 17s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/31/230231/2/check/gate-python-keystoneclient-tox-bandit/53ec551/ : SUCCESS in 2m 42s","accounts_in_message":[],"_revision_number":2},{"id":"92948fc748e0fd16fd393e4dc93ca806de583a7e","author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"date":"2015-10-03 07:20:19.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"163aa836f91bf0998c1bf0d5ab588296db47b547","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-10-05 03:09:18.000000000","message":"Patch Set 2: Code-Review+2\n\n@dolph, yes there is, this should be the last bit that goes in for the liberty release","accounts_in_message":[],"_revision_number":2},{"id":"a5183b41f8cde46892d80dd983c77888760d6f6e","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-10-05 04:56:20.000000000","message":"Patch Set 2:\n\n@dolph, the py34 tests are passing now, let\u0027s close this one out and release a new KSC","accounts_in_message":[],"_revision_number":2},{"id":"e97c3373d39c0540a0d24a94b9b43aaecc10ec5c","author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"date":"2015-10-05 08:43:48.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"8db8e1f3df9a805b31a1d5507953779123601620","author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"date":"2015-10-05 16:26:22.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"2db0e35c9a3bd9d8ae02e54a4c94514369a41ff5","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-10-05 16:48:27.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nclean cherry-pick.","accounts_in_message":[],"_revision_number":2},{"id":"4c85107a6fb718c8209f45be618944dd2d9cbb66","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-05 16:48:32.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"b7ab9da4d7ebd94350628d0b8fc4422a92c75e34","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-05 18:04:53.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/31/230231/2/gate/gate-python-keystoneclient-python26/0272d47/ : SUCCESS in 1m 51s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/31/230231/2/gate/gate-python-keystoneclient-docs/bb9c062//doc/build/html/ : SUCCESS in 2m 15s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/31/230231/2/gate/gate-python-keystoneclient-pep8/989fcaf/ : SUCCESS in 2m 19s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/31/230231/2/gate/gate-python-keystoneclient-python27/a85a0f3/ : SUCCESS in 2m 27s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/31/230231/2/gate/gate-python-keystoneclient-python34/fcfdf96/ : SUCCESS in 3m 02s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/31/230231/2/gate/gate-tempest-dsvm-neutron-src-python-keystoneclient/adcd9ce/ : SUCCESS in 1h 07m 19s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/31/230231/2/gate/gate-keystoneclient-dsvm-functional/caa78c5/ : SUCCESS in 32m 15s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/31/230231/2/gate/gate-python-keystoneclient-tox-bandit/bd90a0e/ : SUCCESS in 1m 50s","accounts_in_message":[],"_revision_number":2},{"id":"a2104f84e204016c00489db993fe6fb812c24d67","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-05 18:04:55.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"90c5838074fcb5d64fa3aaadf4a61eed606cd9d3","revisions":{"c01a607eccb0ff0ef3ee59c5fc1b619e2eb63893":{"kind":"REWORK","_number":1,"created":"2015-10-02 01:46:50.000000000","uploader":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"ref":"refs/changes/31/230231/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/31/230231/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/230231/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/230231/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/230231/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/230231/1"}}},"commit":{"parents":[{"commit":"c68b82ad7d7d9e8c870bc5be1ba24743e96e79bd","subject":"Update .gitreview for stable/liberty","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/c68b82ad7d7d9e8c870bc5be1ba24743e96e79bd"}]}],"author":{"name":"Jamie Lennox","email":"jamielennox@redhat.com","date":"2015-10-01 21:17:21.000000000","tz":600},"committer":{"name":"Jamie Lennox","email":"jamielennox@redhat.com","date":"2015-10-02 01:46:33.000000000","tz":600},"subject":"Redirect on 303 in SAML plugin","message":"Redirect on 303 in SAML plugin\n\nThe SAML plugin handles redirects in a custom manner but currently only\nchecks for the 302 redirect code. This doesn\u0027t cover the mod_auth_mellon\ncase which responds with a 303.\n\nAlso handle the 303 redirect case.\n\nChange-Id: Idab5f381fcbfb8c561184845d3aa5c8aab142ecd\nCloses-Bug: #1501918\n(cherry picked from commit 9cd71c064c77a22a0a58084a2abab77b023017b5)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/c01a607eccb0ff0ef3ee59c5fc1b619e2eb63893"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/c01a607eccb0ff0ef3ee59c5fc1b619e2eb63893"}]},"branch":"refs/heads/stable/liberty"},"90c5838074fcb5d64fa3aaadf4a61eed606cd9d3":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2015-10-02 22:23:06.000000000","uploader":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"ref":"refs/changes/31/230231/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/31/230231/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/230231/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/230231/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/230231/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/31/230231/2"}}},"commit":{"parents":[{"commit":"87e0cb92b64838664a3e7f0e5bf5a4779c90d971","subject":"Merge \"Updated from global requirements\" into stable/liberty","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/87e0cb92b64838664a3e7f0e5bf5a4779c90d971"}]}],"author":{"name":"Jamie Lennox","email":"jamielennox@redhat.com","date":"2015-10-01 21:17:21.000000000","tz":600},"committer":{"name":"Jamie Lennox","email":"jamielennox@redhat.com","date":"2015-10-02 22:23:06.000000000","tz":0},"subject":"Redirect on 303 in SAML plugin","message":"Redirect on 303 in SAML plugin\n\nThe SAML plugin handles redirects in a custom manner but currently only\nchecks for the 302 redirect code. This doesn\u0027t cover the mod_auth_mellon\ncase which responds with a 303.\n\nAlso handle the 303 redirect case.\n\nChange-Id: Idab5f381fcbfb8c561184845d3aa5c8aab142ecd\nCloses-Bug: #1501918\n(cherry picked from commit 9cd71c064c77a22a0a58084a2abab77b023017b5)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/90c5838074fcb5d64fa3aaadf4a61eed606cd9d3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/90c5838074fcb5d64fa3aaadf4a61eed606cd9d3"}]},"branch":"refs/heads/stable/liberty"}},"requirements":[],"submit_records":[],"submit_requirements":[]}