)]}'
{"keystoneclient/tests/unit/v3/test_users.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"a5b5c888899a81ee5628fe50ce147723f2f69841","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        self.assertNotIn(old_password, self.logger.output)"},{"line_number":256,"context_line":"        self.assertNotIn(new_password, self.logger.output)"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    def test_update_password_with_no_hardcoded_endpoint_filter(self):"},{"line_number":259,"context_line":"        old_password \u003d uuid.uuid4().hex"},{"line_number":260,"context_line":"        new_password \u003d uuid.uuid4().hex"},{"line_number":261,"context_line":"        expected_params \u003d {\u0027user\u0027: {\u0027password\u0027: new_password,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_d8ba3f23","line":258,"updated":"2015-10-20 16:35:19.000000000","message":"Add a comment clarifying what this test is asserting, because the name of the test says to me that this is testing calling update_password without an endpoint filter and other tests are already doing that.","commit_id":"6a17d0acb6c875da432deb5673ed4d6fffc482a1"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e30603ab45494d2e051906ff8f7a398bbe39c5d5","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        self.assertNotIn(old_password, self.logger.output)"},{"line_number":256,"context_line":"        self.assertNotIn(new_password, self.logger.output)"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    def test_update_password_with_no_hardcoded_endpoint_filter(self):"},{"line_number":259,"context_line":"        old_password \u003d uuid.uuid4().hex"},{"line_number":260,"context_line":"        new_password \u003d uuid.uuid4().hex"},{"line_number":261,"context_line":"        expected_params \u003d {\u0027user\u0027: {\u0027password\u0027: new_password,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_f6caf54e","line":258,"updated":"2015-10-14 02:40:32.000000000","message":"i don\u0027t see where you override the interface value here","commit_id":"6a17d0acb6c875da432deb5673ed4d6fffc482a1"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"9070dfddd716f1244e43e1aa44f6219777e45098","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        self.assertNotIn(old_password, self.logger.output)"},{"line_number":256,"context_line":"        self.assertNotIn(new_password, self.logger.output)"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    def test_update_password_with_no_hardcoded_endpoint_filter(self):"},{"line_number":259,"context_line":"        old_password \u003d uuid.uuid4().hex"},{"line_number":260,"context_line":"        new_password \u003d uuid.uuid4().hex"},{"line_number":261,"context_line":"        expected_params \u003d {\u0027user\u0027: {\u0027password\u0027: new_password,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_8cefa986","line":258,"in_reply_to":"3a29b11f_d8ba3f23","updated":"2015-10-20 18:14:37.000000000","message":"done","commit_id":"6a17d0acb6c875da432deb5673ed4d6fffc482a1"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"6ace33bfbc572fc788e83ee46da064f86e29fd70","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        self.assertNotIn(old_password, self.logger.output)"},{"line_number":256,"context_line":"        self.assertNotIn(new_password, self.logger.output)"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    def test_update_password_with_no_hardcoded_endpoint_filter(self):"},{"line_number":259,"context_line":"        old_password \u003d uuid.uuid4().hex"},{"line_number":260,"context_line":"        new_password \u003d uuid.uuid4().hex"},{"line_number":261,"context_line":"        expected_params \u003d {\u0027user\u0027: {\u0027password\u0027: new_password,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_3faea798","line":258,"in_reply_to":"5a2ca52d_f6caf54e","updated":"2015-10-15 16:47:14.000000000","message":"We don\u0027t. We just need to make sure it is not hardcoded. The override should be coming from the Session, not the managers themselves. i.e.\n\nopenstack --os-interface internal ..\n\nthat value is properly conveyed in\n\nhttps://github.com/openstack/python-openstackclient/blob/master/openstackclient/identity/client.py#L50\n\nWhich eventually made its way down here\n\nhttps://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/httpclient.py#L395\nhttps://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/adapter.py#L72\nhttps://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/adapter.py#L81","commit_id":"6a17d0acb6c875da432deb5673ed4d6fffc482a1"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"a5b5c888899a81ee5628fe50ce147723f2f69841","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        new_password \u003d uuid.uuid4().hex"},{"line_number":261,"context_line":"        expected_params \u003d {\u0027user\u0027: {\u0027password\u0027: new_password,"},{"line_number":262,"context_line":"                                    \u0027original_password\u0027: old_password}}"},{"line_number":263,"context_line":"        base_url \u003d \u0027/users/%s/password\u0027 % self.TEST_USER_ID"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        self.client.user_id \u003d self.TEST_USER_ID"},{"line_number":266,"context_line":"        with mock.patch(\u0027keystoneclient.base.Manager._update\u0027) as m:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_78876bd7","line":263,"updated":"2015-10-20 16:35:19.000000000","message":"change the name to \"expected_url\" or \"expected_base_url\"... what\u0027s base about the url?","commit_id":"6a17d0acb6c875da432deb5673ed4d6fffc482a1"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"9070dfddd716f1244e43e1aa44f6219777e45098","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        new_password \u003d uuid.uuid4().hex"},{"line_number":261,"context_line":"        expected_params \u003d {\u0027user\u0027: {\u0027password\u0027: new_password,"},{"line_number":262,"context_line":"                                    \u0027original_password\u0027: old_password}}"},{"line_number":263,"context_line":"        base_url \u003d \u0027/users/%s/password\u0027 % self.TEST_USER_ID"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        self.client.user_id \u003d self.TEST_USER_ID"},{"line_number":266,"context_line":"        with mock.patch(\u0027keystoneclient.base.Manager._update\u0027) as m:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_c7633adb","line":263,"in_reply_to":"3a29b11f_78876bd7","updated":"2015-10-20 18:14:37.000000000","message":"how about user_password_update_path?","commit_id":"6a17d0acb6c875da432deb5673ed4d6fffc482a1"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"a5b5c888899a81ee5628fe50ce147723f2f69841","unresolved":false,"context_lines":[{"line_number":262,"context_line":"                                    \u0027original_password\u0027: old_password}}"},{"line_number":263,"context_line":"        base_url \u003d \u0027/users/%s/password\u0027 % self.TEST_USER_ID"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        self.client.user_id \u003d self.TEST_USER_ID"},{"line_number":266,"context_line":"        with mock.patch(\u0027keystoneclient.base.Manager._update\u0027) as m:"},{"line_number":267,"context_line":"            self.manager.update_password(old_password, new_password)"},{"line_number":268,"context_line":"            m.assert_called_with(base_url, expected_params,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_58594ffd","line":265,"updated":"2015-10-20 16:35:19.000000000","message":"add a comment what this is doing here.","commit_id":"6a17d0acb6c875da432deb5673ed4d6fffc482a1"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"9070dfddd716f1244e43e1aa44f6219777e45098","unresolved":false,"context_lines":[{"line_number":262,"context_line":"                                    \u0027original_password\u0027: old_password}}"},{"line_number":263,"context_line":"        base_url \u003d \u0027/users/%s/password\u0027 % self.TEST_USER_ID"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        self.client.user_id \u003d self.TEST_USER_ID"},{"line_number":266,"context_line":"        with mock.patch(\u0027keystoneclient.base.Manager._update\u0027) as m:"},{"line_number":267,"context_line":"            self.manager.update_password(old_password, new_password)"},{"line_number":268,"context_line":"            m.assert_called_with(base_url, expected_params,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_47a64a11","line":265,"in_reply_to":"3a29b11f_58594ffd","updated":"2015-10-20 18:14:37.000000000","message":"done","commit_id":"6a17d0acb6c875da432deb5673ed4d6fffc482a1"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e30603ab45494d2e051906ff8f7a398bbe39c5d5","unresolved":false,"context_lines":[{"line_number":263,"context_line":"        base_url \u003d \u0027/users/%s/password\u0027 % self.TEST_USER_ID"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        self.client.user_id \u003d self.TEST_USER_ID"},{"line_number":266,"context_line":"        with mock.patch(\u0027keystoneclient.base.Manager._update\u0027) as m:"},{"line_number":267,"context_line":"            self.manager.update_password(old_password, new_password)"},{"line_number":268,"context_line":"            m.assert_called_with(base_url, expected_params,"},{"line_number":269,"context_line":"                                 method\u003d\u0027POST\u0027, log\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_36b06ddd","line":266,"updated":"2015-10-14 02:40:32.000000000","message":"use stub_url like the test above","commit_id":"6a17d0acb6c875da432deb5673ed4d6fffc482a1"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"6ace33bfbc572fc788e83ee46da064f86e29fd70","unresolved":false,"context_lines":[{"line_number":263,"context_line":"        base_url \u003d \u0027/users/%s/password\u0027 % self.TEST_USER_ID"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        self.client.user_id \u003d self.TEST_USER_ID"},{"line_number":266,"context_line":"        with mock.patch(\u0027keystoneclient.base.Manager._update\u0027) as m:"},{"line_number":267,"context_line":"            self.manager.update_password(old_password, new_password)"},{"line_number":268,"context_line":"            m.assert_called_with(base_url, expected_params,"},{"line_number":269,"context_line":"                                 method\u003d\u0027POST\u0027, log\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_1f808bf6","line":266,"in_reply_to":"5a2ca52d_36b06ddd","updated":"2015-10-15 16:47:14.000000000","message":"No need. In this case, all we care is that the \u0027endpoint_filter\u0027 param is not hardcoded, and therefore it would not be in the params.","commit_id":"6a17d0acb6c875da432deb5673ed4d6fffc482a1"}]}