)]}'
{"id":"openstack%2Fpython-keystoneclient~238142","triplet_id":"openstack%2Fpython-keystoneclient~master~I79969ad1a3429516ea785c649a165ead54944225","project":"openstack/python-keystoneclient","branch":"master","topic":"(HEAD","hashtags":[],"change_id":"I79969ad1a3429516ea785c649a165ead54944225","subject":"pass on @abc.abstractmethods","status":"MERGED","created":"2015-10-21 15:33:07.000000000","updated":"2015-10-21 18:11:34.000000000","submitted":"2015-10-21 18:11:33.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d3ee202b6a11e9228cbadfe103a07c0e67b1ac59","_number":238142,"virtual_id_number":238142,"owner":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2015-10-21 18:11:33.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"all":[{"value":2,"date":"2015-10-21 15:34:22.000000000","_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},{"value":2,"date":"2015-10-21 15:34:33.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-10-21 15:44:06.000000000","_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"all":[{"value":0,"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-10-21 15:44:06.000000000","_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-10-21 15:34:22.000000000","updated_by":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"reviewer":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"state":"REVIEWER"},{"updated":"2015-10-21 15:34:33.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2015-10-21 15:44:06.000000000","updated_by":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"reviewer":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"state":"REVIEWER"},{"updated":"2015-10-21 18:11:33.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"0be7d359952744c2a6ad0d434b322efd55698964","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2015-10-21 15:33:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ee83b648c651fb3b336a7ce14b888a99476e5076","author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"date":"2015-10-21 15:34:22.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"c2e3e0aa6a3d9b4a1a8583afb915a5718b3a59f4","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-10-21 15:34:33.000000000","message":"Patch Set 1: Code-Review+2\n\ni\u0027m cool with this","accounts_in_message":[],"_revision_number":1},{"id":"43952b2cd69aa1d86545586c5f3aae2148976a44","author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"date":"2015-10-21 15:44:06.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"a5908700c77340a3d819382db10c79e871b5fc2e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-21 17:18:12.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/42/238142/1/check/gate-python-keystoneclient-python26/89d6975/ : SUCCESS in 3m 10s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/42/238142/1/check/gate-python-keystoneclient-pep8/788fbeb/ : SUCCESS in 1m 58s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/42/238142/1/check/gate-python-keystoneclient-docs/9d33c66//doc/build/html/ : SUCCESS in 2m 37s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/42/238142/1/check/gate-python-keystoneclient-python27/cfa970c/ : SUCCESS in 2m 25s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/42/238142/1/check/gate-python-keystoneclient-python34/e41d988/ : SUCCESS in 3m 17s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/42/238142/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/412d6bf/ : SUCCESS in 1h 03m 00s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/42/238142/1/check/gate-keystoneclient-dsvm-functional/007a3fd/ : SUCCESS in 30m 33s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/42/238142/1/check/gate-python-keystoneclient-tox-bandit/8b41b1a/ : SUCCESS in 2m 41s","accounts_in_message":[],"_revision_number":1},{"id":"ee2a4ffda60fe545a36ba8b9c9b20c2596f6d38c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-21 17:18:31.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"1175fdba49103f972d07b55e5718bcee07ac14a8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-21 18:11:33.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/42/238142/1/gate/gate-python-keystoneclient-python26/78eafd3/ : SUCCESS in 2m 21s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/42/238142/1/gate/gate-python-keystoneclient-docs/c43afeb//doc/build/html/ : SUCCESS in 2m 28s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/42/238142/1/gate/gate-python-keystoneclient-pep8/79d2f8d/ : SUCCESS in 1m 59s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/42/238142/1/gate/gate-python-keystoneclient-python27/e363c5c/ : SUCCESS in 2m 45s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/42/238142/1/gate/gate-python-keystoneclient-python34/a903860/ : SUCCESS in 3m 21s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/42/238142/1/gate/gate-tempest-dsvm-neutron-src-python-keystoneclient/06d5242/ : SUCCESS in 49m 01s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/42/238142/1/gate/gate-keystoneclient-dsvm-functional/399f40d/ : SUCCESS in 20m 24s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/42/238142/1/gate/gate-python-keystoneclient-tox-bandit/0769838/ : SUCCESS in 2m 09s","accounts_in_message":[],"_revision_number":1},{"id":"13d4afe5dee586603438249c0fd545638232d476","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-21 18:11:34.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"574fad7abb328276396d7d4c2743982bb903078c","revisions":{"574fad7abb328276396d7d4c2743982bb903078c":{"kind":"REWORK","_number":1,"created":"2015-10-21 15:33:07.000000000","uploader":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"ref":"refs/changes/42/238142/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/42/238142/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/42/238142/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/42/238142/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/42/238142/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/42/238142/1"}}},"commit":{"parents":[{"commit":"6588ad5fb5a3162aa2204ca38fb5a89a1f940985","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/6588ad5fb5a3162aa2204ca38fb5a89a1f940985"}]}],"author":{"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","date":"2015-10-21 15:32:33.000000000","tz":0},"committer":{"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","date":"2015-10-21 15:32:33.000000000","tz":0},"subject":"pass on @abc.abstractmethods","message":"pass on @abc.abstractmethods\n\nAlthough a bare docstring is entirely valid grammar, those new to Python find\nthat pattern baffling, *especially* when other similar methods contain pass\nstatements. So, for consistency, add a pass statement to otherwise bare\n@abc.abstractmethods.\n\nNote that the implementation of an @abc.abstractmethod (in the abstract\nbase class) can still be called by concrete children, so suddenly\nraising a NotImplementedError() instead might be \"surprising\" to\nimplementors. A no-op such as \"pass\" or \"return None\" is preferable.\n\nChange-Id: I79969ad1a3429516ea785c649a165ead54944225\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/574fad7abb328276396d7d4c2743982bb903078c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/574fad7abb328276396d7d4c2743982bb903078c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}