)]}'
{"id":"openstack%2Fpython-keystoneclient~238209","triplet_id":"openstack%2Fpython-keystoneclient~master~I88a7481ab22f2ce1abfd62badc5f5048acc6929f","project":"openstack/python-keystoneclient","branch":"master","topic":"cover","hashtags":[],"change_id":"I88a7481ab22f2ce1abfd62badc5f5048acc6929f","subject":"Mark abstractmethod bodies with nocover","status":"MERGED","created":"2015-10-21 18:40:54.000000000","updated":"2015-10-22 08:19:52.000000000","submitted":"2015-10-22 08:19:50.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f707e751b8ab15b4ce02159720da9db1a0b0f6ae","_number":238209,"virtual_id_number":238209,"owner":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},{"value":0,"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},{"value":2,"date":"2015-10-22 08:19:50.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"date":"2015-10-21 19:26:45.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"all":[{"value":2,"date":"2015-10-22 07:30:36.000000000","_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},{"value":1,"date":"2015-10-21 19:31:26.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-10-21 18:44:23.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"all":[{"value":1,"date":"2015-10-22 07:30:36.000000000","_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},{"value":0,"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-10-21 18:44:23.000000000","updated_by":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"reviewer":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"state":"REVIEWER"},{"updated":"2015-10-21 19:31:26.000000000","updated_by":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"reviewer":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"state":"REVIEWER"},{"updated":"2015-10-22 07:30:36.000000000","updated_by":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"reviewer":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"state":"REVIEWER"},{"updated":"2015-10-22 08:19:50.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"d3c789ff7fcda6a215f35fc8d271047d52a72d53","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-10-21 18:40:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6f249411ce7324c2414bc9bee498e34afb6e8e72","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2015-10-21 18:44:23.000000000","message":"Patch Set 1: Code-Review+2\n\nTo be fair, plugins could call super() and we could hit all the pass and return None statements, but that\u0027d be a bad idea where we\u0027ve used raise NotImplementedError instead, for whatever reason.","accounts_in_message":[],"_revision_number":1},{"id":"43290ba3504a70785eba174bd854e324b89581d1","author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"date":"2015-10-21 19:10:01.000000000","message":"Patch Set 1: Code-Review-1\n\nBrant everything is good here, I just want you to take a look at these abstract methods to see if they fit your parameters to add the \"# pragma: no cover\"\n\nline #235\nhttp://git.openstack.org/cgit/openstack/python-keystoneclient/tree/keystoneclient/openstack/common/apiclient/base.py#n235\n\nline #205\nhttp://git.openstack.org/cgit/openstack/python-keystoneclient/tree/keystoneclient/openstack/common/apiclient/auth.py#n205\n\nline # 221\nhttp://git.openstack.org/cgit/openstack/python-keystoneclient/tree/keystoneclient/openstack/common/apiclient/auth.py#n221\n\nline #51\nhttp://git.openstack.org/cgit/openstack/python-keystoneclient/tree/keystoneclient/tests/unit/auth/test_identity_common.py#n51\n\nline #60\nhttp://git.openstack.org/cgit/openstack/python-keystoneclient/tree/keystoneclient/tests/unit/auth/test_identity_common.py#n60","accounts_in_message":[],"_revision_number":1},{"id":"0ca6b3458cb5cb64d26748adba7498db03503279","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-10-21 19:26:45.000000000","message":"Patch Set 1:\n\nTom -\n\nParts in openstack/common aren\u0027t files that we change, they\u0027re copied from oslo-incubator. So we don\u0027t change them ourselves and they\u0027re ignored in the coverage report since the testing is done in oslo-incubator.\n\nParts in tests don\u0027t need no-cover since they\u0027re the unit tests so they aren\u0027t part of the coverage report.","accounts_in_message":[],"_revision_number":1},{"id":"eb08514fdfb810d257760580dc01f389d1794051","author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"date":"2015-10-21 19:31:26.000000000","message":"Patch Set 1: Code-Review+1\n\n@Brant  I figured the /common files were off limits but I just wanted to make sure you were informed of them.  \n\nThat also makes sense that the coverage tests don\u0027t cover the tests :p\n\nThis all looks good to me","accounts_in_message":[],"_revision_number":1},{"id":"52eb4bde1d9bc026a9c2b9924539d3be5d2fc0db","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-21 19:49:11.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/09/238209/1/check/gate-python-keystoneclient-python26/d56a89e/ : SUCCESS in 2m 52s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/09/238209/1/check/gate-python-keystoneclient-pep8/8317ef6/ : SUCCESS in 2m 01s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/09/238209/1/check/gate-python-keystoneclient-docs/2eae8a3//doc/build/html/ : SUCCESS in 2m 25s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/09/238209/1/check/gate-python-keystoneclient-python27/3c20308/ : SUCCESS in 2m 25s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/09/238209/1/check/gate-python-keystoneclient-python34/dc422cb/ : SUCCESS in 2m 41s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/09/238209/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/c353d77/ : SUCCESS in 1h 05m 35s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/09/238209/1/check/gate-keystoneclient-dsvm-functional/0693562/ : SUCCESS in 26m 44s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/09/238209/1/check/gate-python-keystoneclient-tox-bandit/92c500b/ : SUCCESS in 2m 19s","accounts_in_message":[],"_revision_number":1},{"id":"9d9cb09e64882a688835df4d7092b8f88d2ddbd0","author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"date":"2015-10-22 07:30:36.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"0bf413e42ae4121c75fe73777dad79f84e8e1a98","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-22 07:30:42.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"995a94e2e1b505ecfbecde17b8f0b1f51eff17c9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-22 08:19:50.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/09/238209/1/gate/gate-python-keystoneclient-python26/716e061/ : SUCCESS in 2m 26s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/09/238209/1/gate/gate-python-keystoneclient-docs/5e33a96//doc/build/html/ : SUCCESS in 3m 00s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/09/238209/1/gate/gate-python-keystoneclient-pep8/c4144e4/ : SUCCESS in 2m 33s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/09/238209/1/gate/gate-python-keystoneclient-python27/51f259b/ : SUCCESS in 2m 45s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/09/238209/1/gate/gate-python-keystoneclient-python34/a5aa51c/ : SUCCESS in 3m 38s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/09/238209/1/gate/gate-tempest-dsvm-neutron-src-python-keystoneclient/93cb672/ : SUCCESS in 49m 06s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/09/238209/1/gate/gate-keystoneclient-dsvm-functional/99c6feb/ : SUCCESS in 27m 58s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/09/238209/1/gate/gate-python-keystoneclient-tox-bandit/f8d87f4/ : SUCCESS in 3m 40s","accounts_in_message":[],"_revision_number":1},{"id":"03bc3664d57cd44b5c1b8557f04a988b9dc82244","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-22 08:19:52.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a8d2bd29347d02298a6a809f6ca52107aae00a4a","revisions":{"a8d2bd29347d02298a6a809f6ca52107aae00a4a":{"kind":"REWORK","_number":1,"created":"2015-10-21 18:40:54.000000000","uploader":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"ref":"refs/changes/09/238209/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/09/238209/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/09/238209/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/09/238209/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/09/238209/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/09/238209/1"}}},"commit":{"parents":[{"commit":"574fad7abb328276396d7d4c2743982bb903078c","subject":"pass on @abc.abstractmethods","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/574fad7abb328276396d7d4c2743982bb903078c"}]}],"author":{"name":"Brant Knudson","email":"bknudson@us.ibm.com","date":"2015-10-21 18:35:53.000000000","tz":-300},"committer":{"name":"Brant Knudson","email":"bknudson@us.ibm.com","date":"2015-10-21 18:35:53.000000000","tz":-300},"subject":"Mark abstractmethod bodies with nocover","message":"Mark abstractmethod bodies with nocover\n\nabstractmethod bodies aren\u0027t going to be called by unit tests, so\nthere\u0027s no way to get coverage. The code in an abstractmethod body\nshould be marked with \"# pragma: no cover\" so that they don\u0027t show\nup as missed in the coverage report.\n\nChange-Id: I88a7481ab22f2ce1abfd62badc5f5048acc6929f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/a8d2bd29347d02298a6a809f6ca52107aae00a4a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/a8d2bd29347d02298a6a809f6ca52107aae00a4a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}