)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"59c4711eb596f951d120db008632e8491cc0f5ca","unresolved":false,"context_lines":[{"line_number":11,"context_line":"creation, as root projects that act as domains can not have domain_id."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I65a2f879e137ce7cea1c11713acafe91f19a0382"},{"line_number":14,"context_line":"Depends-On: Ib22a0f3007cb7ef6b4df6f48da5f4d018e905f55"},{"line_number":15,"context_line":"Partially-Implements: bp reseller"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7aa08908_877ba38b","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":53},"updated":"2016-06-07 23:30:12.000000000","message":"this dependency has merged: this line is not necessary anymore","commit_id":"fda62ac70d7f51af933fcc348f29fbd31f91ff79"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"8d93f84b3c8cee4af7c201660ecd144cdcc516de","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Adds the capability of creating a project that acts as a domain. This"},{"line_number":10,"context_line":"patch also makes the \"domain_id\" field optional in the projects"},{"line_number":11,"context_line":"creation, as root projects that act as domains can not have domain_id."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I65a2f879e137ce7cea1c11713acafe91f19a0382"},{"line_number":14,"context_line":"Depends-On: Ib22a0f3007cb7ef6b4df6f48da5f4d018e905f55"},{"line_number":15,"context_line":"Partially-Implements: bp reseller"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7faddb67_ef032a72","line":12,"updated":"2019-07-10 19:24:13.000000000","message":"Can you add an explanation of why this is needed?","commit_id":"73aca66ac3a4c6a7bb20029e92c3c0a5c16cd0e5"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"2c05028371b12fd1aeec8d5e6502b1b2798bfbcc","unresolved":false,"context_lines":[{"line_number":11,"context_line":"creation, as root projects that act as domains can not have domain_id."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I65a2f879e137ce7cea1c11713acafe91f19a0382"},{"line_number":14,"context_line":"Depends-On: Ib22a0f3007cb7ef6b4df6f48da5f4d018e905f55"},{"line_number":15,"context_line":"Partially-Implements: bp reseller"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7faddb67_28b15f90","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":53},"updated":"2019-07-25 13:52:13.000000000","message":"I don\u0027t think it requires Depends-On tag now since the depends on patch is merged years ago.","commit_id":"73aca66ac3a4c6a7bb20029e92c3c0a5c16cd0e5"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"8d93f84b3c8cee4af7c201660ecd144cdcc516de","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I65a2f879e137ce7cea1c11713acafe91f19a0382"},{"line_number":14,"context_line":"Depends-On: Ib22a0f3007cb7ef6b4df6f48da5f4d018e905f55"},{"line_number":15,"context_line":"Partially-Implements: bp reseller"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7faddb67_4fdb5e1a","line":15,"updated":"2019-07-10 19:24:13.000000000","message":"This launchpad blueprint doesn\u0027t exist, can you update it to point to an existing blueprint or create an RFE bug and link to that instead? https://docs.openstack.org/keystone/latest/contributor/proposing-features.html#rfe-bug-reports","commit_id":"73aca66ac3a4c6a7bb20029e92c3c0a5c16cd0e5"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"2c05028371b12fd1aeec8d5e6502b1b2798bfbcc","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I65a2f879e137ce7cea1c11713acafe91f19a0382"},{"line_number":14,"context_line":"Depends-On: Ib22a0f3007cb7ef6b4df6f48da5f4d018e905f55"},{"line_number":15,"context_line":"Partially-Implements: bp reseller"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7faddb67_48713bde","line":15,"in_reply_to":"7faddb67_4fdb5e1a","updated":"2019-07-25 13:52:13.000000000","message":"++. Now keystone tracks Bp\u0027s as bugs, so you can create a new RFE bug report on launchpad.","commit_id":"73aca66ac3a4c6a7bb20029e92c3c0a5c16cd0e5"}],"keystoneclient/tests/unit/v3/test_projects.py":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"ca750db2371dbabfc69e7273eb9d060fbeff0166","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def test_create_with_is_domain_false(self):"},{"line_number":123,"context_line":"        ref \u003d self._new_project_ref()"},{"line_number":124,"context_line":"        ref[\u0027is_domain\u0027] \u003d False"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        self.stub_entity(\u0027POST\u0027, entity\u003dref, status_code\u003d201)"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_b2b1cae2","line":124,"range":{"start_line":124,"start_character":8,"end_line":124,"end_character":32},"updated":"2016-06-17 14:46:09.000000000","message":"what should happen if I don\u0027t pass this field? It is set to False by default, right? Think you need to add a test for this case as well.","commit_id":"fda62ac70d7f51af933fcc348f29fbd31f91ff79"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"4fdc26d71e29c01932242519929df2c5200470d8","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def test_create_with_is_domain_false(self):"},{"line_number":123,"context_line":"        ref \u003d self._new_project_ref()"},{"line_number":124,"context_line":"        ref[\u0027is_domain\u0027] \u003d False"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        self.stub_entity(\u0027POST\u0027, entity\u003dref, status_code\u003d201)"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_6cef1bea","line":124,"range":{"start_line":124,"start_character":8,"end_line":124,"end_character":32},"in_reply_to":"7aa08908_b2b1cae2","updated":"2016-07-01 13:07:53.000000000","message":"++","commit_id":"fda62ac70d7f51af933fcc348f29fbd31f91ff79"}],"keystoneclient/v3/projects.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"77f4b5c7855b2ff39bdb7edc588f9aafd5d01411","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        :param boolean enabled: if the project is enabled. (optional)"},{"line_number":74,"context_line":"        :param parent: the project\u0027s parent in the hierarchy. (optional)"},{"line_number":75,"context_line":"        :type parent: :py:class:`keystoneclient.v3.projects.Project` or str"},{"line_number":76,"context_line":"        :param boolean is_domain: if the project acts as a domain. (optional)"},{"line_number":77,"context_line":"        \"\"\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        # NOTE(rodrigods): the API must be backwards compatible, so if an"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_29a0d342","line":76,"updated":"2015-11-26 04:49:19.000000000","message":"is_domain hasn\u0027t been added to the method signature yet.","commit_id":"9a4e6c3a855c3ae9013e4efc1cfd9abfcad718be"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"59c4711eb596f951d120db008632e8491cc0f5ca","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @positional(2, enforcement\u003dpositional.WARN)"},{"line_number":66,"context_line":"    def create(self, name, domain\u003dNone, description\u003dNone,"},{"line_number":67,"context_line":"               enabled\u003dTrue, parent\u003dNone, is_domain\u003dTrue, **kwargs):"},{"line_number":68,"context_line":"        \"\"\"Create a project."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        :param str name: project name."}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_678f9775","line":67,"range":{"start_line":67,"start_character":42,"end_line":67,"end_character":56},"updated":"2016-06-07 23:30:12.000000000","message":"Where is this used ? this is not used in the call to the server below","commit_id":"fda62ac70d7f51af933fcc348f29fbd31f91ff79"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"e85065ae8a11e920e370fc0996c1ff4d572ebe36","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @positional(2, enforcement\u003dpositional.WARN)"},{"line_number":66,"context_line":"    def create(self, name, domain\u003dNone, description\u003dNone,"},{"line_number":67,"context_line":"               enabled\u003dTrue, parent\u003dNone, is_domain\u003dTrue, **kwargs):"},{"line_number":68,"context_line":"        \"\"\"Create a project."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        :param str name: project name."}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_a1d22ece","line":67,"range":{"start_line":67,"start_character":42,"end_line":67,"end_character":56},"in_reply_to":"3aaa91ec_8cbc07dd","updated":"2018-09-28 00:44:21.000000000","message":"No use of this parameter is_domain\u003dtrue. Yes the default value should be False.","commit_id":"fda62ac70d7f51af933fcc348f29fbd31f91ff79"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"4fdc26d71e29c01932242519929df2c5200470d8","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @positional(2, enforcement\u003dpositional.WARN)"},{"line_number":66,"context_line":"    def create(self, name, domain\u003dNone, description\u003dNone,"},{"line_number":67,"context_line":"               enabled\u003dTrue, parent\u003dNone, is_domain\u003dTrue, **kwargs):"},{"line_number":68,"context_line":"        \"\"\"Create a project."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        :param str name: project name."}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_8cbc07dd","line":67,"range":{"start_line":67,"start_character":42,"end_line":67,"end_character":56},"in_reply_to":"7aa08908_5246a6c0","updated":"2016-07-01 13:07:53.000000000","message":"Agreed, I think this is wrong, it should be false","commit_id":"fda62ac70d7f51af933fcc348f29fbd31f91ff79"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"ca750db2371dbabfc69e7273eb9d060fbeff0166","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @positional(2, enforcement\u003dpositional.WARN)"},{"line_number":66,"context_line":"    def create(self, name, domain\u003dNone, description\u003dNone,"},{"line_number":67,"context_line":"               enabled\u003dTrue, parent\u003dNone, is_domain\u003dTrue, **kwargs):"},{"line_number":68,"context_line":"        \"\"\"Create a project."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        :param str name: project name."}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_5246a6c0","line":67,"range":{"start_line":67,"start_character":42,"end_line":67,"end_character":56},"in_reply_to":"7aa08908_678f9775","updated":"2016-06-17 14:46:09.000000000","message":"also, why defaulting to true? shouldn\u0027t be false?","commit_id":"fda62ac70d7f51af933fcc348f29fbd31f91ff79"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"59c4711eb596f951d120db008632e8491cc0f5ca","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        \"\"\"Create a project."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        :param str name: project name."},{"line_number":71,"context_line":"        :param domain: the project domain. (optional)"},{"line_number":72,"context_line":"        :type domain: :py:class:`keystoneclient.v3.domains.Domain` or str"},{"line_number":73,"context_line":"        :param str description: the project description. (optional)"},{"line_number":74,"context_line":"        :param boolean enabled: if the project is enabled. (optional)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_27b2af4c","line":71,"range":{"start_line":71,"start_character":23,"end_line":71,"end_character":53},"updated":"2016-06-07 23:30:12.000000000","message":"add a bit more details on which case it\u0027s optional/expected to be None","commit_id":"fda62ac70d7f51af933fcc348f29fbd31f91ff79"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"4fdc26d71e29c01932242519929df2c5200470d8","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        \"\"\"Create a project."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        :param str name: project name."},{"line_number":71,"context_line":"        :param domain: the project domain. (optional)"},{"line_number":72,"context_line":"        :type domain: :py:class:`keystoneclient.v3.domains.Domain` or str"},{"line_number":73,"context_line":"        :param str description: the project description. (optional)"},{"line_number":74,"context_line":"        :param boolean enabled: if the project is enabled. (optional)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_6c9d5b66","line":71,"range":{"start_line":71,"start_character":23,"end_line":71,"end_character":53},"in_reply_to":"7aa08908_27b2af4c","updated":"2016-07-01 13:07:53.000000000","message":"Done","commit_id":"fda62ac70d7f51af933fcc348f29fbd31f91ff79"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"8d93f84b3c8cee4af7c201660ecd144cdcc516de","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        if not is_domain and domain:"},{"line_number":114,"context_line":"            domain_id \u003d base.getid(domain)"},{"line_number":115,"context_line":"        else:"},{"line_number":116,"context_line":"            domain_id \u003d None"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        return super(ProjectManager, self).create("},{"line_number":119,"context_line":"            name\u003dname,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_8f2876e2","line":116,"updated":"2019-07-10 19:24:13.000000000","message":"There needs to be something that requires \u0027domain\u0027 if is_domain is False","commit_id":"73aca66ac3a4c6a7bb20029e92c3c0a5c16cd0e5"}]}