)]}'
{"id":"openstack%2Fpython-keystoneclient~240738","triplet_id":"openstack%2Fpython-keystoneclient~master~I4694cc121f8ad617a8c8e93e21bf6228f183dab6","project":"openstack/python-keystoneclient","branch":"master","topic":"bug/1479582","hashtags":[],"change_id":"I4694cc121f8ad617a8c8e93e21bf6228f183dab6","subject":"Replace repeated assertion with the loss","status":"MERGED","created":"2015-11-02 02:02:55.000000000","updated":"2015-11-03 02:11:59.000000000","submitted":"2015-11-03 02:11:58.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1ad2828438903f0db52ce3d9489470b6c868054c","_number":240738,"virtual_id_number":240738,"owner":{"_account_id":16292,"name":"zhengyue","email":"zhengyue@hihuron.com","username":"zhengyue"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":16289,"name":"Li Xipeng","email":"lixipeng@prophetech.cn","username":"hahaps"},{"value":0,"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},{"value":2,"date":"2015-11-03 02:11:58.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"},{"value":0,"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"recommended":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"all":[{"value":1,"date":"2015-11-03 01:28:48.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16289,"name":"Li Xipeng","email":"lixipeng@prophetech.cn","username":"hahaps"},{"value":1,"date":"2015-11-02 15:05:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":2,"date":"2015-11-03 01:09:42.000000000","_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":1,"date":"2015-11-02 03:24:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"},{"value":2,"date":"2015-11-02 15:18:00.000000000","_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"all":[{"value":0,"_account_id":16289,"name":"Li Xipeng","email":"lixipeng@prophetech.cn","username":"hahaps"},{"value":0,"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2015-11-02 14:59:21.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":1,"date":"2015-11-03 01:09:42.000000000","_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"date":"2015-11-02 02:05:36.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"},{"value":0,"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},{"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"},{"_account_id":16289,"name":"Li Xipeng","email":"lixipeng@prophetech.cn","username":"hahaps"},{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-11-02 02:05:36.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2015-11-02 03:24:27.000000000","updated_by":{"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"},"reviewer":{"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"},"state":"REVIEWER"},{"updated":"2015-11-02 14:59:21.000000000","updated_by":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"reviewer":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"state":"REVIEWER"},{"updated":"2015-11-02 15:05:10.000000000","updated_by":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"reviewer":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"state":"REVIEWER"},{"updated":"2015-11-02 15:18:00.000000000","updated_by":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"reviewer":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"state":"REVIEWER"},{"updated":"2015-11-03 01:09:42.000000000","updated_by":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"reviewer":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"state":"REVIEWER"},{"updated":"2015-11-03 01:28:48.000000000","updated_by":{"_account_id":16289,"name":"Li Xipeng","email":"lixipeng@prophetech.cn","username":"hahaps"},"reviewer":{"_account_id":16289,"name":"Li Xipeng","email":"lixipeng@prophetech.cn","username":"hahaps"},"state":"REVIEWER"},{"updated":"2015-11-03 02:11:58.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"2cf55cd5dcf94b039994d3c8602da360177e246b","author":{"_account_id":16292,"name":"zhengyue","email":"zhengyue@hihuron.com","username":"zhengyue"},"date":"2015-11-02 02:02:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6f373547f7338eb05e1005b22ec536aee18d7946","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-02 03:15:21.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/38/240738/1/check/gate-python-keystoneclient-python26/d035647/ : SUCCESS in 2m 11s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/38/240738/1/check/gate-python-keystoneclient-pep8/4db98f0/ : SUCCESS in 1m 53s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/38/240738/1/check/gate-python-keystoneclient-docs/6398885//doc/build/html/ : SUCCESS in 2m 15s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/38/240738/1/check/gate-python-keystoneclient-python27/f5ded86/ : SUCCESS in 2m 04s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/38/240738/1/check/gate-python-keystoneclient-python34/dbf4951/ : SUCCESS in 2m 27s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/38/240738/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/d3eb173/ : SUCCESS in 1h 09m 00s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/38/240738/1/check/gate-keystoneclient-dsvm-functional/1b0bdef/ : SUCCESS in 31m 46s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/38/240738/1/check/gate-python-keystoneclient-tox-bandit/7418db6/ : SUCCESS in 2m 04s","accounts_in_message":[],"_revision_number":1},{"id":"01e396200baa0780525e7cf0717b73955a8dcedb","author":{"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"},"date":"2015-11-02 03:24:27.000000000","message":"Patch Set 1: Code-Review+1\n\nLooks Good","accounts_in_message":[],"_revision_number":1},{"id":"3788f01fdafa0e890d822127a59be1d36efeabcc","author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"date":"2015-11-02 15:05:10.000000000","message":"Patch Set 1: Code-Review+1\n\nGood Catch.  Here is the doc to support this change: http://developer.openstack.org/api-ref-identity-v2.html#identity-auth-v2\n\nIs there any reason why this would have be done in the first place?","accounts_in_message":[],"_revision_number":1},{"id":"b514e179ac11a122d9f7a5cc901d58231d705ec1","author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"date":"2015-11-02 15:18:00.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"cf59e9e36583909baa5939ae8db54da76840e9b0","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2015-11-03 01:09:42.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nNo reason, just looks like a simple mistake.","accounts_in_message":[],"_revision_number":1},{"id":"82c62efaa558d2307b9d8cdda5c30b38da538579","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-03 01:09:49.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"25a655c416287150ec0dc708cda7f6d1a3bb16bc","author":{"_account_id":16289,"name":"Li Xipeng","email":"lixipeng@prophetech.cn","username":"hahaps"},"date":"2015-11-03 01:28:48.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"a8030be1f9ec5692076033a13a28ea9a7035fac6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-03 02:11:58.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/38/240738/1/gate/gate-python-keystoneclient-python26/e83eb72/ : SUCCESS in 2m 38s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/38/240738/1/gate/gate-python-keystoneclient-docs/d283421//doc/build/html/ : SUCCESS in 2m 15s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/38/240738/1/gate/gate-python-keystoneclient-pep8/898316a/ : SUCCESS in 2m 10s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/38/240738/1/gate/gate-python-keystoneclient-python27/875b5a2/ : SUCCESS in 2m 42s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/38/240738/1/gate/gate-python-keystoneclient-python34/df9a65a/ : SUCCESS in 3m 24s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/38/240738/1/gate/gate-tempest-dsvm-neutron-src-python-keystoneclient/fe9ed54/ : SUCCESS in 1h 02m 07s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/38/240738/1/gate/gate-keystoneclient-dsvm-functional/178d4d9/ : SUCCESS in 21m 24s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/38/240738/1/gate/gate-python-keystoneclient-tox-bandit/dd98bf2/ : SUCCESS in 2m 35s","accounts_in_message":[],"_revision_number":1},{"id":"0ddcddd1632104bbe338889ceb12d48cb1016e5f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-03 02:11:59.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"355e47abe1a0e62cf14990571a1b21615a1da997","revisions":{"355e47abe1a0e62cf14990571a1b21615a1da997":{"kind":"REWORK","_number":1,"created":"2015-11-02 02:02:55.000000000","uploader":{"_account_id":16292,"name":"zhengyue","email":"zhengyue@hihuron.com","username":"zhengyue"},"ref":"refs/changes/38/240738/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/38/240738/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/38/240738/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/38/240738/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/38/240738/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/38/240738/1"}}},"commit":{"parents":[{"commit":"1c0d4f9e0fc3c3bb903a7300a2b92bb9ef9b6538","subject":"Merge \"Mark abstractmethod bodies with nocover\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/1c0d4f9e0fc3c3bb903a7300a2b92bb9ef9b6538"}]}],"author":{"name":"ZhengYue","email":"zhengyue@hihuron.com","date":"2015-10-10 20:19:32.000000000","tz":480},"committer":{"name":"ZhengYue","email":"zhengyue@hihuron.com","date":"2015-10-10 20:26:25.000000000","tz":480},"subject":"Replace repeated assertion with the loss","message":"Replace repeated assertion with the loss\n\nIn unit tests, there are two assertions for \u0027adminURL\u0027,\nbut lost one for \u0027internalURL\u0027. Fixed the problem.\n\nChange-Id: I4694cc121f8ad617a8c8e93e21bf6228f183dab6\nCloses-bug: #1479582\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/355e47abe1a0e62cf14990571a1b21615a1da997"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/355e47abe1a0e62cf14990571a1b21615a1da997"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}