)]}'
{"keystoneclient/v3/regions.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"3271c30e7f5bab5d472f5472c2e8c4b483b0c347","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        * parent_region_id: string that is the id field for an pre-existing"},{"line_number":23,"context_line":"          region in the backend.  Allows for hierarchical region"},{"line_number":24,"context_line":"          organization"},{"line_number":25,"context_line":"        * enabled: determines whether the endpoint appears in the catalog."},{"line_number":26,"context_line":"          Defaults to True"},{"line_number":27,"context_line":"    \"\"\""},{"line_number":28,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_73b48fd0","side":"PARENT","line":25,"updated":"2015-11-10 13:33:23.000000000","message":"this shows that it was \u0027copy-pasta\u0027 for a while :(","commit_id":"355e47abe1a0e62cf14990571a1b21615a1da997"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7b50f60ef897a0b75dde1acfaffc4458f9fc0b6d","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    collection_key \u003d \u0027regions\u0027"},{"line_number":33,"context_line":"    key \u003d \u0027region\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def create(self, id\u003dNone, description\u003dNone, parent_region\u003dNone,"},{"line_number":36,"context_line":"               **kwargs):"},{"line_number":37,"context_line":"        \"\"\"Create a Catalog region."},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_830745c9","line":35,"updated":"2015-11-10 22:11:55.000000000","message":"This isn\u0027t backwards-compatible. If someone had written a program that does region.create(enabled\u003dTrue) then it will start failing once we release the library. It will have to go through the normal deprecation period.\n\nThis comment applies to update() also.","commit_id":"6256ff06975626b5c842f5a3f26568e6c023ba0b"},{"author":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"change_message_id":"2c493eac6e64025dace237b926b04bd1a24b51fe","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    collection_key \u003d \u0027regions\u0027"},{"line_number":33,"context_line":"    key \u003d \u0027region\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def create(self, id\u003dNone, description\u003dNone, parent_region\u003dNone,"},{"line_number":36,"context_line":"               **kwargs):"},{"line_number":37,"context_line":"        \"\"\"Create a Catalog region."},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_7281c8c2","line":35,"in_reply_to":"da85f559_19fbc67a","updated":"2015-11-11 02:16:26.000000000","message":"enabled argument goes in extra column in SQL backend and can not be updated even if enabled argument is alive.\n\nhttps://github.com/openstack/keystone/blob/master/keystone/catalog/backends/sql.py#L53\n\nwe need to deprecate it.","commit_id":"6256ff06975626b5c842f5a3f26568e6c023ba0b"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"e76427667a29d788fdbc54a5a1e87213d329ab79","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    collection_key \u003d \u0027regions\u0027"},{"line_number":33,"context_line":"    key \u003d \u0027region\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def create(self, id\u003dNone, description\u003dNone, parent_region\u003dNone,"},{"line_number":36,"context_line":"               **kwargs):"},{"line_number":37,"context_line":"        \"\"\"Create a Catalog region."},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_d9abfe73","line":35,"in_reply_to":"da85f559_830745c9","updated":"2015-11-10 23:14:17.000000000","message":"@Brant, \n\nThis is still not backwards compatible, but in your example the enabled would just end up in the **kwargs.\n\nThe issue surfaces if someone did the argument as positional:\n\nregion.create(\u003cid\u003e, \u003cdescription\u003e, \u003cenabled\u003e, \u003cparent_region\u003e).","commit_id":"6256ff06975626b5c842f5a3f26568e6c023ba0b"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"f70ceaaed5d268ba95d2a4b4216f9e8afef2e4de","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    collection_key \u003d \u0027regions\u0027"},{"line_number":33,"context_line":"    key \u003d \u0027region\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def create(self, id\u003dNone, description\u003dNone, parent_region\u003dNone,"},{"line_number":36,"context_line":"               **kwargs):"},{"line_number":37,"context_line":"        \"\"\"Create a Catalog region."},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_19fbc67a","line":35,"in_reply_to":"da85f559_d9abfe73","updated":"2015-11-10 23:17:14.000000000","message":"yeah, this had me confused, it would only break if it were positional.\n\n/me grumbles\n\nlooks like we need to deprecate it","commit_id":"6256ff06975626b5c842f5a3f26568e6c023ba0b"}]}