)]}'
{"id":"openstack%2Fpython-keystoneclient~24370","triplet_id":"openstack%2Fpython-keystoneclient~master~Ib24f5386fa1ffe0e0365548840f0cfeaae36f548","project":"openstack/python-keystoneclient","branch":"master","topic":"bug/1154806","hashtags":[],"change_id":"Ib24f5386fa1ffe0e0365548840f0cfeaae36f548","subject":"Make auth_token lazy load the auth_version.","status":"MERGED","created":"2013-03-13 21:36:41.000000000","updated":"2013-03-14 11:11:46.000000000","submitted":"2013-03-14 11:11:46.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c8586ceb58b822ff96056ac5f49f3e1db51d1bb8","_number":24370,"virtual_id_number":24370,"owner":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2013-03-14 11:11:46.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"value":0,"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},{"value":0,"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"value":0,"date":"2013-03-14 10:12:40.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},{"value":2,"date":"2013-03-14 05:22:22.000000000","_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-03-13 21:59:07.000000000","_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"value":1,"date":"2013-03-14 10:12:40.000000000","_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},{"value":0,"date":"2013-03-14 05:22:22.000000000","_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-03-14 05:22:22.000000000","updated_by":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"reviewer":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"state":"REVIEWER"},{"updated":"2013-03-14 10:12:40.000000000","updated_by":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"reviewer":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"state":"REVIEWER"},{"updated":"2013-03-14 11:11:46.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"b7f4339a5daf02626d909286f63f9200c9d7ba1f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-13 21:38:59.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/24370/1/check/gate-python-keystoneclient-pep8/897 : FAILURE\n- gate-python-keystoneclient-docs : SKIPPED\n- gate-python-keystoneclient-python26 : SKIPPED\n- gate-python-keystoneclient-python27 : SKIPPED\n- gate-tempest-devstack-vm-full : SKIPPED\n- gate-tempest-devstack-vm-postgres-full : SKIPPED\n- gate-tempest-devstack-vm-quantum : SKIPPED\n","accounts_in_message":[],"_revision_number":1},{"id":"85a835baa0707e6f10074564228245c8b2bde2a1","author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"date":"2013-03-13 21:59:07.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"9f43b31b63333463fe125c705fd047257c206a2d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-13 22:56:23.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/24370/2/check/gate-python-keystoneclient-pep8/900 : SUCCESS\n- http://logs.openstack.org/24370/2/check/gate-python-keystoneclient-docs/751 : SUCCESS\n- http://logs.openstack.org/24370/2/check/gate-python-keystoneclient-python26/823 : SUCCESS\n- http://logs.openstack.org/24370/2/check/gate-python-keystoneclient-python27/829 : SUCCESS\n- http://logs.openstack.org/24370/2/check/gate-tempest-devstack-vm-full/8795 : SUCCESS\n- http://logs.openstack.org/24370/2/check/gate-tempest-devstack-vm-postgres-full/8511 : SUCCESS\n- http://logs.openstack.org/24370/2/check/gate-tempest-devstack-vm-quantum/14080 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"406c755b8d034f97cc190345dd142896f4fd89bb","author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"date":"2013-03-14 05:22:22.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"bee34f9076b025370b92aa67e2c3b994ca496e58","author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"date":"2013-03-14 10:12:40.000000000","message":"Patch Set 2: Approved\n\n(2 inline comments)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"bf80c47e92a47226e4a51adb5487d80b3ec38139","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-14 10:12:42.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"8e89e3c9b32178071aa103bcc1b9da2a1a09a8e7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-14 11:11:46.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2},{"id":"c6f3d443d8e2aa297430277040390075e555e891","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-14 11:11:46.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/24370/2/gate/gate-python-keystoneclient-docs/758 : SUCCESS\n- http://logs.openstack.org/24370/2/gate/gate-python-keystoneclient-pep8/908 : SUCCESS\n- http://logs.openstack.org/24370/2/gate/gate-python-keystoneclient-python26/830 : SUCCESS\n- http://logs.openstack.org/24370/2/gate/gate-python-keystoneclient-python27/836 : SUCCESS\n- http://logs.openstack.org/24370/2/gate/gate-tempest-devstack-vm-full/8861 : SUCCESS\n- http://logs.openstack.org/24370/2/gate/gate-tempest-devstack-vm-postgres-full/8577 : SUCCESS\n- http://logs.openstack.org/24370/2/gate/gate-tempest-devstack-vm-quantum/14162 : SUCCESS\n","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"db7603824ff541b4319bb193d5861ac6af570b37","revisions":{"9d0972c99a85d11cbe8d6694cb7bd17f59ccafd0":{"kind":"REWORK","_number":1,"created":"2013-03-13 21:36:41.000000000","uploader":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"ref":"refs/changes/70/24370/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/70/24370/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/70/24370/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/70/24370/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/70/24370/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/70/24370/1"}}},"commit":{"parents":[{"commit":"d782a998474d92d4299b4404b69442f0288efc3b","subject":"Fix auth-token middleware to understand v3 tokens","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/d782a998474d92d4299b4404b69442f0288efc3b"}]}],"author":{"name":"Dan Prince","email":"dprince@redhat.com","date":"2013-03-13 21:33:22.000000000","tz":-240},"committer":{"name":"Dan Prince","email":"dprince@redhat.com","date":"2013-03-13 21:33:22.000000000","tz":-240},"subject":"Make auth_token lazy load the auth_version.","message":"Make auth_token lazy load the auth_version.\n\nUpdates recent changes to the auth_token middleware (this\nis a regression in d782a99) so that self.auth_version is\nlazy loaded.\n\nThis fixes issues where other openstack services would fail\nto startup correctly if Keystone is not running. The issue\nwas auth_token was trying to make a request to \u0027/\u0027 to get\nversions information on startup to \"autodetect\" the correct\nversion to use.\n\nThis patch fixes startup issues by moving the version detection\nso that it is lazy loaded right before it is actually used.\n\nThis issue should fix SmokeStack :)\n\nFixes LP Bug #1154806.\n\nChange-Id: Ib24f5386fa1ffe0e0365548840f0cfeaae36f548\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/9d0972c99a85d11cbe8d6694cb7bd17f59ccafd0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/9d0972c99a85d11cbe8d6694cb7bd17f59ccafd0"}]},"branch":"refs/heads/master"},"db7603824ff541b4319bb193d5861ac6af570b37":{"kind":"REWORK","_number":2,"created":"2013-03-13 21:59:07.000000000","uploader":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"ref":"refs/changes/70/24370/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/70/24370/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/70/24370/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/70/24370/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/70/24370/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/70/24370/2"}}},"commit":{"parents":[{"commit":"d782a998474d92d4299b4404b69442f0288efc3b","subject":"Fix auth-token middleware to understand v3 tokens","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/d782a998474d92d4299b4404b69442f0288efc3b"}]}],"author":{"name":"Dan Prince","email":"dprince@redhat.com","date":"2013-03-13 21:33:22.000000000","tz":-240},"committer":{"name":"Dan Prince","email":"dprince@redhat.com","date":"2013-03-13 21:58:59.000000000","tz":-240},"subject":"Make auth_token lazy load the auth_version.","message":"Make auth_token lazy load the auth_version.\n\nUpdates recent changes to the auth_token middleware (this\nis a regression in d782a99) so that self.auth_version is\nlazy loaded.\n\nThis fixes issues where other openstack services would fail\nto startup correctly if Keystone is not running. The issue\nwas auth_token was trying to make a request to \u0027/\u0027 to get\nversions information on startup to \"autodetect\" the correct\nversion to use.\n\nThis patch fixes startup issues by moving the version detection\nso that it is lazy loaded right before it is actually used.\n\nThis issue should fix SmokeStack :)\n\nFixes LP Bug #1154806.\n\nChange-Id: Ib24f5386fa1ffe0e0365548840f0cfeaae36f548\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/db7603824ff541b4319bb193d5861ac6af570b37"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/db7603824ff541b4319bb193d5861ac6af570b37"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}