)]}'
{"keystoneclient/auth/tokenless_auth.py":[{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"59018677dde4aefe3f256da010358ff2e68ef3b6","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import logging"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from keystoneclient import auth"},{"line_number":16,"context_line":"from oslo_config import cfg"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_b9197f8a","line":14,"updated":"2015-11-17 21:50:15.000000000","message":"You need to line up your imports. the two from keystoneclient should be together and after oslo.","commit_id":"af2286507a8ebb1d199b430d306c9f533b99a595"},{"author":{"_account_id":11387,"name":"Sam Leong","email":"chio-fai-sam.leong@hpe.com","username":"Chioleong"},"change_message_id":"20704e94b3b1e02ec17e246f74adb74b15d82bc4","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import logging"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from keystoneclient import auth"},{"line_number":16,"context_line":"from oslo_config import cfg"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_abba86be","line":14,"in_reply_to":"ba8a016a_b9197f8a","updated":"2015-11-17 22:04:34.000000000","message":"yep, you got it.","commit_id":"af2286507a8ebb1d199b430d306c9f533b99a595"},{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"59018677dde4aefe3f256da010358ff2e68ef3b6","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        elif self._domain_name:"},{"line_number":80,"context_line":"            scope_headers[\u0027X-Domain-Name\u0027] \u003d self._domain_name"},{"line_number":81,"context_line":"        else:"},{"line_number":82,"context_line":"            _LOG.warning(_LW("},{"line_number":83,"context_line":"                \u0027Neither Project nor Domain scope was provided.\u0027))"},{"line_number":84,"context_line":"            return None"},{"line_number":85,"context_line":"        return scope_headers"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_cb358ada","line":82,"updated":"2015-11-17 21:50:15.000000000","message":"Why LW and not just _()?","commit_id":"af2286507a8ebb1d199b430d306c9f533b99a595"}],"keystoneclient/tests/unit/auth/test_tokenless_auth.py":[{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"59018677dde4aefe3f256da010358ff2e68ef3b6","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        a \u003d tokenless_auth.TokenlessAuth(identity_uri\u003dself.TEST_URL,"},{"line_number":31,"context_line":"                                         domain_id\u003ddomain_id)"},{"line_number":32,"context_line":"        s \u003d session.Session(auth\u003da)"},{"line_number":33,"context_line":"        s.get(self.TEST_URL, authenticated\u003dTrue)"},{"line_number":34,"context_line":"        self.assertRequestHeaderEqual(\u0027X-Domain-Id\u0027, domain_id)"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_abeda626","line":32,"updated":"2015-11-17 21:50:15.000000000","message":"Why no factor out the session and TokenlessAuth creation into a helper method to cut down on repitition. DRY is good!","commit_id":"af2286507a8ebb1d199b430d306c9f533b99a595"},{"author":{"_account_id":11387,"name":"Sam Leong","email":"chio-fai-sam.leong@hpe.com","username":"Chioleong"},"change_message_id":"20704e94b3b1e02ec17e246f74adb74b15d82bc4","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        a \u003d tokenless_auth.TokenlessAuth(identity_uri\u003dself.TEST_URL,"},{"line_number":31,"context_line":"                                         domain_id\u003ddomain_id)"},{"line_number":32,"context_line":"        s \u003d session.Session(auth\u003da)"},{"line_number":33,"context_line":"        s.get(self.TEST_URL, authenticated\u003dTrue)"},{"line_number":34,"context_line":"        self.assertRequestHeaderEqual(\u0027X-Domain-Id\u0027, domain_id)"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_0bccf268","line":32,"in_reply_to":"ba8a016a_abeda626","updated":"2015-11-17 22:04:34.000000000","message":"agree.","commit_id":"af2286507a8ebb1d199b430d306c9f533b99a595"}]}