)]}'
{"id":"openstack%2Fpython-keystoneclient~246615","triplet_id":"openstack%2Fpython-keystoneclient~master~I14dd070e68cab9dd5c136fe1990ffe61f1ef4878","project":"openstack/python-keystoneclient","branch":"master","topic":"bp/keystone-tokenless-authz-with-x509-ssl-client-cert","hashtags":[],"change_id":"I14dd070e68cab9dd5c136fe1990ffe61f1ef4878","subject":"Auth plugin for X.509 tokenless authz","status":"ABANDONED","created":"2015-11-17 21:42:39.000000000","updated":"2016-01-11 21:00:30.000000000","total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"44a074757da2fff8e95c37e97dceae99a4a451b1","_number":246615,"virtual_id_number":246615,"owner":{"_account_id":11387,"name":"Sam Leong","email":"chio-fai-sam.leong@hpe.com","username":"Chioleong"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},{"value":1,"date":"2015-11-17 23:55:55.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"date":"2015-11-17 22:04:34.000000000","_account_id":11387,"name":"Sam Leong","email":"chio-fai-sam.leong@hpe.com","username":"Chioleong"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"disliked":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"all":[{"value":-2,"date":"2015-11-17 22:20:31.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":-1,"date":"2015-11-17 21:50:15.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2015-11-17 21:52:14.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11387,"name":"Sam Leong","email":"chio-fai-sam.leong@hpe.com","username":"Chioleong"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":11387,"name":"Sam Leong","email":"chio-fai-sam.leong@hpe.com","username":"Chioleong"},"all":[{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":-1,"date":"2015-11-17 22:43:06.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":11387,"name":"Sam Leong","email":"chio-fai-sam.leong@hpe.com","username":"Chioleong"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":11387,"name":"Sam Leong","email":"chio-fai-sam.leong@hpe.com","username":"Chioleong"},{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-11-17 21:50:15.000000000","updated_by":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"reviewer":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"state":"REVIEWER"},{"updated":"2015-11-17 21:52:14.000000000","updated_by":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"reviewer":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"state":"REVIEWER"},{"updated":"2015-11-17 22:20:31.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2015-11-17 23:55:55.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"d38c9f78d6b30115bdac040db5e2f0dba2504400","author":{"_account_id":11387,"name":"Sam Leong","email":"chio-fai-sam.leong@hpe.com","username":"Chioleong"},"date":"2015-11-17 21:42:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"59018677dde4aefe3f256da010358ff2e68ef3b6","author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"date":"2015-11-17 21:50:15.000000000","message":"Patch Set 1: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"c34c1bb9b014df133a6b656a06d52e5eeb3aa45d","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-11-17 21:52:14.000000000","message":"Patch Set 1: Code-Review-1\n\nauth plugins go in keystoneauth.","accounts_in_message":[],"_revision_number":1},{"id":"20704e94b3b1e02ec17e246f74adb74b15d82bc4","author":{"_account_id":11387,"name":"Sam Leong","email":"chio-fai-sam.leong@hpe.com","username":"Chioleong"},"date":"2015-11-17 22:04:34.000000000","message":"Patch Set 1:\n\n(2 comments)\n\n@Brant, I understand that auth plugins should be in keystoneauth. However, all the auth plugins so far are still located within keystoneclient itself and have not been moved to the keystoneauth yet. Therefore, I was thinking to implement here just like the others.","accounts_in_message":[],"_revision_number":1},{"id":"1e7538e135e4332dfe39ae75332d9cf0907a1d4f","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-11-17 22:20:31.000000000","message":"Patch Set 1: Code-Review-2\n\nshouldn\u0027t this go into keystoneauth?","accounts_in_message":[],"_revision_number":1},{"id":"6380875d872ac55271624ff31913fc8c53832fc1","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-11-17 22:21:15.000000000","message":"Patch Set 1:\n\nsam, they are all here: https://github.com/openstack/keystoneauth/tree/master/keystoneauth1/identity/v3","accounts_in_message":[],"_revision_number":1},{"id":"c3777d4ae0afca0368d442f9a7b6e4844f9cc7cd","author":{"_account_id":11387,"name":"Sam Leong","email":"chio-fai-sam.leong@hpe.com","username":"Chioleong"},"date":"2015-11-17 22:39:31.000000000","message":"Patch Set 1:\n\nSteve, what I meant was keystonemiddleware is still referencing the auth plugins from keystoneclient. \n\nJamie has already got the pending review https://review.openstack.org/#/c/235090/ for making that switch. I\u0027m going to abandon this patch and submit it to keystoneauth after Jamie\u0027s landed.","accounts_in_message":[],"_revision_number":1},{"id":"67068c59c13e57bcb62750940f39dae136193d20","author":{"_account_id":11387,"name":"Sam Leong","email":"chio-fai-sam.leong@hpe.com","username":"Chioleong"},"date":"2015-11-17 22:39:46.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1},{"id":"192b95a0c8249e41c90bbe47a3877b743f816592","author":{"_account_id":11387,"name":"Sam Leong","email":"chio-fai-sam.leong@hpe.com","username":"Chioleong"},"date":"2015-11-17 22:42:43.000000000","message":"Restored\n\nwill mark it as WIP instead.","accounts_in_message":[],"_revision_number":1},{"id":"31bf3ce71f603f7ff2508b9dee0844e4502f240c","author":{"_account_id":11387,"name":"Sam Leong","email":"chio-fai-sam.leong@hpe.com","username":"Chioleong"},"date":"2015-11-17 22:43:06.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"50f03f3df0d965efd777462be23c1900211c10cd","author":{"_account_id":11387,"name":"Sam Leong","email":"chio-fai-sam.leong@hpe.com","username":"Chioleong"},"date":"2015-11-17 22:43:43.000000000","message":"Patch Set 1:\n\nand comments are welcome in the meantime ;-)","accounts_in_message":[],"_revision_number":1},{"id":"087aca4fc09739067fd25152380d6c601836b054","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-17 23:55:55.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-python26 http://logs.openstack.org/15/246615/1/check/gate-python-keystoneclient-python26/946b909/ : SUCCESS in 2m 25s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/15/246615/1/check/gate-python-keystoneclient-pep8/86f7ba3/ : SUCCESS in 3m 23s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/15/246615/1/check/gate-python-keystoneclient-docs/25311e9//doc/build/html/ : SUCCESS in 3m 23s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/15/246615/1/check/gate-python-keystoneclient-python27/9b1e1b1/ : SUCCESS in 3m 08s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/15/246615/1/check/gate-python-keystoneclient-python34/fad57a3/ : SUCCESS in 3m 52s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/15/246615/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/04f307b/ : SUCCESS in 1h 09m 05s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/15/246615/1/check/gate-keystoneclient-dsvm-functional/d3647bb/ : SUCCESS in 28m 54s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/15/246615/1/check/gate-python-keystoneclient-tox-bandit/e5c693b/ : SUCCESS in 3m 16s","accounts_in_message":[],"_revision_number":1},{"id":"b6f1ba9b7302eba786fc98f8579ad55e89534643","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-01-11 21:00:30.000000000","message":"Abandoned\n\nit\u0027s been ~60 days since a negative review and no change. propose the new content to keystoneauth as keystonemiddleware is now using keystoneauth","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"af2286507a8ebb1d199b430d306c9f533b99a595","revisions":{"af2286507a8ebb1d199b430d306c9f533b99a595":{"kind":"REWORK","_number":1,"created":"2015-11-17 21:42:39.000000000","uploader":{"_account_id":11387,"name":"Sam Leong","email":"chio-fai-sam.leong@hpe.com","username":"Chioleong"},"ref":"refs/changes/15/246615/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/15/246615/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/15/246615/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/15/246615/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/15/246615/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/15/246615/1"}}},"commit":{"parents":[{"commit":"30ed4c313f90a5b877da91afe1a74150b99c271c","subject":"Merge \"update incorrect docstring for regions\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/30ed4c313f90a5b877da91afe1a74150b99c271c"}]}],"author":{"name":"chioleong","email":"chio-fai-sam.leong@hpe.com","date":"2015-11-17 21:41:21.000000000","tz":-480},"committer":{"name":"chioleong","email":"chio-fai-sam.leong@hpe.com","date":"2015-11-17 21:42:36.000000000","tz":-480},"subject":"Auth plugin for X.509 tokenless authz","message":"Auth plugin for X.509 tokenless authz\n\nAn auth plugin that allows service clients to be authenticated\nwith the X.509 tokenless authz. Typical configured options\ndefined on the service client side should look like the following -\n\ncertfile\u003d/opt/service_client.crt\nkeyfile\u003d/opt/service_client.key\ncafile\u003d/opt/ca.crt\nidentity_uri\u003dhttps://keystone:5000/\nauth_plugin\u003dtokenless_auth\ndomain_name\u003dmy_service_domain\n\nimplements bp keystone-tokenless-authz-with-x509-ssl-client-cert\n\nChange-Id: I14dd070e68cab9dd5c136fe1990ffe61f1ef4878\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/af2286507a8ebb1d199b430d306c9f533b99a595"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/af2286507a8ebb1d199b430d306c9f533b99a595"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}