)]}'
{"keystoneclient/base.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"37c74f92d00ac0449fb53ffa4c77b128e8dbf719","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        return len(self.collection)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def sort(self, *args, **kwargs):"},{"line_number":94,"context_line":"        return self.collection.sort(*args, **kwargs)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"class Manager(object):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_ffe39431","line":94,"updated":"2015-12-01 11:22:52.000000000","message":"good catch on adding this, this should take care of client sorting the list returned with .sort()","commit_id":"df3ded49051ddf644ff5458e679eca24d742631f"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"18bd49a6874b702f15579355c0de8d63334524d5","unresolved":false,"context_lines":[{"line_number":154,"context_line":"            pass"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        objects \u003d [obj_class(self, res, loaded\u003dTrue) for res in data if res]"},{"line_number":157,"context_line":"        return KeystoneReturnedList(objects, truncated\u003dtruncated)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def _get(self, url, response_key, **kwargs):"},{"line_number":160,"context_line":"        \"\"\"Get an object from collection."}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_fac72762","line":157,"updated":"2015-12-10 07:58:07.000000000","message":"to preserve old behaviour, we could:\n\n  if not truncated:\n    return objects\n  else:\n     return KeystoneReturnedList(objects, truncated\u003dtruncated)","commit_id":"e3daae6f2563fb8ac4d21b8d5433ccbccb871359"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"4b258353521328179b0b758b6681c2fa4820b3aa","unresolved":false,"context_lines":[{"line_number":154,"context_line":"            pass"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        objects \u003d [obj_class(self, res, loaded\u003dTrue) for res in data if res]"},{"line_number":157,"context_line":"        return KeystoneReturnedList(objects, truncated\u003dtruncated)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def _get(self, url, response_key, **kwargs):"},{"line_number":160,"context_line":"        \"\"\"Get an object from collection."}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_babbdf74","line":157,"in_reply_to":"7a740942_fac72762","updated":"2015-12-10 08:12:23.000000000","message":"I would rather not do it. This will make the users do something like\n\n users \u003d list_users()\n truncated \u003d getattr(users, \u0027truncated\u0027, False)\n\nwhich is meh.\n\nDo you think the change will break current behaviour? How?","commit_id":"e3daae6f2563fb8ac4d21b8d5433ccbccb871359"}],"keystoneclient/tests/unit/v3/utils.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"37c74f92d00ac0449fb53ffa4c77b128e8dbf719","unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        # `truncated` attribute should exist even if it was not sent by the"},{"line_number":274,"context_line":"        # server and should be False in this case"},{"line_number":275,"context_line":"        expected_truncated \u003d False"},{"line_number":276,"context_line":"        if truncated:"},{"line_number":277,"context_line":"            expected_truncated \u003d truncated"},{"line_number":278,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_bce19ad2","line":275,"updated":"2015-12-01 11:22:52.000000000","message":"if not truncated is passed, it will default to False. \n\nThat mean expected_truncated will always be equal to truncated? Is this code still necessary?","commit_id":"df3ded49051ddf644ff5458e679eca24d742631f"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"bc1901e7a68bf0e903c496eea17b58ddf2c84548","unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        # `truncated` attribute should exist even if it was not sent by the"},{"line_number":274,"context_line":"        # server and should be False in this case"},{"line_number":275,"context_line":"        expected_truncated \u003d False"},{"line_number":276,"context_line":"        if truncated:"},{"line_number":277,"context_line":"            expected_truncated \u003d truncated"},{"line_number":278,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_5ae74eac","line":275,"in_reply_to":"9a8ffd7b_1a72267d","updated":"2015-12-01 11:49:19.000000000","message":"Done","commit_id":"df3ded49051ddf644ff5458e679eca24d742631f"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"f896e7174d33fbc6a87a6c68daaad8c66c76ca77","unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        # `truncated` attribute should exist even if it was not sent by the"},{"line_number":274,"context_line":"        # server and should be False in this case"},{"line_number":275,"context_line":"        expected_truncated \u003d False"},{"line_number":276,"context_line":"        if truncated:"},{"line_number":277,"context_line":"            expected_truncated \u003d truncated"},{"line_number":278,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_1a72267d","line":275,"in_reply_to":"9a8ffd7b_bce19ad2","updated":"2015-12-01 11:39:15.000000000","message":"thank you, missed this one. `truncated\u003dFalse` above should be `truncated\u003dNone`. The idea here is that we want to catch all cases: when `truncated` is not set, when it\u0027s False and when it\u0027s True.","commit_id":"df3ded49051ddf644ff5458e679eca24d742631f"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"6679890039007b340ad27b163b968a325038a037","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    def encode(self, entity, truncated\u003dNone):"},{"line_number":169,"context_line":"        encoded \u003d {}"},{"line_number":170,"context_line":"        if truncated is not None:"},{"line_number":171,"context_line":"            encoded \u003d {\u0027truncated\u0027: truncated}"},{"line_number":172,"context_line":"        if isinstance(entity, dict):"},{"line_number":173,"context_line":"            encoded[self.key] \u003d entity"},{"line_number":174,"context_line":"            return encoded"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_1a00f3a9","line":171,"updated":"2015-12-10 07:56:54.000000000","message":"the dict is already created, just:\n\n  encoded[\u0027truncated\u0027] \u003d truncated","commit_id":"e3daae6f2563fb8ac4d21b8d5433ccbccb871359"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"4b258353521328179b0b758b6681c2fa4820b3aa","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    def encode(self, entity, truncated\u003dNone):"},{"line_number":169,"context_line":"        encoded \u003d {}"},{"line_number":170,"context_line":"        if truncated is not None:"},{"line_number":171,"context_line":"            encoded \u003d {\u0027truncated\u0027: truncated}"},{"line_number":172,"context_line":"        if isinstance(entity, dict):"},{"line_number":173,"context_line":"            encoded[self.key] \u003d entity"},{"line_number":174,"context_line":"            return encoded"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_7a6c9708","line":171,"in_reply_to":"7a740942_1a00f3a9","updated":"2015-12-10 08:12:23.000000000","message":"Done","commit_id":"e3daae6f2563fb8ac4d21b8d5433ccbccb871359"}]}