)]}'
{"keystoneclient/v3/contrib/endpoint_policy.py":[{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"6e023a3f0ba7461b3fe8eb98a4763b5ecd26dc38","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                   \u0027endpoint_id\u0027: endpoint_id}"},{"line_number":38,"context_line":"        return action(url\u003durl)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def create_policy_association_for_endpoint(self, policy, endpoint):"},{"line_number":41,"context_line":"        \"\"\"Create an association between a policy and an endpoint.\"\"\""},{"line_number":42,"context_line":"        self._act_on_policy_association_for_endpoint("},{"line_number":43,"context_line":"            policy, endpoint, self._put)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_ec6b86ef","line":40,"range":{"start_line":40,"start_character":8,"end_line":40,"end_character":45},"updated":"2016-02-25 01:23:39.000000000","message":"Why this function gets a different behavior from this?\nhttps://review.openstack.org/#/c/267449/7/keystoneclient/v2_0/users.py@62","commit_id":"de00d768071b5e26206101106a1a8e22eff037f2"},{"author":{"_account_id":11704,"name":"Maho Koshiya","email":"koshiya.maho@po.ntt-tx.co.jp","username":"koshi-m"},"change_message_id":"649760f99ff6609b975021f3577195abbf84a041","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                   \u0027endpoint_id\u0027: endpoint_id}"},{"line_number":38,"context_line":"        return action(url\u003durl)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def create_policy_association_for_endpoint(self, policy, endpoint):"},{"line_number":41,"context_line":"        \"\"\"Create an association between a policy and an endpoint.\"\"\""},{"line_number":42,"context_line":"        self._act_on_policy_association_for_endpoint("},{"line_number":43,"context_line":"            policy, endpoint, self._put)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_7a9fb55f","line":40,"range":{"start_line":40,"start_character":8,"end_line":40,"end_character":45},"in_reply_to":"bae84128_ec6b86ef","updated":"2016-04-04 08:26:05.000000000","message":"Done","commit_id":"de00d768071b5e26206101106a1a8e22eff037f2"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"6e023a3f0ba7461b3fe8eb98a4763b5ecd26dc38","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def create_policy_association_for_endpoint(self, policy, endpoint):"},{"line_number":41,"context_line":"        \"\"\"Create an association between a policy and an endpoint.\"\"\""},{"line_number":42,"context_line":"        self._act_on_policy_association_for_endpoint("},{"line_number":43,"context_line":"            policy, endpoint, self._put)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def check_policy_association_for_endpoint(self, policy, endpoint):"},{"line_number":46,"context_line":"        \"\"\"Check an association between a policy and an endpoint.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_1ed5fae6","line":43,"range":{"start_line":43,"start_character":30,"end_line":43,"end_character":39},"updated":"2016-02-25 01:23:39.000000000","message":"IMO, the _put() function also get a request_id.","commit_id":"de00d768071b5e26206101106a1a8e22eff037f2"},{"author":{"_account_id":11704,"name":"Maho Koshiya","email":"koshiya.maho@po.ntt-tx.co.jp","username":"koshi-m"},"change_message_id":"649760f99ff6609b975021f3577195abbf84a041","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def create_policy_association_for_endpoint(self, policy, endpoint):"},{"line_number":41,"context_line":"        \"\"\"Create an association between a policy and an endpoint.\"\"\""},{"line_number":42,"context_line":"        self._act_on_policy_association_for_endpoint("},{"line_number":43,"context_line":"            policy, endpoint, self._put)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def check_policy_association_for_endpoint(self, policy, endpoint):"},{"line_number":46,"context_line":"        \"\"\"Check an association between a policy and an endpoint.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_fae745aa","line":43,"range":{"start_line":43,"start_character":30,"end_line":43,"end_character":39},"in_reply_to":"bae84128_1ed5fae6","updated":"2016-04-04 08:26:05.000000000","message":"You are right. So, I added the check tests of a request_id to test_endpoint_policy.py.","commit_id":"de00d768071b5e26206101106a1a8e22eff037f2"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"6f15de50cfcabcb71c4f3a5968af90ac6965af9d","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def create_policy_association_for_endpoint(self, policy, endpoint):"},{"line_number":42,"context_line":"        \"\"\"Create an association between a policy and an endpoint.\"\"\""},{"line_number":43,"context_line":"        return self._act_on_policy_association_for_endpoint("},{"line_number":44,"context_line":"            policy, endpoint, self._put)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def check_policy_association_for_endpoint(self, policy, endpoint):"},{"line_number":47,"context_line":"        \"\"\"Check an association between a policy and an endpoint.\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_ac2db4ff","line":44,"range":{"start_line":43,"start_character":8,"end_line":44,"end_character":40},"updated":"2016-06-14 11:15:28.000000000","message":"why aren\u0027t these (this and the following) being wrapped with utils.add_request_ids ?","commit_id":"ceb3f96c2d82c10069c4bd8e0b68d8ef2ea4ed89"},{"author":{"_account_id":11704,"name":"Maho Koshiya","email":"koshiya.maho@po.ntt-tx.co.jp","username":"koshi-m"},"change_message_id":"92942fe8a02b4adeeb5be6f8066ac0f62b59ad37","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def create_policy_association_for_endpoint(self, policy, endpoint):"},{"line_number":42,"context_line":"        \"\"\"Create an association between a policy and an endpoint.\"\"\""},{"line_number":43,"context_line":"        return self._act_on_policy_association_for_endpoint("},{"line_number":44,"context_line":"            policy, endpoint, self._put)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def check_policy_association_for_endpoint(self, policy, endpoint):"},{"line_number":47,"context_line":"        \"\"\"Check an association between a policy and an endpoint.\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"3ac371cc_02e44239","line":44,"range":{"start_line":43,"start_character":8,"end_line":44,"end_character":40},"in_reply_to":"7aa08908_ac2db4ff","updated":"2016-08-19 09:05:39.000000000","message":"Wrap response object with request_ids is unnecessary here, because self._put can wrap it.","commit_id":"ceb3f96c2d82c10069c4bd8e0b68d8ef2ea4ed89"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"449c19b8815e505be9f03ad113a4e3b80c3105ae","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def create_policy_association_for_endpoint(self, policy, endpoint):"},{"line_number":41,"context_line":"        \"\"\"Create an association between a policy and an endpoint.\"\"\""},{"line_number":42,"context_line":"        return self._act_on_policy_association_for_endpoint("},{"line_number":43,"context_line":"            policy, endpoint, self._put)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def check_policy_association_for_endpoint(self, policy, endpoint):"},{"line_number":46,"context_line":"        \"\"\"Check an association between a policy and an endpoint.\"\"\""}],"source_content_type":"text/x-python","patch_set":19,"id":"3f79a3b5_fea7ce51","line":43,"range":{"start_line":43,"start_character":35,"end_line":43,"end_character":39},"updated":"2018-11-29 11:41:55.000000000","message":"A good point from Neha:\nFor the `PUT `request of which response body is None, the request-id won\u0027t in the Response.\n\nI think it\u0027s a bug, we should at least put `request_id` into Response if \"include_metadata\u003dTrue\"","commit_id":"e7621bddc16de6371a05567a8ab23e7ccd67fba7"},{"author":{"_account_id":26541,"name":"Neha Alhat","email":"neha.alhat@nttdata.com","username":"nehaalhat"},"change_message_id":"cca2fcf5420457593182a3c8d6e28d096c4f3f54","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def create_policy_association_for_endpoint(self, policy, endpoint):"},{"line_number":41,"context_line":"        \"\"\"Create an association between a policy and an endpoint.\"\"\""},{"line_number":42,"context_line":"        return self._act_on_policy_association_for_endpoint("},{"line_number":43,"context_line":"            policy, endpoint, self._put)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def check_policy_association_for_endpoint(self, policy, endpoint):"},{"line_number":46,"context_line":"        \"\"\"Check an association between a policy and an endpoint.\"\"\""}],"source_content_type":"text/x-python","patch_set":19,"id":"3f79a3b5_91fa4b0e","line":43,"range":{"start_line":43,"start_character":35,"end_line":43,"end_character":39},"in_reply_to":"3f79a3b5_fea7ce51","updated":"2018-11-29 11:49:52.000000000","message":"Working on fixing this.","commit_id":"e7621bddc16de6371a05567a8ab23e7ccd67fba7"}],"keystoneclient/v3/contrib/simple_cert.py":[{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"6e023a3f0ba7461b3fe8eb98a4763b5ecd26dc38","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    def __init__(self, client):"},{"line_number":23,"context_line":"        self._client \u003d client"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def convert_into_with_meta(self, item, resp):"},{"line_number":26,"context_line":"        if isinstance(resp.text, six.string_types):"},{"line_number":27,"context_line":"            if six.PY2 and isinstance(resp.text, six.text_type):"},{"line_number":28,"context_line":"                return base._UnicodeWithMeta(resp.text, resp)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_4c1c32c1","line":25,"range":{"start_line":25,"start_character":8,"end_line":25,"end_character":30},"updated":"2016-02-25 01:23:39.000000000","message":"Same codes show up too many times,just like this[1].\n\n[1]:https://review.openstack.org/#/c/267449/7/keystoneclient/v2_0/certificates.py@25","commit_id":"de00d768071b5e26206101106a1a8e22eff037f2"},{"author":{"_account_id":11704,"name":"Maho Koshiya","email":"koshiya.maho@po.ntt-tx.co.jp","username":"koshi-m"},"change_message_id":"649760f99ff6609b975021f3577195abbf84a041","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    def __init__(self, client):"},{"line_number":23,"context_line":"        self._client \u003d client"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def convert_into_with_meta(self, item, resp):"},{"line_number":26,"context_line":"        if isinstance(resp.text, six.string_types):"},{"line_number":27,"context_line":"            if six.PY2 and isinstance(resp.text, six.text_type):"},{"line_number":28,"context_line":"                return base._UnicodeWithMeta(resp.text, resp)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_bd0f672d","line":25,"range":{"start_line":25,"start_character":8,"end_line":25,"end_character":30},"in_reply_to":"bae84128_4c1c32c1","updated":"2016-04-04 08:26:05.000000000","message":"Done","commit_id":"de00d768071b5e26206101106a1a8e22eff037f2"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"2def198b5a4246932a8cea2ccd70736531001f20","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        resp, body \u003d self._client.get(\u0027/OS-SIMPLE-CERT/ca\u0027,"},{"line_number":33,"context_line":"                                      authenticated\u003dFalse)"},{"line_number":34,"context_line":"        return self.mgr._convert_into_with_meta(resp.text, resp)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def get_certificates(self):"},{"line_number":37,"context_line":"        \"\"\"Get signing certificates."}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_490a3f7a","line":34,"range":{"start_line":34,"start_character":23,"end_line":34,"end_character":47},"updated":"2016-04-07 03:47:28.000000000","message":"Internal function _convert_into_with_meta should not be called here. If we are sure about the return type, we can avoid using this function here.\nI think we should just return base.XXXXWithMeta() here.","commit_id":"169cb890e40081c04193800633f4f0315a824a13"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"2def198b5a4246932a8cea2ccd70736531001f20","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        resp, body \u003d self._client.get(\u0027/OS-SIMPLE-CERT/certificates\u0027,"},{"line_number":45,"context_line":"                                      authenticated\u003dFalse)"},{"line_number":46,"context_line":"        return self.mgr._convert_into_with_meta(resp.text, resp)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_290f0b89","line":46,"range":{"start_line":46,"start_character":24,"end_line":46,"end_character":47},"updated":"2016-04-07 03:47:28.000000000","message":"Same as previous.","commit_id":"169cb890e40081c04193800633f4f0315a824a13"}]}