)]}'
{"id":"openstack%2Fpython-keystoneclient~268198","triplet_id":"openstack%2Fpython-keystoneclient~master~I6ebdfa3bf6faf37bc11640a5826b3b55bb920fc4","project":"openstack/python-keystoneclient","branch":"master","topic":"bug/1534299","hashtags":[],"change_id":"I6ebdfa3bf6faf37bc11640a5826b3b55bb920fc4","subject":"Mark password/secret options as secret","status":"MERGED","created":"2016-01-15 15:27:40.000000000","updated":"2016-01-16 00:31:29.000000000","submitted":"2016-01-16 00:31:29.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"88f5234e6a3986b656fa8e1bfe77122855653ea9","_number":268198,"virtual_id_number":268198,"owner":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},{"value":2,"date":"2016-01-16 00:31:29.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2016-01-15 18:51:47.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":1,"date":"2016-01-15 20:06:39.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-01-15 22:38:01.000000000","_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-01-15 22:38:01.000000000","_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-01-15 18:51:47.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-01-15 20:06:39.000000000","updated_by":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"reviewer":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"state":"REVIEWER"},{"updated":"2016-01-15 22:38:01.000000000","updated_by":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"reviewer":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"state":"REVIEWER"},{"updated":"2016-01-16 00:31:29.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"158e1cf595776875087965312191491298263ce5","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2016-01-15 15:27:40.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9f4722c04d38340584eaf6d6c43af15054ab447d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-15 17:03:12.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/98/268198/1/check/gate-python-keystoneclient-pep8/f014acf/ : SUCCESS in 3m 06s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/98/268198/1/check/gate-python-keystoneclient-docs/c123843//doc/build/html/ : SUCCESS in 3m 32s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/98/268198/1/check/gate-python-keystoneclient-python27/66a9f5c/ : SUCCESS in 3m 18s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/98/268198/1/check/gate-python-keystoneclient-python34/111cc30/ : SUCCESS in 4m 00s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/98/268198/1/check/gate-tempest-dsvm-neutron-src-python-keystoneclient/deed3d1/ : SUCCESS in 1h 24m 14s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/98/268198/1/check/gate-keystoneclient-dsvm-functional/bd6f859/ : SUCCESS in 35m 18s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/98/268198/1/check/gate-python-keystoneclient-tox-bandit/70fa846/ : SUCCESS in 3m 39s","accounts_in_message":[],"_revision_number":1},{"id":"48d1c397c276e7f72baf8e9a7b7e2b1fc3ffab9c","author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"date":"2016-01-15 17:51:23.000000000","message":"Patch Set 1:\n\nIs there anyway we can test these? Maybe something similar to https://github.com/openstack/keystone/blob/81cfed9d1ca4e16c5194a458bd7295f53fb88c99/keystone/tests/unit/test_v3_identity.py#L464 ?","accounts_in_message":[],"_revision_number":1},{"id":"bc6f4c2cf242b5952b036ea704a6508535a01805","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-01-15 18:51:47.000000000","message":"Patch Set 1: Code-Review+2\n\n@Tom, we could probably design a test, but it\u0027s an oslo config option attribute, at that point we\u0027d be testing oslo.config code and even if there were a problem, we couldn\u0027t fix it in keysotneclient.","accounts_in_message":[],"_revision_number":1},{"id":"dbea069ccbb3caacce8177f58af681502ef370e0","author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"date":"2016-01-15 20:06:39.000000000","message":"Patch Set 1: Code-Review+1\n\n@Steve thanks! Everything here looks good to me.","accounts_in_message":[],"_revision_number":1},{"id":"0fc6aeb20c9f074796e041c87514075f949487b9","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2016-01-15 22:38:01.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"f4e46cfec2324d517d6dfd9e85519f7e6b79b6c2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-15 22:38:07.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"e49743786e38da2d3551789e877c132ef9119679","date":"2016-01-16 00:31:29.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"fee4ee9bacee67dffa4b9e4309f523bec9e9931d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-16 00:31:29.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/98/268198/1/gate/gate-python-keystoneclient-docs/ce49053//doc/build/html/ : SUCCESS in 3m 41s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/98/268198/1/gate/gate-python-keystoneclient-pep8/e728de8/ : SUCCESS in 3m 32s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/98/268198/1/gate/gate-python-keystoneclient-python27/675e3af/ : SUCCESS in 2m 47s\n- gate-python-keystoneclient-python34 http://logs.openstack.org/98/268198/1/gate/gate-python-keystoneclient-python34/bb300d2/ : SUCCESS in 3m 03s\n- gate-tempest-dsvm-neutron-src-python-keystoneclient http://logs.openstack.org/98/268198/1/gate/gate-tempest-dsvm-neutron-src-python-keystoneclient/8f7ee29/ : SUCCESS in 1h 52m 54s\n- gate-keystoneclient-dsvm-functional http://logs.openstack.org/98/268198/1/gate/gate-keystoneclient-dsvm-functional/3685823/ : SUCCESS in 26m 08s\n- gate-python-keystoneclient-tox-bandit http://logs.openstack.org/98/268198/1/gate/gate-python-keystoneclient-tox-bandit/f33f385/ : SUCCESS in 2m 59s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"04f9f33b4b6079d39c3feea0b1ec1211a1de6a04","revisions":{"04f9f33b4b6079d39c3feea0b1ec1211a1de6a04":{"kind":"REWORK","_number":1,"created":"2016-01-15 15:27:40.000000000","uploader":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"ref":"refs/changes/98/268198/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/98/268198/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/98/268198/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/98/268198/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/98/268198/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/98/268198/1"}}},"commit":{"parents":[{"commit":"977fc4c92c834e5f9124b8f18b3ebb68abb2a1f1","subject":"Merge \"Deprecate the baseclient.Client\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/977fc4c92c834e5f9124b8f18b3ebb68abb2a1f1"}]}],"author":{"name":"Brant Knudson","email":"bknudson@us.ibm.com","date":"2016-01-14 22:22:04.000000000","tz":-360},"committer":{"name":"Brant Knudson","email":"bknudson@us.ibm.com","date":"2016-01-14 22:22:04.000000000","tz":-360},"subject":"Mark password/secret options as secret","message":"Mark password/secret options as secret\n\nPassword, token, and secret options should be marked as secret\u003dTrue\nso that when the value is logged the logger knows to obfuscate the\nvalue.\n\nChange-Id: I6ebdfa3bf6faf37bc11640a5826b3b55bb920fc4\nCloses-Bug: 1534299\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/04f9f33b4b6079d39c3feea0b1ec1211a1de6a04"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/04f9f33b4b6079d39c3feea0b1ec1211a1de6a04"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}